[INFO] fetching crate polars-sql 0.43.1... [INFO] checking polars-sql-0.43.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate polars-sql 0.43.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate polars-sql 0.43.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polars-sql 0.43.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate polars-sql 0.43.1 [INFO] tweaked toml for crates.io crate polars-sql 0.43.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 222 packages to latest compatible versions [INFO] [stderr] Adding atoi_simd v0.15.6 (available: v0.16.0) [INFO] [stderr] Adding chrono-tz v0.8.6 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.2.1 (available: v0.4.0) [INFO] [stderr] Adding crossterm v0.27.0 (available: v0.28.1) [INFO] [stderr] Adding float-cmp v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding memmap2 v0.7.1 (available: v0.9.5) [INFO] [stderr] Adding planus v0.3.1 (available: v0.4.0) [INFO] [stderr] Adding simd-json v0.13.11 (available: v0.14.0) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding sqlparser v0.49.0 (available: v0.51.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding value-trait v0.8.1 (available: v0.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-core v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-implement v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-interface v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (available: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ea94bca44972abb91d5c17c0bd49adf564f90809f7f999019fea1ffa97c26b3 [INFO] running `Command { std: "docker" "start" "-a" "6ea94bca44972abb91d5c17c0bd49adf564f90809f7f999019fea1ffa97c26b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ea94bca44972abb91d5c17c0bd49adf564f90809f7f999019fea1ffa97c26b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ea94bca44972abb91d5c17c0bd49adf564f90809f7f999019fea1ffa97c26b3", kill_on_drop: false }` [INFO] [stdout] 6ea94bca44972abb91d5c17c0bd49adf564f90809f7f999019fea1ffa97c26b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d067011a50c30f371e2aac9528c30f426e0d3dd45105f91160b6bf4fb54ab468 [INFO] running `Command { std: "docker" "start" "-a" "d067011a50c30f371e2aac9528c30f426e0d3dd45105f91160b6bf4fb54ab468", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling psm v0.1.23 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Compiling polars-utils v0.43.1 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking polars-error v0.43.1 [INFO] [stderr] Compiling polars-schema v0.43.1 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling polars-arrow v0.43.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking itoap v1.0.1 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Compiling polars-compute v0.43.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling polars-core v0.43.1 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Compiling polars-ops v0.43.1 [INFO] [stderr] Checking unicode-reverse v1.0.9 [INFO] [stderr] Checking argminmax v0.6.2 [INFO] [stderr] Compiling recursive-proc-macro-impl v0.1.1 [INFO] [stderr] Compiling polars-plan v0.43.1 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling polars-lazy v0.43.1 [INFO] [stderr] Checking sqlparser v0.49.0 [INFO] [stderr] Checking recursive v0.1.1 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.8.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking polars-row v0.43.1 [INFO] [stderr] Checking polars-io v0.43.1 [INFO] [stderr] Checking polars-time v0.43.1 [INFO] [stderr] Checking polars-expr v0.43.1 [INFO] [stderr] Checking polars-mem-engine v0.43.1 [INFO] [stderr] Checking polars-sql v0.43.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ExactNumberInfo` [INFO] [stdout] --> src/types.rs:9:48 [INFO] [stdout] | [INFO] [stdout] 9 | ArrayElemTypeDef, DataType as SQLDataType, ExactNumberInfo, Ident, ObjectName, TimezoneInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ExactNumberInfo` [INFO] [stdout] --> src/types.rs:9:48 [INFO] [stdout] | [INFO] [stdout] 9 | ArrayElemTypeDef, DataType as SQLDataType, ExactNumberInfo, Ident, ObjectName, TimezoneInfo, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(polars_lazy::dsl::Expr, polars_lazy::dsl::Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functions.rs:1211:34 [INFO] [stdout] | [INFO] [stdout] 1210 | 3 => self.try_visit_ternary(|e: Expr, start: Expr, length: Expr| { [INFO] [stdout] | - ----- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1211 | Ok(match (start.clone(), length.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(polars_lazy::dsl::Expr, polars_lazy::dsl::Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functions.rs:1211:34 [INFO] [stdout] | [INFO] [stdout] 1210 | 3 => self.try_visit_ternary(|e: Expr, start: Expr, length: Expr| { [INFO] [stdout] | - ----- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1211 | Ok(match (start.clone(), length.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&UnaryOperator, polars_lazy::dsl::Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql_expr.rs:592:18 [INFO] [stdout] | [INFO] [stdout] 591 | let expr = self.visit_expr(expr)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 592 | Ok(match (op, expr.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql_expr.rs:865:18 [INFO] [stdout] | [INFO] [stdout] 859 | let trim_what = trim_what.as_ref().map(|e| self.visit_expr(e)).transpose()?; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 865 | Ok(match (trim_where, trim_what) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&UnaryOperator, polars_lazy::dsl::Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql_expr.rs:592:18 [INFO] [stdout] | [INFO] [stdout] 591 | let expr = self.visit_expr(expr)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 592 | Ok(match (op, expr.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sql_expr.rs:865:18 [INFO] [stdout] | [INFO] [stdout] 859 | let trim_what = trim_what.as_ref().map(|e| self.visit_expr(e)).transpose()?; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 865 | Ok(match (trim_where, trim_what) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-sql` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-sql` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d067011a50c30f371e2aac9528c30f426e0d3dd45105f91160b6bf4fb54ab468", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d067011a50c30f371e2aac9528c30f426e0d3dd45105f91160b6bf4fb54ab468", kill_on_drop: false }` [INFO] [stdout] d067011a50c30f371e2aac9528c30f426e0d3dd45105f91160b6bf4fb54ab468