[INFO] fetching crate pgrx-sql-entity-graph 0.12.4... [INFO] checking pgrx-sql-entity-graph-0.12.4 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate pgrx-sql-entity-graph 0.12.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pgrx-sql-entity-graph 0.12.4 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pgrx-sql-entity-graph 0.12.4 [INFO] finished tweaking crates.io crate pgrx-sql-entity-graph 0.12.4 [INFO] tweaked toml for crates.io crate pgrx-sql-entity-graph 0.12.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 71 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding fancy-regex v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding quick-xml v0.32.0 (available: v0.36.2) [INFO] [stderr] Adding supports-color v2.1.0 (available: v3.0.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 992e281dd5a40033c559887431a2ebd505cf4f4e2b8e056043ac52edf2606529 [INFO] running `Command { std: "docker" "start" "-a" "992e281dd5a40033c559887431a2ebd505cf4f4e2b8e056043ac52edf2606529", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "992e281dd5a40033c559887431a2ebd505cf4f4e2b8e056043ac52edf2606529", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "992e281dd5a40033c559887431a2ebd505cf4f4e2b8e056043ac52edf2606529", kill_on_drop: false }` [INFO] [stdout] 992e281dd5a40033c559887431a2ebd505cf4f4e2b8e056043ac52edf2606529 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 164a1ed5ffb2f5baa24206cb0fdd0e3d80c19aaea147eb4c9cb0f73b3f390479 [INFO] running `Command { std: "docker" "start" "-a" "164a1ed5ffb2f5baa24206cb0fdd0e3d80c19aaea147eb4c9cb0f73b3f390479", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking unescape v0.1.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking pgrx-sql-entity-graph v0.12.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg_extern/attribute.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | let items_iter = items.iter().map(|x| x.to_token_stream()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 93 | quote! { ::pgrx::pgrx_sql_entity_graph::ExternArgs::Requires(vec![#(#items_iter),*],) } [INFO] [stdout] | --------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg_extern/attribute.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | let items_iter = items.iter().map(|x| x.to_token_stream()).collect::>(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 93 | quote! { ::pgrx::pgrx_sql_entity_graph::ExternArgs::Requires(vec![#(#items_iter),*],) } [INFO] [stdout] | --------------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::boxed::Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg_extern/mod.rs:434:21 [INFO] [stdout] | [INFO] [stdout] 399 | let fcinfo_ident = syn::Ident::new("fcinfo", synthetic_ident_span); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | let mut lifetimes = signature [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 407 | let fc_lt = lifetimes [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | let fc_ltparam = syn::LifetimeParam::new(fc_lt.clone()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | let arg_pats = args.iter().map(|v| format_ident!("{}_", &v.pat)).collect::>(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let args_ident = proc_macro2::Ident::new("_args", Span::call_site()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let ret_ty = match &signature.output { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 438 | let wrapper_code = quote_spanned! { self.func.block.span() => [INFO] [stdout] | ____________________________________- [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] 439 | | fn _internal_wrapper<#lifetimes>(fcinfo: &mut ::pgrx::callconv::FcInfo<#fc_lt>) -> ::pgrx::datum::Datum<#fc_lt> { [INFO] [stdout] 440 | | #[allow(unused_unsafe)] [INFO] [stdout] 441 | | unsafe { [INFO] [stdout] ... | [INFO] [stdout] 465 | | datum.sans_lifetime() [INFO] [stdout] 466 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::boxed::Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pg_extern/mod.rs:434:21 [INFO] [stdout] | [INFO] [stdout] 399 | let fcinfo_ident = syn::Ident::new("fcinfo", synthetic_ident_span); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | let mut lifetimes = signature [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 407 | let fc_lt = lifetimes [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | let fc_ltparam = syn::LifetimeParam::new(fc_lt.clone()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | let arg_pats = args.iter().map(|v| format_ident!("{}_", &v.pat)).collect::>(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let args_ident = proc_macro2::Ident::new("_args", Span::call_site()); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 434 | let ret_ty = match &signature.output { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 438 | let wrapper_code = quote_spanned! { self.func.block.span() => [INFO] [stdout] | ____________________________________- [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] | |____________________________________| [INFO] [stdout] 439 | | fn _internal_wrapper<#lifetimes>(fcinfo: &mut ::pgrx::callconv::FcInfo<#fc_lt>) -> ::pgrx::datum::Datum<#fc_lt> { [INFO] [stdout] 440 | | #[allow(unused_unsafe)] [INFO] [stdout] 441 | | unsafe { [INFO] [stdout] ... | [INFO] [stdout] 465 | | datum.sans_lifetime() [INFO] [stdout] 466 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgrx-sql-entity-graph` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgrx-sql-entity-graph` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "164a1ed5ffb2f5baa24206cb0fdd0e3d80c19aaea147eb4c9cb0f73b3f390479", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "164a1ed5ffb2f5baa24206cb0fdd0e3d80c19aaea147eb4c9cb0f73b3f390479", kill_on_drop: false }` [INFO] [stdout] 164a1ed5ffb2f5baa24206cb0fdd0e3d80c19aaea147eb4c9cb0f73b3f390479