[INFO] fetching crate pfds 0.5.0... [INFO] checking pfds-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate pfds 0.5.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pfds 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pfds 0.5.0 [INFO] finished tweaking crates.io crate pfds 0.5.0 [INFO] tweaked toml for crates.io crate pfds 0.5.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55845741f64253f984c1f620b17e718548ce60525a0189aa743507c89a0f75a6 [INFO] running `Command { std: "docker" "start" "-a" "55845741f64253f984c1f620b17e718548ce60525a0189aa743507c89a0f75a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55845741f64253f984c1f620b17e718548ce60525a0189aa743507c89a0f75a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55845741f64253f984c1f620b17e718548ce60525a0189aa743507c89a0f75a6", kill_on_drop: false }` [INFO] [stdout] 55845741f64253f984c1f620b17e718548ce60525a0189aa743507c89a0f75a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44f9065d274891c2e6834bc6a3cf6b26a862aac2c4d35684bedfef3f08da78de [INFO] running `Command { std: "docker" "start" "-a" "44f9065d274891c2e6834bc6a3cf6b26a862aac2c4d35684bedfef3f08da78de", kill_on_drop: false }` [INFO] [stderr] Checking pfds v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub use hashmap::*; [INFO] [stdout] | ^^^^^^^^^^ the name `Iter` in the type namespace is first re-exported here [INFO] [stdout] 40 | pub use hashset::*; [INFO] [stdout] 41 | pub use list::*; [INFO] [stdout] | ------- but the name `Iter` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/lib.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub use hashmap::*; [INFO] [stdout] | ^^^^^^^^^^ the name `Iter` in the type namespace is first re-exported here [INFO] [stdout] 40 | pub use hashset::*; [INFO] [stdout] 41 | pub use list::*; [INFO] [stdout] | ------- but the name `Iter` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/hashset.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `root` [INFO] [stdout] --> src/tree.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | let root = new_path[0].clone(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_root` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `apply_data` and `apply_acc_recursive` are never used [INFO] [stdout] --> src/tree.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 27 | impl Node { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | fn apply_data Option>(&self, f: F) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | fn apply_acc_recursive (Acc, Option)>(&self, acc: &Acc, f: Arc) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `apply_acc_recursive` is never used [INFO] [stdout] --> src/tree.rs:256:8 [INFO] [stdout] | [INFO] [stdout] 149 | impl PathPriv { [INFO] [stdout] | -------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 256 | fn apply_acc_recursive (Acc, Option)>(&self, initial: &Acc, f: F) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::hash::Hash` [INFO] [stdout] --> src/hashset.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::hash::Hash; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `hashmap::Iter<'_, usize, i32>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashmap.rs:519:23 [INFO] [stdout] | [INFO] [stdout] 517 | let mut n = HashMap::empty(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 518 | n = n.insert(1, 1); [INFO] [stdout] 519 | for (k, v) in n.iter() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `hashset::Iter<'_, usize>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashset.rs:477:18 [INFO] [stdout] | [INFO] [stdout] 475 | let mut n = HashSet::empty(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | n = n.insert(1); [INFO] [stdout] 477 | for c in n.iter() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `list::Iter<'_, i32>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list.rs:309:18 [INFO] [stdout] | [INFO] [stdout] 298 | let mut l = List::empty(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | for i in l.iter() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `root` [INFO] [stdout] --> src/tree.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 211 | let root = new_path[0].clone(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_root` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:542:24 [INFO] [stdout] | [INFO] [stdout] 494 | let mut tree = Path::new(0); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 495 | let mut cs = std::collections::HashSet::new(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | let mut s = std::collections::HashSet::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 521 | let mut r = std::collections::HashSet::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | let mut checked_root: std::collections::HashSet = std::collections::HashSet::new(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 527 | let mut i = 0; [INFO] [stdout] 528 | let mut children = tree.root().children(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | assert_eq!(n.children().len(), 2); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:584:18 [INFO] [stdout] | [INFO] [stdout] 569 | let mut tree = Path::new(0); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 575 | let mut s = std::collections::HashSet::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | for c in tree.children() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:607:18 [INFO] [stdout] | [INFO] [stdout] 592 | let mut tree = Path::new(0); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | let mut s = std::collections::HashSet::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 607 | for c in tree.children() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `apply_data` and `apply_acc_recursive` are never used [INFO] [stdout] --> src/tree.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 27 | impl Node { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | fn apply_data Option>(&self, f: F) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | fn apply_acc_recursive (Acc, Option)>(&self, acc: &Acc, f: Arc) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `apply_acc_recursive` is never used [INFO] [stdout] --> src/tree.rs:256:8 [INFO] [stdout] | [INFO] [stdout] 149 | impl PathPriv { [INFO] [stdout] | -------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 256 | fn apply_acc_recursive (Acc, Option)>(&self, initial: &Acc, f: F) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pfds` (lib test) due to 7 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "44f9065d274891c2e6834bc6a3cf6b26a862aac2c4d35684bedfef3f08da78de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44f9065d274891c2e6834bc6a3cf6b26a862aac2c4d35684bedfef3f08da78de", kill_on_drop: false }` [INFO] [stdout] 44f9065d274891c2e6834bc6a3cf6b26a862aac2c4d35684bedfef3f08da78de