[INFO] fetching crate petalang 0.0.1... [INFO] checking petalang-0.0.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate petalang 0.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate petalang 0.0.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate petalang 0.0.1 [INFO] finished tweaking crates.io crate petalang 0.0.1 [INFO] tweaked toml for crates.io crate petalang 0.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate petalang 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5858de6e26c9a789f0da0e1cb6212510af9517470005e7a521503f0f1bcc953 [INFO] running `Command { std: "docker" "start" "-a" "f5858de6e26c9a789f0da0e1cb6212510af9517470005e7a521503f0f1bcc953", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5858de6e26c9a789f0da0e1cb6212510af9517470005e7a521503f0f1bcc953", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5858de6e26c9a789f0da0e1cb6212510af9517470005e7a521503f0f1bcc953", kill_on_drop: false }` [INFO] [stdout] f5858de6e26c9a789f0da0e1cb6212510af9517470005e7a521503f0f1bcc953 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a79c49636ff97461807658a789bf4db0fd867df2156df3a2bd9381b43aa9113f [INFO] running `Command { std: "docker" "start" "-a" "a79c49636ff97461807658a789bf4db0fd867df2156df3a2bd9381b43aa9113f", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling cc v1.0.100 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking object v0.36.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling rustyline-derive v0.10.0 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Checking rustyline v14.0.0 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking petalang v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/main.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | fn main() -> miette::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/main.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | .try_collect()?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/main.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | fn main() -> miette::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/main.rs:65:10 [INFO] [stdout] | [INFO] [stdout] 65 | .try_collect()?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Object<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval/builtins.rs:26:40 [INFO] [stdout] | [INFO] [stdout] 23 | fn len<'a>(a: Vec>, h: Hydrator) -> Result, Error> { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(Object::Integer(Int::fit(match &v.0.clone() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Node<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval/mod.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 34 | scope: MutScope<'a>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match node.0.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Object<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval/mod.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 95 | left: ContextualNode<'a>, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | right: ContextualNode<'a>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | scope: MutScope<'a>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let (left, right) = Object::coerce(left, right, h.clone())?; [INFO] [stdout] | ---- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | [INFO] [stdout] 106 | Ok(match (left.0.clone(), right.0.clone()) { [INFO] [stdout] | ________^ [INFO] [stdout] 107 | | (Object::Float(a), Object::Float(b)) => match verb { [INFO] [stdout] 108 | | Dyadic::Add => Object::Float(Float::fit(a.to_max_value() + b.to_max_value())), [INFO] [stdout] 109 | | Dyadic::Subtract => Object::Float(Float::fit(a.to_max_value() - b.to_max_value())), [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Object<'_>, Object<'_>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 45 | a: ContextualObject<'a>, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | b: ContextualObject<'a>, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(match (a.clone().0, b.clone().0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Object<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval/builtins.rs:26:40 [INFO] [stdout] | [INFO] [stdout] 23 | fn len<'a>(a: Vec>, h: Hydrator) -> Result, Error> { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(Object::Integer(Int::fit(match &v.0.clone() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Node<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval/mod.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 34 | scope: MutScope<'a>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | match node.0.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Object<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval/mod.rs:106:8 [INFO] [stdout] | [INFO] [stdout] 95 | left: ContextualNode<'a>, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | right: ContextualNode<'a>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | scope: MutScope<'a>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let (left, right) = Object::coerce(left, right, h.clone())?; [INFO] [stdout] | ---- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | [INFO] [stdout] 106 | Ok(match (left.0.clone(), right.0.clone()) { [INFO] [stdout] | ________^ [INFO] [stdout] 107 | | (Object::Float(a), Object::Float(b)) => match verb { [INFO] [stdout] 108 | | Dyadic::Add => Object::Float(Float::fit(a.to_max_value() + b.to_max_value())), [INFO] [stdout] 109 | | Dyadic::Subtract => Object::Float(Float::fit(a.to_max_value() - b.to_max_value())), [INFO] [stdout] ... | [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Object<'_>, Object<'_>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 45 | a: ContextualObject<'a>, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | b: ContextualObject<'a>, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Ok(match (a.clone().0, b.clone().0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `petalang` (bin "pet") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `petalang` (bin "pet" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a79c49636ff97461807658a789bf4db0fd867df2156df3a2bd9381b43aa9113f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a79c49636ff97461807658a789bf4db0fd867df2156df3a2bd9381b43aa9113f", kill_on_drop: false }` [INFO] [stdout] a79c49636ff97461807658a789bf4db0fd867df2156df3a2bd9381b43aa9113f