[INFO] fetching crate persistent-keystore-rs 0.0.8... [INFO] checking persistent-keystore-rs-0.0.8 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate persistent-keystore-rs 0.0.8 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate persistent-keystore-rs 0.0.8 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate persistent-keystore-rs 0.0.8 [INFO] finished tweaking crates.io crate persistent-keystore-rs 0.0.8 [INFO] tweaked toml for crates.io crate persistent-keystore-rs 0.0.8 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding downcast v0.10.0 (available: v0.11.0) [INFO] [stderr] Adding float-cmp v0.8.0 (available: v0.10.0) [INFO] [stderr] Adding fragile v1.2.2 (available: v2.0.0) [INFO] [stderr] Adding lz4_flex v0.9.5 (available: v0.11.3) [INFO] [stderr] Adding mockall v0.10.2 (available: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.10.2 (available: v0.13.0) [INFO] [stderr] Adding predicates v1.0.8 (available: v3.1.2) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding termtree v0.4.1 (available: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82680deb486e4532773bf5b12bf5103d34556cd4adfd92c3128d91e38c0a758c [INFO] running `Command { std: "docker" "start" "-a" "82680deb486e4532773bf5b12bf5103d34556cd4adfd92c3128d91e38c0a758c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82680deb486e4532773bf5b12bf5103d34556cd4adfd92c3128d91e38c0a758c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82680deb486e4532773bf5b12bf5103d34556cd4adfd92c3128d91e38c0a758c", kill_on_drop: false }` [INFO] [stdout] 82680deb486e4532773bf5b12bf5103d34556cd4adfd92c3128d91e38c0a758c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5f939b5bf1ee70daac7beea793536d9e9a838883d2baa650baa2f1beba9cac5 [INFO] running `Command { std: "docker" "start" "-a" "e5f939b5bf1ee70daac7beea793536d9e9a838883d2baa650baa2f1beba9cac5", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking lz4_flex v0.9.5 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking persistent-keystore-rs v0.0.8 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `errors::DatabaseError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:959:20 [INFO] [stdout] | [INFO] [stdout] 941 | let (mut c, table_builder) = create_client_table("EntryExtraUndefiniedField".to_string()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 957 | let result = c.insert("EntryExtraUndefiniedField".to_string(), extra_field); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 958 | [INFO] [stdout] 959 | if let Err(e) = result { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::DatabaseError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:988:20 [INFO] [stdout] | [INFO] [stdout] 971 | let (mut c, table_builder) = create_client_table("EntryTableDoesNotExist".to_string()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 986 | let result = c.insert("EntryTableDoesNotExist2".to_string(), extra_field); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 987 | [INFO] [stdout] 988 | if let Err(e) = result { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::DatabaseError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1016:20 [INFO] [stdout] | [INFO] [stdout] 1000 | let (mut c, table_builder) = create_client_table("EntrySuccessWithoutOptional".to_string()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1014 | let result = c.insert("EntrySuccessWithoutOptional".to_string(), extra_field); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1015 | [INFO] [stdout] 1016 | if let Err(e) = result { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::DatabaseError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1040:20 [INFO] [stdout] | [INFO] [stdout] 1023 | let (mut c, table_builder) = create_client_table("EntrySuccessWithOptional".to_string()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1038 | let result = c.insert("EntrySuccessWithOptional".to_string(), extra_field); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1039 | [INFO] [stdout] 1040 | if let Err(e) = result { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::DatabaseError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1116:20 [INFO] [stdout] | [INFO] [stdout] 1087 | let (mut c, table_builder) = create_client_table("SecondInsertFailure".to_string()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1102 | let result = c.insert("SecondInsertFailure".to_string(), entry_first); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1114 | let result = c.insert("SecondInsertFailure".to_string(), entry_second); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1115 | [INFO] [stdout] 1116 | if let Err(e) = result { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `persistent-keystore-rs` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "e5f939b5bf1ee70daac7beea793536d9e9a838883d2baa650baa2f1beba9cac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5f939b5bf1ee70daac7beea793536d9e9a838883d2baa650baa2f1beba9cac5", kill_on_drop: false }` [INFO] [stdout] e5f939b5bf1ee70daac7beea793536d9e9a838883d2baa650baa2f1beba9cac5