[INFO] fetching crate paxakos 0.13.0... [INFO] checking paxakos-0.13.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate paxakos 0.13.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate paxakos 0.13.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate paxakos 0.13.0 [INFO] finished tweaking crates.io crate paxakos 0.13.0 [INFO] tweaked toml for crates.io crate paxakos 0.13.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding gloo-timers v0.2.6 (available: v0.3.0) [INFO] [stderr] Adding send_wrapper v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db7fab49d7a6fa2bb5847fe46c66eca8398de940d1ab0fd5e3b7325845c996cd [INFO] running `Command { std: "docker" "start" "-a" "db7fab49d7a6fa2bb5847fe46c66eca8398de940d1ab0fd5e3b7325845c996cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db7fab49d7a6fa2bb5847fe46c66eca8398de940d1ab0fd5e3b7325845c996cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db7fab49d7a6fa2bb5847fe46c66eca8398de940d1ab0fd5e3b7325845c996cd", kill_on_drop: false }` [INFO] [stdout] db7fab49d7a6fa2bb5847fe46c66eca8398de940d1ab0fd5e3b7325845c996cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d57501f26612f78b0af2ce33b53032d66396be8cb44c7c110871462fcf528df [INFO] running `Command { std: "docker" "start" "-a" "3d57501f26612f78b0af2ce33b53032d66396be8cb44c7c110871462fcf528df", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking snarc v0.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking paxakos v0.13.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `FuturesUnordered, ErrorOf>>, {async block@src/node/inner.rs:546:28: 546:33}, {closure@src/node/inner.rs:546:24: 546:27}>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/inner.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 522 | this: SnarcRef, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 543 | let mut pending_responses: FuturesUnordered<_> = pending_responses [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FuturesUnordered

` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/inner.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 695 | this: SnarcRef, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 718 | let mut pending_responses: FuturesUnordered

= pending_responses.into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec<<::State as state::State>::Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/inner.rs:909:13 [INFO] [stdout] | [INFO] [stdout] 904 | this: SnarcRef, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 909 | let mut cluster = cluster.await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FuturesUnordered, ErrorOf>>, {async block@src/node/inner.rs:546:28: 546:33}, {closure@src/node/inner.rs:546:24: 546:27}>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/inner.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 522 | this: SnarcRef, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 543 | let mut pending_responses: FuturesUnordered<_> = pending_responses [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FuturesUnordered

` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/inner.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 695 | this: SnarcRef, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 718 | let mut pending_responses: FuturesUnordered

= pending_responses.into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec<<::State as state::State>::Node>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/inner.rs:909:13 [INFO] [stdout] | [INFO] [stdout] 904 | this: SnarcRef, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 909 | let mut cluster = cluster.await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Decision<::Yea, ::Nay, Infallible>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/state_keeper/mod.rs:700:31 [INFO] [stdout] | [INFO] [stdout] 699 | .filter_map(|(r, e)| { [INFO] [stdout] | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 700 | match self.voter.contemplate_proposal( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 701 | | r, [INFO] [stdout] 702 | | coord_num, [INFO] [stdout] 703 | | &e, [INFO] [stdout] 704 | | leader.as_ref(), [INFO] [stdout] 705 | | self.state.as_ref(), [INFO] [stdout] 706 | | ) { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node/commits.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 39 | if !cx.waker().borrow().will_wake(&self.waker.borrow()) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Waker` does not implement `Borrow`, so calling `borrow` on `&Waker` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 39 - if !cx.waker().borrow().will_wake(&self.waker.borrow()) { [INFO] [stdout] 39 + if !cx.waker().will_wake(&self.waker.borrow()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/node/state_keeper/mod.rs:1516:9 [INFO] [stdout] | [INFO] [stdout] 1494 | / fn proof_unsafe_send_impl_is_sound( [INFO] [stdout] 1495 | | spawn_args: SpawnArgs, [INFO] [stdout] 1496 | | start_result_sender: oneshot::Sender>, [INFO] [stdout] 1497 | | receiver: mpsc::Receiver>, [INFO] [stdout] ... | [INFO] [stdout] 1502 | | V: Send, [INFO] [stdout] 1503 | | B: Send, [INFO] [stdout] | |________________- move the `impl` block outside of this associated function `proof_unsafe_send_impl_is_sound` [INFO] [stdout] ... [INFO] [stdout] 1516 | unsafe impl> Send for Task [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----^^^^^----^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Task` is not local [INFO] [stdout] | `Send` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `paxakos` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Decision<::Yea, ::Nay, Infallible>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/state_keeper/mod.rs:700:31 [INFO] [stdout] | [INFO] [stdout] 699 | .filter_map(|(r, e)| { [INFO] [stdout] | ------ [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 700 | match self.voter.contemplate_proposal( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 701 | | r, [INFO] [stdout] 702 | | coord_num, [INFO] [stdout] 703 | | &e, [INFO] [stdout] 704 | | leader.as_ref(), [INFO] [stdout] 705 | | self.state.as_ref(), [INFO] [stdout] 706 | | ) { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/node/commits.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 39 | if !cx.waker().borrow().will_wake(&self.waker.borrow()) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Waker` does not implement `Borrow`, so calling `borrow` on `&Waker` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 39 - if !cx.waker().borrow().will_wake(&self.waker.borrow()) { [INFO] [stdout] 39 + if !cx.waker().will_wake(&self.waker.borrow()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/node/state_keeper/mod.rs:1516:9 [INFO] [stdout] | [INFO] [stdout] 1494 | / fn proof_unsafe_send_impl_is_sound( [INFO] [stdout] 1495 | | spawn_args: SpawnArgs, [INFO] [stdout] 1496 | | start_result_sender: oneshot::Sender>, [INFO] [stdout] 1497 | | receiver: mpsc::Receiver>, [INFO] [stdout] ... | [INFO] [stdout] 1502 | | V: Send, [INFO] [stdout] 1503 | | B: Send, [INFO] [stdout] | |________________- move the `impl` block outside of this associated function `proof_unsafe_send_impl_is_sound` [INFO] [stdout] ... [INFO] [stdout] 1516 | unsafe impl> Send for Task [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----^^^^^----^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Task` is not local [INFO] [stdout] | `Send` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `paxakos` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3d57501f26612f78b0af2ce33b53032d66396be8cb44c7c110871462fcf528df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d57501f26612f78b0af2ce33b53032d66396be8cb44c7c110871462fcf528df", kill_on_drop: false }` [INFO] [stdout] 3d57501f26612f78b0af2ce33b53032d66396be8cb44c7c110871462fcf528df