[INFO] fetching crate patternfly-yew 0.6.3... [INFO] checking patternfly-yew-0.6.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate patternfly-yew 0.6.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate patternfly-yew 0.6.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate patternfly-yew 0.6.3 [INFO] finished tweaking crates.io crate patternfly-yew 0.6.3 [INFO] tweaked toml for crates.io crate patternfly-yew 0.6.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 154 packages to latest compatible versions [INFO] [stderr] Adding gloo v0.8.1 (available: v0.11.0) [INFO] [stderr] Adding gloo v0.10.0 (available: v0.11.0) [INFO] [stderr] Adding gloo-console v0.2.3 (available: v0.3.0) [INFO] [stderr] Adding gloo-dialogs v0.1.1 (available: v0.2.0) [INFO] [stderr] Adding gloo-events v0.1.2 (available: v0.2.0) [INFO] [stderr] Adding gloo-file v0.2.3 (available: v0.3.0) [INFO] [stderr] Adding gloo-history v0.1.5 (available: v0.2.2) [INFO] [stderr] Adding gloo-net v0.3.1 (available: v0.6.0) [INFO] [stderr] Adding gloo-net v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding gloo-net v0.5.0 (available: v0.6.0) [INFO] [stderr] Adding gloo-render v0.1.1 (available: v0.2.0) [INFO] [stderr] Adding gloo-storage v0.2.2 (available: v0.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (available: v0.3.0) [INFO] [stderr] Adding gloo-utils v0.1.7 (available: v0.2.0) [INFO] [stderr] Adding gloo-worker v0.2.1 (available: v0.5.0) [INFO] [stderr] Adding gloo-worker v0.4.0 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding implicit-clone v0.4.9 (available: v0.5.0) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (available: v3.2.0) [INFO] [stderr] Adding serde-wasm-bindgen v0.5.0 (available: v0.6.5) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (available: v0.22.22) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a5e2bf596ceedbade07fab030d0ae94b9450bc9fc60653c628ebec2f16c0930 [INFO] running `Command { std: "docker" "start" "-a" "0a5e2bf596ceedbade07fab030d0ae94b9450bc9fc60653c628ebec2f16c0930", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a5e2bf596ceedbade07fab030d0ae94b9450bc9fc60653c628ebec2f16c0930", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a5e2bf596ceedbade07fab030d0ae94b9450bc9fc60653c628ebec2f16c0930", kill_on_drop: false }` [INFO] [stdout] 0a5e2bf596ceedbade07fab030d0ae94b9450bc9fc60653c628ebec2f16c0930 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9cf4f7e550d859f10958df935438d28b0bb8385f82984d294e2c42278b948bdf [INFO] running `Command { std: "docker" "start" "-a" "9cf4f7e550d859f10958df935438d28b0bb8385f82984d294e2c42278b948bdf", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.93 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling wasm-bindgen v0.2.93 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.93 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling gloo-worker-macros v0.1.0 [INFO] [stderr] Compiling implicit-clone-derive v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling yew-macro v0.21.0 [INFO] [stderr] Checking implicit-clone v0.4.9 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.93 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling yew-nested-router-macros v0.7.2 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.93 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking js-sys v0.3.70 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pinned v0.1.0 [INFO] [stderr] Checking prokio v0.1.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking web-sys v0.3.70 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.43 [INFO] [stderr] Checking serde-wasm-bindgen v0.6.5 [INFO] [stderr] Checking gloo-timers v0.3.0 [INFO] [stderr] Checking gloo-utils v0.2.0 [INFO] [stderr] Checking gloo-events v0.2.0 [INFO] [stderr] Checking gloo-render v0.2.0 [INFO] [stderr] Checking gloo-dialogs v0.2.0 [INFO] [stderr] Checking popper-rs-sys v0.3.2 [INFO] [stderr] Checking gloo-file v0.3.0 [INFO] [stderr] Checking gloo-storage v0.3.0 [INFO] [stderr] Checking gloo-history v0.2.2 [INFO] [stderr] Checking gloo-console v0.3.0 [INFO] [stderr] Checking gloo-net v0.4.0 [INFO] [stderr] Checking gloo-worker v0.4.0 [INFO] [stderr] Checking gloo-worker v0.5.0 [INFO] [stderr] Checking gloo-net v0.5.0 [INFO] [stderr] Checking gloo v0.11.0 [INFO] [stderr] Checking gloo v0.10.0 [INFO] [stderr] Checking yew v0.21.0 [INFO] [stderr] Checking yew-hooks v0.3.2 [INFO] [stderr] Checking popper-rs v0.3.2 [INFO] [stderr] Checking web-tools v0.2.3 [INFO] [stderr] Checking yew-nested-router v0.7.2 [INFO] [stderr] Checking yew-more-hooks v0.3.3 [INFO] [stderr] Checking patternfly-yew v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/dropdown.rs:93:37 [INFO] [stdout] | [INFO] [stdout] 92 | move |_: popper_rs::sys::ModifierArguments| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | if let Some(elem) = inside_ref.cast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/dropdown.rs:93:37 [INFO] [stdout] | [INFO] [stdout] 92 | move |_: popper_rs::sys::ModifierArguments| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | if let Some(elem) = inside_ref.cast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/form/select.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 72 | Callback::from(move |_evt: InputEvent| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | if let Some(ele) = node_ref.cast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/form/select.rs:73:32 [INFO] [stdout] | [INFO] [stdout] 72 | Callback::from(move |_evt: InputEvent| { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | if let Some(ele) = node_ref.cast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/slider.rs:241:30 [INFO] [stdout] | [INFO] [stdout] 239 | let ontouchstart = ctx.link().batch_callback(|e: TouchEvent| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | e.stop_propagation(); [INFO] [stdout] 241 | if let Some(t) = e.touches().get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/slider.rs:241:30 [INFO] [stdout] | [INFO] [stdout] 239 | let ontouchstart = ctx.link().batch_callback(|e: TouchEvent| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | e.stop_propagation(); [INFO] [stdout] 241 | if let Some(t) = e.touches().get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `yew::html::Scope` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/context.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 53 | fn from((ctx, f): (&Context, F)) -> Self { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Self::new(link.clone().context(Callback::from(move |v| { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/global_close.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 30 | let listener = Closure::wrap(Box::new(move |e: MouseEvent| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | if let Some(control_ref) = cloned_ref.get() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `yew::html::Scope` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/context.rs:56:19 [INFO] [stdout] | [INFO] [stdout] 53 | fn from((ctx, f): (&Context, F)) -> Self { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Self::new(link.clone().context(Callback::from(move |v| { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/global_close.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 30 | let listener = Closure::wrap(Box::new(move |e: MouseEvent| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | if let Some(control_ref) = cloned_ref.get() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/components/table/model/hook.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 207 | fn test_eq() { [INFO] [stdout] | ------------ move the `impl` block outside of this function `test_eq` [INFO] [stdout] ... [INFO] [stdout] 211 | impl TableEntryRenderer<()> for String { [INFO] [stdout] | ^^^^^------------------^^^^^^^^^------ [INFO] [stdout] | | | [INFO] [stdout] | | `String` is not local [INFO] [stdout] | `TableEntryRenderer` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patternfly-yew` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `patternfly-yew` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9cf4f7e550d859f10958df935438d28b0bb8385f82984d294e2c42278b948bdf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cf4f7e550d859f10958df935438d28b0bb8385f82984d294e2c42278b948bdf", kill_on_drop: false }` [INFO] [stdout] 9cf4f7e550d859f10958df935438d28b0bb8385f82984d294e2c42278b948bdf