[INFO] fetching crate parity-db 0.4.13... [INFO] checking parity-db-0.4.13 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate parity-db 0.4.13 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate parity-db 0.4.13 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate parity-db 0.4.13 [INFO] finished tweaking crates.io crate parity-db 0.4.13 [INFO] tweaked toml for crates.io crate parity-db 0.4.13 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 102 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (available: v0.11.5) [INFO] [stderr] Adding fdlimit v0.2.1 (available: v0.3.0) [INFO] [stderr] Adding generator v0.7.5 (available: v0.8.3) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding loom v0.5.6 (available: v0.7.2) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding memmap2 v0.5.10 (available: v0.9.5) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.48.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5baea76b12a0b20390c318e3541ff871b0696d3acc7ce7b079df142b84cccaf [INFO] running `Command { std: "docker" "start" "-a" "a5baea76b12a0b20390c318e3541ff871b0696d3acc7ce7b079df142b84cccaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5baea76b12a0b20390c318e3541ff871b0696d3acc7ce7b079df142b84cccaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5baea76b12a0b20390c318e3541ff871b0696d3acc7ce7b079df142b84cccaf", kill_on_drop: false }` [INFO] [stdout] a5baea76b12a0b20390c318e3541ff871b0696d3acc7ce7b079df142b84cccaf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 129305f903d8f813e573811c5e9a9ba2927442e3d35eef43033e512e33abb7e2 [INFO] running `Command { std: "docker" "start" "-a" "129305f903d8f813e573811c5e9a9ba2927442e3d35eef43033e512e33abb7e2", kill_on_drop: false }` [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling lz4-sys v1.11.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking fdlimit v0.2.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking lz4 v1.27.0 [INFO] [stderr] Checking parity-db v0.4.13 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `parking_lot::lock_api::RwLockReadGuard<'_, parking_lot::RawRwLock, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:235:24 [INFO] [stdout] | [INFO] [stdout] 235 | if let Some(map) = &*self.map.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:93:3 [INFO] [stdout] | [INFO] [stdout] 93 | $e.map_err(crate::error::Error::Io)? [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:624:9 [INFO] [stdout] | [INFO] [stdout] 620 | let mut file = try_io!(std::fs::OpenOptions::new().read(true).write(true).open(path)); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | match Self::read_first_record_id(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:93:3 [INFO] [stdout] | [INFO] [stdout] 93 | $e.map_err(crate::error::Error::Io)? [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(u32, u64, File)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:803:41 [INFO] [stdout] | [INFO] [stdout] 795 | let mut reading = self.reading.write(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | if let Some((id, _record_id, file)) = self.replay_queue.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::RwLockReadGuard<'_, parking_lot::RawRwLock, VecDeque<(u32, File)>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:836:7 [INFO] [stdout] | [INFO] [stdout] 825 | let mut pool = self.log_pool.write(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | Ok(!self.cleanup_queue.read().is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:855:9 [INFO] [stdout] | [INFO] [stdout] 854 | let mut reader = LogReader::new(reading, validate); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 855 | match reader.next() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::RwLockReadGuard<'_, parking_lot::RawRwLock, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:235:24 [INFO] [stdout] | [INFO] [stdout] 235 | if let Some(map) = &*self.map.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:93:3 [INFO] [stdout] | [INFO] [stdout] 93 | $e.map_err(crate::error::Error::Io)? [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:624:9 [INFO] [stdout] | [INFO] [stdout] 620 | let mut file = try_io!(std::fs::OpenOptions::new().read(true).write(true).open(path)); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 624 | match Self::read_first_record_id(&mut file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/error.rs:93:3 [INFO] [stdout] | [INFO] [stdout] 93 | $e.map_err(crate::error::Error::Io)? [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parity-db` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option<(u32, u64, File)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:803:41 [INFO] [stdout] | [INFO] [stdout] 795 | let mut reading = self.reading.write(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 803 | if let Some((id, _record_id, file)) = self.replay_queue.write().pop_front() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::RwLockReadGuard<'_, parking_lot::RawRwLock, VecDeque<(u32, File)>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:836:7 [INFO] [stdout] | [INFO] [stdout] 825 | let mut pool = self.log_pool.write(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | Ok(!self.cleanup_queue.read().is_empty()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:855:9 [INFO] [stdout] | [INFO] [stdout] 854 | let mut reader = LogReader::new(reading, validate); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 855 | match reader.next() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parity-db` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "129305f903d8f813e573811c5e9a9ba2927442e3d35eef43033e512e33abb7e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "129305f903d8f813e573811c5e9a9ba2927442e3d35eef43033e512e33abb7e2", kill_on_drop: false }` [INFO] [stdout] 129305f903d8f813e573811c5e9a9ba2927442e3d35eef43033e512e33abb7e2