[INFO] fetching crate pacosso 0.2.5... [INFO] checking pacosso-0.2.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate pacosso 0.2.5 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pacosso 0.2.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pacosso 0.2.5 [INFO] finished tweaking crates.io crate pacosso 0.2.5 [INFO] tweaked toml for crates.io crate pacosso 0.2.5 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29d7faccfdbc6b85892effc961f01f8650448f47134918296fb7bc2f2641ab8a [INFO] running `Command { std: "docker" "start" "-a" "29d7faccfdbc6b85892effc961f01f8650448f47134918296fb7bc2f2641ab8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29d7faccfdbc6b85892effc961f01f8650448f47134918296fb7bc2f2641ab8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29d7faccfdbc6b85892effc961f01f8650448f47134918296fb7bc2f2641ab8a", kill_on_drop: false }` [INFO] [stdout] 29d7faccfdbc6b85892effc961f01f8650448f47134918296fb7bc2f2641ab8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4731cbf5ce1b51ca478d7c68d5f04403eac2d862be064263f7c1871622dacc2a [INFO] running `Command { std: "docker" "start" "-a" "4731cbf5ce1b51ca478d7c68d5f04403eac2d862be064263f7c1871622dacc2a", kill_on_drop: false }` [INFO] [stderr] Checking pacosso v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:265:55 [INFO] [stdout] | [INFO] [stdout] 246 | impl<'a, R: Read> Stream<'a, R> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 265 | pub fn new(opts: Opts, reader: &'a mut R) -> Stream { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:265:55 [INFO] [stdout] | [INFO] [stdout] 246 | impl<'a, R: Read> Stream<'a, R> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 265 | pub fn new(opts: Opts, reader: &'a mut R) -> Stream { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:161:11 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn parse_file(f: OsString, opts: Opts, parse: F) -> ParseResult [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | match File::open(f) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1744:15 [INFO] [stdout] | [INFO] [stdout] 1740 | pub fn optional(&mut self, parse: F) -> ParseResult> [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1744 | match parse(self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pacosso` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:161:11 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn parse_file(f: OsString, opts: Opts, parse: F) -> ParseResult [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | match File::open(f) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1744:15 [INFO] [stdout] | [INFO] [stdout] 1740 | pub fn optional(&mut self, parse: F) -> ParseResult> [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1744 | match parse(self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:169:19 [INFO] [stdout] | [INFO] [stdout] 168 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | assert!(match s.byte('@' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:179:19 [INFO] [stdout] | [INFO] [stdout] 178 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | assert!(match s.byte('?' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:197:23 [INFO] [stdout] | [INFO] [stdout] 195 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | for i in 0..32 { [INFO] [stdout] 197 | assert!(match s.byte('@' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 207 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | for i in 0..33 { [INFO] [stdout] 209 | assert!(match s.byte('@' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:225:19 [INFO] [stdout] | [INFO] [stdout] 224 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | assert!(match s.character('@') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:235:19 [INFO] [stdout] | [INFO] [stdout] 234 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | assert!(match s.character('ß') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:245:19 [INFO] [stdout] | [INFO] [stdout] 244 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | assert!(match s.character('ö') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:263:23 [INFO] [stdout] | [INFO] [stdout] 261 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | for _ in 0..32 { [INFO] [stdout] 263 | assert!(match s.character('ß') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:275:23 [INFO] [stdout] | [INFO] [stdout] 273 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | for i in 0..33 { [INFO] [stdout] 275 | assert!(match s.character('ß') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:291:19 [INFO] [stdout] | [INFO] [stdout] 290 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | assert!(match s.character('京') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:301:19 [INFO] [stdout] | [INFO] [stdout] 300 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | assert!(match s.character('中') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:319:23 [INFO] [stdout] | [INFO] [stdout] 317 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | for i in 0..32 { [INFO] [stdout] 319 | assert!(match s.character('京') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:331:23 [INFO] [stdout] | [INFO] [stdout] 329 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | for i in 0..33 { [INFO] [stdout] 331 | assert!(match s.character('京') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:617:23 [INFO] [stdout] | [INFO] [stdout] 607 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 617 | assert!(match s.byte('@' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:653:23 [INFO] [stdout] | [INFO] [stdout] 639 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | assert!(match s.byte('@' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:1161:19 [INFO] [stdout] | [INFO] [stdout] 1119 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1156 | let mut s = Stream::new(Opts::default() [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1161 | assert!(match parse2(&mut s) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(String, String), error::ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:1211:23 [INFO] [stdout] | [INFO] [stdout] 1170 | let mut s = to_stream(&mut input); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1211 | let r = match parse2(&mut s) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pacosso` (lib test) due to 20 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4731cbf5ce1b51ca478d7c68d5f04403eac2d862be064263f7c1871622dacc2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4731cbf5ce1b51ca478d7c68d5f04403eac2d862be064263f7c1871622dacc2a", kill_on_drop: false }` [INFO] [stdout] 4731cbf5ce1b51ca478d7c68d5f04403eac2d862be064263f7c1871622dacc2a