[INFO] fetching crate oxisynth 0.0.5... [INFO] checking oxisynth-0.0.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate oxisynth 0.0.5 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate oxisynth 0.0.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oxisynth 0.0.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate oxisynth 0.0.5 [INFO] tweaked toml for crates.io crate oxisynth 0.0.5 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate oxisynth 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c52365fa132f57fba05ffe3dbead79bae5b9e4f4f252ed4207059adcbc7cc70 [INFO] running `Command { std: "docker" "start" "-a" "0c52365fa132f57fba05ffe3dbead79bae5b9e4f4f252ed4207059adcbc7cc70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c52365fa132f57fba05ffe3dbead79bae5b9e4f4f252ed4207059adcbc7cc70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c52365fa132f57fba05ffe3dbead79bae5b9e4f4f252ed4207059adcbc7cc70", kill_on_drop: false }` [INFO] [stdout] 0c52365fa132f57fba05ffe3dbead79bae5b9e4f4f252ed4207059adcbc7cc70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6bb5e7e330eade46f9c7d642ee0ac486776853d27b2a7e3d036503f8606c324 [INFO] running `Command { std: "docker" "start" "-a" "b6bb5e7e330eade46f9c7d642ee0ac486776853d27b2a7e3d036503f8606c324", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling thiserror v1.0.52 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking riff v1.0.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Checking soundfont v0.0.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.43 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.52 [INFO] [stderr] Compiling num-derive v0.4.1 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking oxisynth v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `TuningManager` [INFO] [stdout] --> src/synth.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::{Tuning, TuningManager}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TuningManager` [INFO] [stdout] --> src/synth.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | pub use crate::{Tuning, TuningManager}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/core/soundfont/generator.rs:12:51 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_GeneratorType` [INFO] [stdout] 13 | #[repr(u8)] [INFO] [stdout] 14 | pub enum GeneratorType { [INFO] [stdout] | ------------- `GeneratorType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synth/font.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 96 | let mut synth = Synth::new(SynthDescriptor::default()).unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let preset = font.preset(0, 0).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/core/soundfont/generator.rs:12:51 [INFO] [stdout] | [INFO] [stdout] 12 | #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_GeneratorType` [INFO] [stdout] 13 | #[repr(u8)] [INFO] [stdout] 14 | pub enum GeneratorType { [INFO] [stdout] | ------------- `GeneratorType` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oxisynth` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b6bb5e7e330eade46f9c7d642ee0ac486776853d27b2a7e3d036503f8606c324", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6bb5e7e330eade46f9c7d642ee0ac486776853d27b2a7e3d036503f8606c324", kill_on_drop: false }` [INFO] [stdout] b6bb5e7e330eade46f9c7d642ee0ac486776853d27b2a7e3d036503f8606c324