[INFO] fetching crate otrr 0.7.3... [INFO] checking otrr-0.7.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate otrr 0.7.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate otrr 0.7.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate otrr 0.7.3 [INFO] finished tweaking crates.io crate otrr 0.7.3 [INFO] tweaked toml for crates.io crate otrr 0.7.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding aes-ctr v0.6.0 (available: v0.99.99) [INFO] [stderr] Adding aes-soft v0.6.4 (available: v0.99.99) [INFO] [stderr] Adding aesni v0.10.0 (available: v0.99.99) [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cipher v0.2.5 (available: v0.4.4) [INFO] [stderr] Adding ctr v0.6.0 (available: v0.9.2) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding ring v0.16.20 (available: v0.17.8) [INFO] [stderr] Adding spin v0.5.2 (available: v0.9.8) [INFO] [stderr] Adding untrusted v0.7.1 (available: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2700c48e33c53e03230ee2e38a6d251f6e250ecb0664a7581c98d7ace5b57863 [INFO] running `Command { std: "docker" "start" "-a" "2700c48e33c53e03230ee2e38a6d251f6e250ecb0664a7581c98d7ace5b57863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2700c48e33c53e03230ee2e38a6d251f6e250ecb0664a7581c98d7ace5b57863", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2700c48e33c53e03230ee2e38a6d251f6e250ecb0664a7581c98d7ace5b57863", kill_on_drop: false }` [INFO] [stdout] 2700c48e33c53e03230ee2e38a6d251f6e250ecb0664a7581c98d7ace5b57863 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5090078b8021350b6a842f0403d449a857a9fa6bf2f8afa08c0ba31c95db9473 [INFO] running `Command { std: "docker" "start" "-a" "5090078b8021350b6a842f0403d449a857a9fa6bf2f8afa08c0ba31c95db9473", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking aes-soft v0.6.4 [INFO] [stderr] Checking ctr v0.6.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking aes-ctr v0.6.0 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dsa v0.6.3 [INFO] [stderr] Checking otrr v0.7.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `BigInt` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:1471:53 [INFO] [stdout] | [INFO] [stdout] 1453 | let T1 = &*G * &self.r1 + A1 * &self.c1; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1454 | let T2 = &*G * &self.r2 + A2 * &self.c2; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1455 | let T3 = &*G * &self.r3 + A3 * &self.c3; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1456 | let c = hash_to_scalar( [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1471 | constant::compare_scalars_distinct(&c, &(&self.c1 + &self.c2 + &self.c3).mod_floor(&*Q)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BigInt` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:1718:40 [INFO] [stdout] | [INFO] [stdout] 1709 | let result_x: BigInt = &(&self.x * &rhs.y + &self.y * &rhs.x) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1713 | let result_y: BigInt = &(&self.y * &rhs.y - &self.x * &rhs.x) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1718 | x: result_x.mod_floor(&P.to_bigint().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Version, EncodedMessageType)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:725:15 [INFO] [stdout] | [INFO] [stdout] 716 | fn handle(&mut self, encoded_message: EncodedMessage) -> Result { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 725 | match (&version, encoded_message.message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `otrr` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `BigInt` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:1471:53 [INFO] [stdout] | [INFO] [stdout] 1453 | let T1 = &*G * &self.r1 + A1 * &self.c1; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1454 | let T2 = &*G * &self.r2 + A2 * &self.c2; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1455 | let T3 = &*G * &self.r3 + A3 * &self.c3; [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1456 | let c = hash_to_scalar( [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1471 | constant::compare_scalars_distinct(&c, &(&self.c1 + &self.c2 + &self.c3).mod_floor(&*Q)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BigInt` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:1718:40 [INFO] [stdout] | [INFO] [stdout] 1709 | let result_x: BigInt = &(&self.x * &rhs.y + &self.y * &rhs.x) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1713 | let result_y: BigInt = &(&self.y * &rhs.y - &self.x * &rhs.x) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1718 | x: result_x.mod_floor(&P.to_bigint().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Version, EncodedMessageType)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:725:15 [INFO] [stdout] | [INFO] [stdout] 716 | fn handle(&mut self, encoded_message: EncodedMessage) -> Result { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 725 | match (&version, encoded_message.message) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `otrr` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "5090078b8021350b6a842f0403d449a857a9fa6bf2f8afa08c0ba31c95db9473", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5090078b8021350b6a842f0403d449a857a9fa6bf2f8afa08c0ba31c95db9473", kill_on_drop: false }` [INFO] [stdout] 5090078b8021350b6a842f0403d449a857a9fa6bf2f8afa08c0ba31c95db9473