[INFO] fetching crate ola-lang 0.1.1... [INFO] checking ola-lang-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ola-lang 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ola-lang 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ola-lang 0.1.1 [INFO] finished tweaking crates.io crate ola-lang 0.1.1 [INFO] tweaked toml for crates.io crate ola-lang 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate ola-lang 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ced44bdf719e34d5b04a6b41511d512474effa1f3ea646bab974d4a00e4b0d9f [INFO] running `Command { std: "docker" "start" "-a" "ced44bdf719e34d5b04a6b41511d512474effa1f3ea646bab974d4a00e4b0d9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ced44bdf719e34d5b04a6b41511d512474effa1f3ea646bab974d4a00e4b0d9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ced44bdf719e34d5b04a6b41511d512474effa1f3ea646bab974d4a00e4b0d9f", kill_on_drop: false }` [INFO] [stdout] ced44bdf719e34d5b04a6b41511d512474effa1f3ea646bab974d4a00e4b0d9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30a886f7153084d3a8e90312f48bd36337454db84f37109853b863d31e46b958 [INFO] running `Command { std: "docker" "start" "-a" "30a886f7153084d3a8e90312f48bd36337454db84f37109853b863d31e46b958", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling rustix v0.38.19 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling smallvec v1.11.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling hashbrown v0.14.1 [INFO] [stderr] Compiling bitflags v2.4.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling linux-raw-sys v0.4.10 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling parking_lot v0.12.1 [INFO] [stderr] Compiling indexmap v2.0.2 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling regex-automata v0.4.2 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling is-terminal v0.4.9 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling ena v0.14.2 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling inkwell v0.2.0 [INFO] [stderr] Compiling regex v1.10.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling inkwell_internals v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling llvm-sys v150.1.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking debug_print v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking id-arena v2.2.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking key-node-list v0.0.5 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Checking predicates v3.0.4 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking similar v2.3.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking color-backtrace v0.5.1 [INFO] [stderr] Compiling ola-parser v1.0.1 [INFO] [stderr] Checking ola-lang v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option>, std::option::Option>, std::option::Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/isa/ola/lower/store.rs:210:11 [INFO] [stdout] | [INFO] [stdout] 210 | match (dst_vreg, dst_slot, vreg, konst) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 252 | ctx.inst_seq.append(&mut vec![MachInstruction::new( [INFO] [stdout] | _______________________________________- [INFO] [stdout] 253 | | InstructionData { [INFO] [stdout] 254 | | opcode: Opcode::MSTOREi, [INFO] [stdout] 255 | | operands: vec![ [INFO] [stdout] | | _______________________________- [INFO] [stdout] 256 | || MOperand::new(OperandData::MemStart), [INFO] [stdout] 257 | || MOperand::new(OperandData::None), [INFO] [stdout] 258 | || MOperand::new(OperandData::Slot(slot)), [INFO] [stdout] ... || [INFO] [stdout] 268 | || }), [INFO] [stdout] 269 | || ], [INFO] [stdout] | ||_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | | }, [INFO] [stdout] 271 | | ctx.block_map[&ctx.cur_block], [INFO] [stdout] 272 | | )]); [INFO] [stdout] | |_______________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option>, std::option::Option>, std::option::Option>, std::option::Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen/isa/ola/lower/store.rs:210:11 [INFO] [stdout] | [INFO] [stdout] 210 | match (dst_vreg, dst_slot, vreg, konst) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 252 | ctx.inst_seq.append(&mut vec![MachInstruction::new( [INFO] [stdout] | _______________________________________- [INFO] [stdout] 253 | | InstructionData { [INFO] [stdout] 254 | | opcode: Opcode::MSTOREi, [INFO] [stdout] 255 | | operands: vec![ [INFO] [stdout] | | _______________________________- [INFO] [stdout] 256 | || MOperand::new(OperandData::MemStart), [INFO] [stdout] 257 | || MOperand::new(OperandData::None), [INFO] [stdout] 258 | || MOperand::new(OperandData::Slot(slot)), [INFO] [stdout] ... || [INFO] [stdout] 268 | || }), [INFO] [stdout] 269 | || ], [INFO] [stdout] | ||_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | | }, [INFO] [stdout] 271 | | ctx.block_map[&ctx.cur_block], [INFO] [stdout] 272 | | )]); [INFO] [stdout] | |_______________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ast::Expression` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sema/statements.rs:1185:13 [INFO] [stdout] | [INFO] [stdout] 1184 | .map(|(i, (expr_return_ty, func_return_ty))| { [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1185 | / Expression::Variable { [INFO] [stdout] 1186 | | loc: expr_returns.loc(), [INFO] [stdout] 1187 | | ty: expr_return_ty, [INFO] [stdout] 1188 | | var_no: i, [INFO] [stdout] 1189 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/sema/external_functions.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | for e in exprs { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 118 | while let Some(e) = exprs { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 118 | if let Some(e) = exprs { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `sema::ast::Expression` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sema/statements.rs:1185:13 [INFO] [stdout] | [INFO] [stdout] 1184 | .map(|(i, (expr_return_ty, func_return_ty))| { [INFO] [stdout] | ------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1185 | / Expression::Variable { [INFO] [stdout] 1186 | | loc: expr_returns.loc(), [INFO] [stdout] 1187 | | ty: expr_return_ty, [INFO] [stdout] 1188 | | var_no: i, [INFO] [stdout] 1189 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ola-lang` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/sema/external_functions.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | for e in exprs { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 118 | while let Some(e) = exprs { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 118 | if let Some(e) = exprs { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ola-lang` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "30a886f7153084d3a8e90312f48bd36337454db84f37109853b863d31e46b958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30a886f7153084d3a8e90312f48bd36337454db84f37109853b863d31e46b958", kill_on_drop: false }` [INFO] [stdout] 30a886f7153084d3a8e90312f48bd36337454db84f37109853b863d31e46b958