[INFO] fetching crate odbc-safe 0.6.0... [INFO] checking odbc-safe-0.6.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate odbc-safe 0.6.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate odbc-safe 0.6.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate odbc-safe 0.6.0 [INFO] finished tweaking crates.io crate odbc-safe 0.6.0 [INFO] tweaked toml for crates.io crate odbc-safe 0.6.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate odbc-safe 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7851de4e422a76a66a4647f191643912d7bef55fce880f6f0c71839477e6d199 [INFO] running `Command { std: "docker" "start" "-a" "7851de4e422a76a66a4647f191643912d7bef55fce880f6f0c71839477e6d199", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7851de4e422a76a66a4647f191643912d7bef55fce880f6f0c71839477e6d199", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7851de4e422a76a66a4647f191643912d7bef55fce880f6f0c71839477e6d199", kill_on_drop: false }` [INFO] [stdout] 7851de4e422a76a66a4647f191643912d7bef55fce880f6f0c71839477e6d199 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 787bcd739ce9947f87f90f30aa415874aa4d28dda9b4f4526e11bb445c4c2791 [INFO] running `Command { std: "docker" "start" "-a" "787bcd739ce9947f87f90f30aa415874aa4d28dda9b4f4526e11bb445c4c2791", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling odbc-sys v0.8.2 [INFO] [stderr] Checking odbc-safe v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> tests/lib.rs:183:32 [INFO] [stdout] | [INFO] [stdout] 183 | fn assert_no_diagnostic(diag: &Diagnostics) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 183 | fn assert_no_diagnostic(diag: &dyn Diagnostics) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> tests/lib.rs:199:26 [INFO] [stdout] | [INFO] [stdout] 199 | fn get_last_error(diag: &Diagnostics) -> String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 199 | fn get_last_error(diag: &dyn Diagnostics) -> String { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `odbc_safe::DataSource<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/lib.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 39 | let env: Environment = env.declare_version().unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let dbc = dbc.connect("DoesntExist", "", ""); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | if let Error(d) = dbc { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `odbc-safe` (test "lib") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "787bcd739ce9947f87f90f30aa415874aa4d28dda9b4f4526e11bb445c4c2791", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "787bcd739ce9947f87f90f30aa415874aa4d28dda9b4f4526e11bb445c4c2791", kill_on_drop: false }` [INFO] [stdout] 787bcd739ce9947f87f90f30aa415874aa4d28dda9b4f4526e11bb445c4c2791