[INFO] fetching crate octane 0.1.2... [INFO] checking octane-0.1.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate octane 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate octane 0.1.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate octane 0.1.2 [INFO] finished tweaking crates.io crate octane 0.1.2 [INFO] tweaked toml for crates.io crate octane 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate octane 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2be4c957f3b5ab0cdd5ac5958e3ee19c669dd83b3ffff030d50fac0d060d637c [INFO] running `Command { std: "docker" "start" "-a" "2be4c957f3b5ab0cdd5ac5958e3ee19c669dd83b3ffff030d50fac0d060d637c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2be4c957f3b5ab0cdd5ac5958e3ee19c669dd83b3ffff030d50fac0d060d637c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2be4c957f3b5ab0cdd5ac5958e3ee19c669dd83b3ffff030d50fac0d060d637c", kill_on_drop: false }` [INFO] [stdout] 2be4c957f3b5ab0cdd5ac5958e3ee19c669dd83b3ffff030d50fac0d060d637c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d1b729335cace9f7524bfb88a9c16a47f559a17ba5cfa1e596c6dd96cedd586 [INFO] running `Command { std: "docker" "start" "-a" "7d1b729335cace9f7524bfb88a9c16a47f559a17ba5cfa1e596c6dd96cedd586", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Compiling octane_macros v0.1.2 [INFO] [stderr] Compiling ring v0.16.15 [INFO] [stderr] Checking octane_json v0.1.2 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Checking webpki v0.21.3 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Checking rustls v0.18.0 [INFO] [stderr] Checking tokio-rustls v0.14.0 [INFO] [stderr] Checking octane v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `responder::Response` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 27 | Error::err($error_type, $settings, $stream).await?; [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | async fn serve(mut stream_async: S, server: Arc) -> Result<(), Box> [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let mut res = Response::new_from_slice(b""); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `responder::Response` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 27 | Error::err($error_type, $settings, $stream).await?; [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | async fn serve(mut stream_async: S, server: Arc) -> Result<(), Box> [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let mut res = Response::new_from_slice(b""); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:207:58 [INFO] [stdout] | [INFO] [stdout] 207 | ... Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 207 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 207 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:210:50 [INFO] [stdout] | [INFO] [stdout] 210 | ... Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 210 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 210 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:225:42 [INFO] [stdout] | [INFO] [stdout] 225 | Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 225 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 225 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:207:58 [INFO] [stdout] | [INFO] [stdout] 207 | ... Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 207 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 207 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:210:50 [INFO] [stdout] | [INFO] [stdout] 210 | ... Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 210 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 210 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:225:42 [INFO] [stdout] | [INFO] [stdout] 225 | Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 225 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 225 | Err(e) => std::panic::panic_any(e), [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `octane` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `octane` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7d1b729335cace9f7524bfb88a9c16a47f559a17ba5cfa1e596c6dd96cedd586", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d1b729335cace9f7524bfb88a9c16a47f559a17ba5cfa1e596c6dd96cedd586", kill_on_drop: false }` [INFO] [stdout] 7d1b729335cace9f7524bfb88a9c16a47f559a17ba5cfa1e596c6dd96cedd586