[INFO] fetching crate nu-utils 0.98.0... [INFO] checking nu-utils-0.98.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate nu-utils 0.98.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate nu-utils 0.98.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nu-utils 0.98.0 [INFO] finished tweaking crates.io crate nu-utils 0.98.0 [INFO] tweaked toml for crates.io crate nu-utils 0.98.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate nu-utils 0.98.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f2998e8a5f6a1ab219d4d69320ef738d7a9c4add5ed717c305f22cb9541277f [INFO] running `Command { std: "docker" "start" "-a" "1f2998e8a5f6a1ab219d4d69320ef738d7a9c4add5ed717c305f22cb9541277f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f2998e8a5f6a1ab219d4d69320ef738d7a9c4add5ed717c305f22cb9541277f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f2998e8a5f6a1ab219d4d69320ef738d7a9c4add5ed717c305f22cb9541277f", kill_on_drop: false }` [INFO] [stdout] 1f2998e8a5f6a1ab219d4d69320ef738d7a9c4add5ed717c305f22cb9541277f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95e4f80a32c2bb35d57d08c78ed8d6d5a56c95ac5f38ee22b2e2ce8effc0f81b [INFO] running `Command { std: "docker" "start" "-a" "95e4f80a32c2bb35d57d08c78ed8d6d5a56c95ac5f38ee22b2e2ce8effc0f81b", kill_on_drop: false }` [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking lscolors v0.17.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking nu-utils v0.98.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn have_permission(dir: impl AsRef) -> PermissionResult<'static> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | match dir.as_ref().metadata() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_cow.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn into_owned(self: SharedCow) -> T { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | // Optimized: if the Arc is not shared, just unwraps the Arc [INFO] [stdout] 23 | match Arc::try_unwrap(self.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `StdoutLock<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stdout_write_all_and_flush(output: T) -> Result<()> [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | stdout.lock().flush() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-utils` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn have_permission(dir: impl AsRef) -> PermissionResult<'static> { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | match dir.as_ref().metadata() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shared_cow.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn into_owned(self: SharedCow) -> T { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | // Optimized: if the Arc is not shared, just unwraps the Arc [INFO] [stdout] 23 | match Arc::try_unwrap(self.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `StdoutLock<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn stdout_write_all_and_flush(output: T) -> Result<()> [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | stdout.lock().flush() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nu-utils` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "95e4f80a32c2bb35d57d08c78ed8d6d5a56c95ac5f38ee22b2e2ce8effc0f81b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95e4f80a32c2bb35d57d08c78ed8d6d5a56c95ac5f38ee22b2e2ce8effc0f81b", kill_on_drop: false }` [INFO] [stdout] 95e4f80a32c2bb35d57d08c78ed8d6d5a56c95ac5f38ee22b2e2ce8effc0f81b