[INFO] fetching crate ntpd 1.3.0... [INFO] checking ntpd-1.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ntpd 1.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ntpd 1.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ntpd 1.3.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ntpd 1.3.0 [INFO] tweaked toml for crates.io crate ntpd 1.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ntpd 1.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 974ada1b05f99b04a33c139bebd8c700d543d2b78f81ed8d36c4ee4087eeaa78 [INFO] running `Command { std: "docker" "start" "-a" "974ada1b05f99b04a33c139bebd8c700d543d2b78f81ed8d36c4ee4087eeaa78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "974ada1b05f99b04a33c139bebd8c700d543d2b78f81ed8d36c4ee4087eeaa78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "974ada1b05f99b04a33c139bebd8c700d543d2b78f81ed8d36c4ee4087eeaa78", kill_on_drop: false }` [INFO] [stdout] 974ada1b05f99b04a33c139bebd8c700d543d2b78f81ed8d36c4ee4087eeaa78 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2e892d1c1ab69d09f01cac12bf2d1567824c84b5816b15341882f8ee1017a7e [INFO] running `Command { std: "docker" "start" "-a" "d2e892d1c1ab69d09f01cac12bf2d1567824c84b5816b15341882f8ee1017a7e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustls v0.23.13 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling ntpd v1.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking dbl v0.3.2 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking rustls-native-certs v0.7.3 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking clock-steering v0.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking toml_edit v0.22.21 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking cmac v0.7.2 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking aes-siv v0.7.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking timestamped-socket v0.2.5 [INFO] [stderr] Checking ntp-proto v1.3.0 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stdout] error: this value of type `Result<(), ::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 363 | msg: MsgForSystem, [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | if let Err(e) = self.handle_source_demobilize(index).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), ::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/system.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 363 | msg: MsgForSystem, [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | if let Err(e) = self.handle_source_demobilize(index).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/server.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut cur_socket = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | / tokio::select! { [INFO] [stdout] 180 | | recv_res = socket.recv(&mut buf) => { [INFO] [stdout] 181 | | match recv_res { [INFO] [stdout] 182 | | Ok(RecvResult { [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/server.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut cur_socket = None; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | / tokio::select! { [INFO] [stdout] 180 | | recv_res = socket.recv(&mut buf) => { [INFO] [stdout] 181 | | match recv_res { [INFO] [stdout] 182 | | Ok(RecvResult { [INFO] [stdout] ... | [INFO] [stdout] 224 | | } [INFO] [stdout] 225 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntpd` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `config::ntp_source::NtsSourceConfig` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:418:37 [INFO] [stdout] | [INFO] [stdout] 347 | let test: TestConfig = toml::from_str( [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | let test: TestConfig = toml::from_str( [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | let test: TestConfig = toml::from_str( [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 380 | let test: TestConfig = toml::from_str( [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | let test: TestConfig = toml::from_str( [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | let test: TestConfig = toml::from_str( [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | if let NtpSourceConfig::Nts(config) = test.source { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `config::ntp_source::NtsSourceConfig` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/config/ntp_source.rs:461:37 [INFO] [stdout] | [INFO] [stdout] 450 | let test: TestConfig = toml::from_str(&format!( [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 461 | if let NtpSourceConfig::Nts(config) = test.source { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::io::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/keyexchange.rs:924:34 [INFO] [stdout] | [INFO] [stdout] 921 | let error = result.unwrap_err(); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 924 | KeyExchangeError::Io(error) => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon/ntp_source.rs:465:34 [INFO] [stdout] | [INFO] [stdout] 463 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 464 | state.pending = true; [INFO] [stdout] 465 | if let Some(waker) = state.waker.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntpd` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "d2e892d1c1ab69d09f01cac12bf2d1567824c84b5816b15341882f8ee1017a7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2e892d1c1ab69d09f01cac12bf2d1567824c84b5816b15341882f8ee1017a7e", kill_on_drop: false }` [INFO] [stdout] d2e892d1c1ab69d09f01cac12bf2d1567824c84b5816b15341882f8ee1017a7e