[INFO] fetching crate ntge 0.1.0... [INFO] checking ntge-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ntge 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ntge 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ntge 0.1.0 [INFO] finished tweaking crates.io crate ntge 0.1.0 [INFO] tweaked toml for crates.io crate ntge 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ntge 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1616f3cfffe0d051f707e6468b10cc362375ba46c9b232e91eddc8257bba07e8 [INFO] running `Command { std: "docker" "start" "-a" "1616f3cfffe0d051f707e6468b10cc362375ba46c9b232e91eddc8257bba07e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1616f3cfffe0d051f707e6468b10cc362375ba46c9b232e91eddc8257bba07e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1616f3cfffe0d051f707e6468b10cc362375ba46c9b232e91eddc8257bba07e8", kill_on_drop: false }` [INFO] [stdout] 1616f3cfffe0d051f707e6468b10cc362375ba46c9b232e91eddc8257bba07e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30826d8c7c8856c630366cf2cb48dfaac21f4664ef58d1a5c7237aefada12b5d [INFO] running `Command { std: "docker" "start" "-a" "30826d8c7c8856c630366cf2cb48dfaac21f4664ef58d1a5c7237aefada12b5d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.18 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling cc v1.0.52 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling ryu v1.0.4 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking subtle v2.2.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.6 [INFO] [stderr] Compiling unicode-width v0.1.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling cbindgen v0.14.1 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling remove_dir_all v0.5.2 [INFO] [stderr] Compiling itoa v0.4.5 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Compiling walkdir v2.3.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ascii v0.9.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Compiling backtrace-sys v0.1.36 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Compiling jni v0.16.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Compiling clap v2.33.0 [INFO] [stderr] Checking half v1.5.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking md5 v0.6.1 [INFO] [stderr] Checking jni-sys v0.3.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking combine v3.8.1 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking bs58 v0.3.1 [INFO] [stderr] Checking bech32 v0.7.2 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking stream-cipher v0.3.2 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking universal-hash v0.3.0 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking aead v0.2.0 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking hmac v0.7.1 [INFO] [stderr] Checking sha2 v0.8.1 [INFO] [stderr] Checking poly1305 v0.5.2 [INFO] [stderr] Checking hkdf v0.8.0 [INFO] [stderr] Compiling tempfile v3.1.0 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling zeroize_derive v1.0.0 [INFO] [stderr] Checking zeroize v1.1.0 [INFO] [stderr] Checking chacha20 v0.3.4 [INFO] [stderr] Checking secrecy v0.6.0 [INFO] [stderr] Checking chacha20poly1305 v0.4.1 [INFO] [stderr] Checking curve25519-dalek v2.0.0 [INFO] [stderr] Checking serde_json v1.0.52 [INFO] [stderr] Checking serde_bytes v0.11.3 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Compiling toml v0.5.6 [INFO] [stderr] Checking x25519-dalek v0.6.0 [INFO] [stderr] Checking ed25519-dalek v1.0.0-pre.3 [INFO] [stderr] Checking bson v0.14.1 [INFO] [stderr] Compiling ntge-core v0.1.0 [INFO] [stderr] Checking ntge v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/encrypt.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 7 | let mut cmd = Command::new("cargo"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let output = match cmd [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | match output.stdin.unwrap().write_all(TESTSTRING.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ntge-keygen/main.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 34 | let matches = App::new("ntge-keygen") [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keypair = ed25519::keypair::create_keypair(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | if let Err(_) = create_file_and_write(private_key_file, private_key_content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntge` (example "encrypt") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/encrypt_sign.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 7 | let mut cmd = Command::new("cargo"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let output = match cmd [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | match output.stdin.unwrap().write_all(TESTSTRING.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntge` (bin "ntge-keygen") due to 2 previous errors [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/create.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 4 | let mut cmd = Command::new("cargo"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 5 | match cmd [INFO] [stdout] | ___________^ [INFO] [stdout] 6 | | .args(&["run", "--bin", "ntge-keygen"]) [INFO] [stdout] 7 | | .args(&["--", "-f", "example_key"]) [INFO] [stdout] 8 | | .spawn() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path` and `key_content` are never read [INFO] [stdout] --> src/bin/ntge/encrypt/recipient.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) struct Recipient { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 10 | pub(crate) path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] 11 | pub(crate) name: String, [INFO] [stdout] 12 | pub(crate) key_content: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Recipient` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntge` (example "encrypt_sign") due to 2 previous errors [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/bin/ntge/util.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct Identity { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 99 | pub(crate) path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Identity` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntge` (example "create") due to 2 previous errors [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/ntge-keygen/main.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 34 | let matches = App::new("ntge-keygen") [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let keypair = ed25519::keypair::create_keypair(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | if let Err(_) = create_file_and_write(private_key_file, private_key_content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ntge` (bin "ntge-keygen" test) due to 2 previous errors [INFO] [stdout] warning: fields `path` and `key_content` are never read [INFO] [stdout] --> src/bin/ntge/encrypt/recipient.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) struct Recipient { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 10 | pub(crate) path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] 11 | pub(crate) name: String, [INFO] [stdout] 12 | pub(crate) key_content: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Recipient` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/bin/ntge/util.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct Identity { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 99 | pub(crate) path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Identity` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "30826d8c7c8856c630366cf2cb48dfaac21f4664ef58d1a5c7237aefada12b5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30826d8c7c8856c630366cf2cb48dfaac21f4664ef58d1a5c7237aefada12b5d", kill_on_drop: false }` [INFO] [stdout] 30826d8c7c8856c630366cf2cb48dfaac21f4664ef58d1a5c7237aefada12b5d