[INFO] fetching crate nson 0.12.1... [INFO] checking nson-0.12.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate nson 0.12.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nson 0.12.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nson 0.12.1 [INFO] finished tweaking crates.io crate nson 0.12.1 [INFO] tweaked toml for crates.io crate nson 0.12.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate nson 0.12.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5fa8d1a001428bb7b2ea40e8f42df95b664f09ecba8d0814e428109a5f2571f1 [INFO] running `Command { std: "docker" "start" "-a" "5fa8d1a001428bb7b2ea40e8f42df95b664f09ecba8d0814e428109a5f2571f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5fa8d1a001428bb7b2ea40e8f42df95b664f09ecba8d0814e428109a5f2571f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fa8d1a001428bb7b2ea40e8f42df95b664f09ecba8d0814e428109a5f2571f1", kill_on_drop: false }` [INFO] [stdout] 5fa8d1a001428bb7b2ea40e8f42df95b664f09ecba8d0814e428109a5f2571f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3b81716d6e753986786560436ef675dc46ee2b3d5cf54d64dc6c870dee5142b [INFO] running `Command { std: "docker" "start" "-a" "e3b81716d6e753986786560436ef675dc46ee2b3d5cf54d64dc6c870dee5142b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking serde_bytes v0.11.5 [INFO] [stderr] Checking nson v0.12.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option<(std::string::String, value::Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:412:15 [INFO] [stdout] | [INFO] [stdout] 379 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | visitor: V [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let mut iter = value.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let (variant, value) = match iter.next() { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | match iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:492:15 [INFO] [stdout] | [INFO] [stdout] 491 | fn unit_variant(mut self) -> DecodeResult<()> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | match self.val.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:510:39 [INFO] [stdout] | [INFO] [stdout] 507 | fn tuple_variant(mut self, _len: usize, visitor: V) -> DecodeResult [INFO] [stdout] | -------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | if let Value::Array(fields) = self.val.take().ok_or(DecodeError::EndOfStream)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:529:41 [INFO] [stdout] | [INFO] [stdout] 523 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 524 | _fields: &'static [&'static str], [INFO] [stdout] 525 | visitor: V [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | if let Value::Message(fields) = self.val.take().ok_or(DecodeError::EndOfStream)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:599:15 [INFO] [stdout] | [INFO] [stdout] 596 | fn next_element_seed(&mut self, seed: T) -> DecodeResult> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 599 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(std::string::String, value::Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:629:15 [INFO] [stdout] | [INFO] [stdout] 626 | fn next_key_seed(&mut self, seed: K) -> DecodeResult> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nson` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option<(std::string::String, value::Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:412:15 [INFO] [stdout] | [INFO] [stdout] 379 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | visitor: V [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 404 | let mut iter = value.into_iter(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | [INFO] [stdout] 406 | let (variant, value) = match iter.next() { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | match iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:492:15 [INFO] [stdout] | [INFO] [stdout] 491 | fn unit_variant(mut self) -> DecodeResult<()> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 492 | match self.val.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:510:39 [INFO] [stdout] | [INFO] [stdout] 507 | fn tuple_variant(mut self, _len: usize, visitor: V) -> DecodeResult [INFO] [stdout] | -------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | if let Value::Array(fields) = self.val.take().ok_or(DecodeError::EndOfStream)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:529:41 [INFO] [stdout] | [INFO] [stdout] 523 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 524 | _fields: &'static [&'static str], [INFO] [stdout] 525 | visitor: V [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | if let Value::Message(fields) = self.val.take().ok_or(DecodeError::EndOfStream)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:599:15 [INFO] [stdout] | [INFO] [stdout] 596 | fn next_element_seed(&mut self, seed: T) -> DecodeResult> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 599 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(std::string::String, value::Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde_impl/decode.rs:629:15 [INFO] [stdout] | [INFO] [stdout] 626 | fn next_key_seed(&mut self, seed: K) -> DecodeResult> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nson` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "e3b81716d6e753986786560436ef675dc46ee2b3d5cf54d64dc6c870dee5142b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3b81716d6e753986786560436ef675dc46ee2b3d5cf54d64dc6c870dee5142b", kill_on_drop: false }` [INFO] [stdout] e3b81716d6e753986786560436ef675dc46ee2b3d5cf54d64dc6c870dee5142b