[INFO] fetching crate notp 2.1.0... [INFO] checking notp-2.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate notp 2.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate notp 2.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate notp 2.1.0 [INFO] finished tweaking crates.io crate notp 2.1.0 [INFO] tweaked toml for crates.io crate notp 2.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate notp 2.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7488a55fc941e591b2dea11445c2f99e4206a59aa691d5062c8fd8a1451408d [INFO] running `Command { std: "docker" "start" "-a" "e7488a55fc941e591b2dea11445c2f99e4206a59aa691d5062c8fd8a1451408d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7488a55fc941e591b2dea11445c2f99e4206a59aa691d5062c8fd8a1451408d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7488a55fc941e591b2dea11445c2f99e4206a59aa691d5062c8fd8a1451408d", kill_on_drop: false }` [INFO] [stdout] e7488a55fc941e591b2dea11445c2f99e4206a59aa691d5062c8fd8a1451408d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ce4e5ec251ad81e9e035e21fa46cf92fa50456b8326e7c216cd15f257071f7a [INFO] running `Command { std: "docker" "start" "-a" "7ce4e5ec251ad81e9e035e21fa46cf92fa50456b8326e7c216cd15f257071f7a", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling cc v1.0.54 [INFO] [stderr] Checking byte-tools v0.1.3 [INFO] [stderr] Checking smallvec v1.4.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking byte-tools v0.2.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking debug-helper v0.3.8 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking base64 v0.12.1 [INFO] [stderr] Checking crc-any v2.3.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking rustc-hex v1.0.0 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rpassword v4.0.5 [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Checking sled v0.31.0 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking generic-array v0.7.3 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking generic-array v0.11.1 [INFO] [stderr] Compiling ring v0.16.14 [INFO] [stderr] Checking digest v0.5.2 [INFO] [stderr] Checking digest-buffer v0.3.1 [INFO] [stderr] Checking crypto-mac v0.3.0 [INFO] [stderr] Checking block-cipher-trait v0.6.2 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking block-buffer v0.5.1 [INFO] [stderr] Checking md-5 v0.8.0 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking hmac v0.1.1 [INFO] [stderr] Checking des v0.3.0 [INFO] [stderr] Checking block-modes v0.3.3 [INFO] [stderr] Checking sha-1 v0.3.4 [INFO] [stderr] Checking tiger-digest v0.1.1 [INFO] [stderr] Checking sha2 v0.5.3 [INFO] [stderr] Checking aes-soft v0.3.3 [INFO] [stderr] Checking oath v0.10.2 [INFO] [stderr] Checking magic-crypt v3.1.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling thiserror-impl v1.0.19 [INFO] [stderr] Checking thiserror v1.0.19 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking kv v0.20.2 [INFO] [stderr] Checking notp v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), NotpError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/add.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub(crate) fn add(request: Request<'_, T>) -> NotpResult<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let store: T = request.store; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | match store.insert(String::from(name), b64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), NotpError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operations/delete.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn delete(request: Request<'_, T>) -> NotpResult<()> { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | let store = request.store; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 9 | match store.delete(String::from(name)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `notp` (bin "notp") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7ce4e5ec251ad81e9e035e21fa46cf92fa50456b8326e7c216cd15f257071f7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ce4e5ec251ad81e9e035e21fa46cf92fa50456b8326e7c216cd15f257071f7a", kill_on_drop: false }` [INFO] [stdout] 7ce4e5ec251ad81e9e035e21fa46cf92fa50456b8326e7c216cd15f257071f7a