[INFO] fetching crate nix-query-tree-viewer 0.2.1... [INFO] checking nix-query-tree-viewer-0.2.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate nix-query-tree-viewer 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate nix-query-tree-viewer 0.2.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nix-query-tree-viewer 0.2.1 [INFO] finished tweaking crates.io crate nix-query-tree-viewer 0.2.1 [INFO] tweaked toml for crates.io crate nix-query-tree-viewer 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate nix-query-tree-viewer 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ccf70e72b582f565ca9dacb2afb88b56bc4557851b6d67ec4d7185cac59f45d6 [INFO] running `Command { std: "docker" "start" "-a" "ccf70e72b582f565ca9dacb2afb88b56bc4557851b6d67ec4d7185cac59f45d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ccf70e72b582f565ca9dacb2afb88b56bc4557851b6d67ec4d7185cac59f45d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccf70e72b582f565ca9dacb2afb88b56bc4557851b6d67ec4d7185cac59f45d6", kill_on_drop: false }` [INFO] [stdout] ccf70e72b582f565ca9dacb2afb88b56bc4557851b6d67ec4d7185cac59f45d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 304b8402ec709449270d1313dcb2b54ac7cd9904a7916a366fe3d950316528f4 [INFO] running `Command { std: "docker" "start" "-a" "304b8402ec709449270d1313dcb2b54ac7cd9904a7916a366fe3d950316528f4", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling glib-sys v0.9.1 [INFO] [stderr] Compiling gobject-sys v0.9.1 [INFO] [stderr] Compiling gio-sys v0.9.1 [INFO] [stderr] Compiling cairo-sys-rs v0.9.2 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.9.1 [INFO] [stderr] Compiling pango-sys v0.9.1 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling gdk-sys v0.9.1 [INFO] [stderr] Compiling atk-sys v0.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling gio v0.8.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling gtk-sys v0.9.2 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling cairo-rs v0.8.1 [INFO] [stderr] Compiling gdk-pixbuf v0.8.0 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Compiling pango v0.8.0 [INFO] [stderr] Compiling gdk v0.12.1 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling atk v0.8.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling gtk v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling unindent v0.1.7 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling structopt-derive v0.4.16 [INFO] [stderr] Compiling indoc-impl v0.3.6 [INFO] [stderr] Checking indoc v0.3.6 [INFO] [stderr] Checking structopt v0.3.23 [INFO] [stderr] Checking futures-executor v0.3.17 [INFO] [stderr] Checking glib v0.9.3 [INFO] [stderr] Checking nix-query-tree-viewer v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `glib::prelude::*` [INFO] [stdout] --> src/ui/prelude.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub use glib::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `glib::prelude::*` [INFO] [stdout] --> src/ui/prelude.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub use glib::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), glib::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/css.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 4 | let screen: gdk::Screen = match window.get_screen() { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | let css_provider = gtk::CssProvider::new(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let css_src = include_str!("../../style/style.css"); [INFO] [stdout] 13 | match css_provider.load_from_data(css_src.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Option, Option, i32, i32)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree/path.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 246 | let tree_view = state.get_tree_view(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | tree_view.get_path_at_pos(x as i32, y as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree/signals.rs:54:36 [INFO] [stdout] | [INFO] [stdout] 51 | tree_path: gtk::TreePath, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | if let Some(nix_store_res) = &*state.read_nix_store_res() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree/signals.rs:77:28 [INFO] [stdout] | [INFO] [stdout] 76 | let tree_view = state.get_tree_view(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | if let Some(display) = tree_view.get_display() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, SortOrder>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 108 | let tree_model_sort = state.get_tree_model_sort(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | match *state.read_sort_order() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree.rs:145:36 [INFO] [stdout] | [INFO] [stdout] 140 | tree_model: gtk::TreeModel, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | tree_model_sort_iter_a: gtk::TreeIter, [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | tree_model_sort_iter_b: gtk::TreeIter, [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | if let Some(nix_store_res) = &*state.read_nix_store_res() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nix-query-tree-viewer` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result<(), glib::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/css.rs:13:11 [INFO] [stdout] | [INFO] [stdout] 4 | let screen: gdk::Screen = match window.get_screen() { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | let css_provider = gtk::CssProvider::new(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let css_src = include_str!("../../style/style.css"); [INFO] [stdout] 13 | match css_provider.load_from_data(css_src.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(Option, Option, i32, i32)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree/path.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 246 | let tree_view = state.get_tree_view(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | tree_view.get_path_at_pos(x as i32, y as i32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree/signals.rs:54:36 [INFO] [stdout] | [INFO] [stdout] 51 | tree_path: gtk::TreePath, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | if let Some(nix_store_res) = &*state.read_nix_store_res() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree/signals.rs:77:28 [INFO] [stdout] | [INFO] [stdout] 76 | let tree_view = state.get_tree_view(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | if let Some(display) = tree_view.get_display() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, SortOrder>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 108 | let tree_model_sort = state.get_tree_model_sort(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | [INFO] [stdout] 110 | match *state.read_sort_order() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/stack/tree.rs:145:36 [INFO] [stdout] | [INFO] [stdout] 140 | tree_model: gtk::TreeModel, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | tree_model_sort_iter_a: gtk::TreeIter, [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | tree_model_sort_iter_b: gtk::TreeIter, [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | if let Some(nix_store_res) = &*state.read_nix_store_res() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nix-query-tree-viewer` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "304b8402ec709449270d1313dcb2b54ac7cd9904a7916a366fe3d950316528f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "304b8402ec709449270d1313dcb2b54ac7cd9904a7916a366fe3d950316528f4", kill_on_drop: false }` [INFO] [stdout] 304b8402ec709449270d1313dcb2b54ac7cd9904a7916a366fe3d950316528f4