[INFO] fetching crate nbd-async 0.6.0... [INFO] checking nbd-async-0.6.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate nbd-async 0.6.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate nbd-async 0.6.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nbd-async 0.6.0 [INFO] finished tweaking crates.io crate nbd-async 0.6.0 [INFO] tweaked toml for crates.io crate nbd-async 0.6.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate nbd-async 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7cd81b65c86bffda9b9e9d88653f04187353ff25e5d637fff1333c513def1dca [INFO] running `Command { std: "docker" "start" "-a" "7cd81b65c86bffda9b9e9d88653f04187353ff25e5d637fff1333c513def1dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7cd81b65c86bffda9b9e9d88653f04187353ff25e5d637fff1333c513def1dca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cd81b65c86bffda9b9e9d88653f04187353ff25e5d637fff1333c513def1dca", kill_on_drop: false }` [INFO] [stdout] 7cd81b65c86bffda9b9e9d88653f04187353ff25e5d637fff1333c513def1dca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca69f9c9f55a1764dfdc04da02581d9873147abe26f894aaf847cce4e211c55b [INFO] running `Command { std: "docker" "start" "-a" "ca69f9c9f55a1764dfdc04da02581d9873147abe26f894aaf847cce4e211c55b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling async-trait v0.1.56 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking futures-util v0.3.21 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking nix v0.24.1 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking nbd-async v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `RequestStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 114 | pub async fn serve_nbd(mut block_device: B, client: C) -> io::Result<()> [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut stream = RequestStream { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RequestStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 114 | pub async fn serve_nbd(mut block_device: B, client: C) -> io::Result<()> [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut stream = RequestStream { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:200:32 [INFO] [stdout] | [INFO] [stdout] 185 | let rc = Pin::new(client).poll_read(cx, &mut read_buf); [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Poll::Ready(Some(match nbd::Request::try_from_bytes(&self.read_buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `fua` and `no_hole` are never read [INFO] [stdout] --> src/nbd.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct RequestFlags { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 23 | /// Force Unit Access flag. [INFO] [stdout] 24 | pub fua: bool, [INFO] [stdout] | ^^^ [INFO] [stdout] 25 | /// No Hole flag. [INFO] [stdout] 26 | pub no_hole: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RequestFlags` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `magic` and `flags` are never read [INFO] [stdout] --> src/nbd.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Request { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 31 | pub magic: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 32 | pub command: Command, [INFO] [stdout] 33 | pub flags: RequestFlags, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Request` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbd-async` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device.rs:200:32 [INFO] [stdout] | [INFO] [stdout] 185 | let rc = Pin::new(client).poll_read(cx, &mut read_buf); [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Poll::Ready(Some(match nbd::Request::try_from_bytes(&self.read_buf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `fua` and `no_hole` are never read [INFO] [stdout] --> src/nbd.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct RequestFlags { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 23 | /// Force Unit Access flag. [INFO] [stdout] 24 | pub fua: bool, [INFO] [stdout] | ^^^ [INFO] [stdout] 25 | /// No Hole flag. [INFO] [stdout] 26 | pub no_hole: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RequestFlags` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `magic` and `flags` are never read [INFO] [stdout] --> src/nbd.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Request { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 31 | pub magic: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 32 | pub command: Command, [INFO] [stdout] 33 | pub flags: RequestFlags, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Request` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nbd-async` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ca69f9c9f55a1764dfdc04da02581d9873147abe26f894aaf847cce4e211c55b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca69f9c9f55a1764dfdc04da02581d9873147abe26f894aaf847cce4e211c55b", kill_on_drop: false }` [INFO] [stdout] ca69f9c9f55a1764dfdc04da02581d9873147abe26f894aaf847cce4e211c55b