[INFO] fetching crate narui_macros 0.1.0... [INFO] checking narui_macros-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate narui_macros 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate narui_macros 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate narui_macros 0.1.0 [INFO] finished tweaking crates.io crate narui_macros 0.1.0 [INFO] tweaked toml for crates.io crate narui_macros 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding proc-macro-crate v1.3.1 (available: v3.2.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding syn-rsx v0.8.1 (available: v0.9.0) [INFO] [stderr] Adding toml_edit v0.19.15 (available: v0.22.22) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f48e2976e2542e4d45c7acafd3255224052c6c5a07e74ca38d245a4be76d2005 [INFO] running `Command { std: "docker" "start" "-a" "f48e2976e2542e4d45c7acafd3255224052c6c5a07e74ca38d245a4be76d2005", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f48e2976e2542e4d45c7acafd3255224052c6c5a07e74ca38d245a4be76d2005", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f48e2976e2542e4d45c7acafd3255224052c6c5a07e74ca38d245a4be76d2005", kill_on_drop: false }` [INFO] [stdout] f48e2976e2542e4d45c7acafd3255224052c6c5a07e74ca38d245a4be76d2005 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 019932b35619b24176d3483310015afa2e20f9ae4b014cc9f7a0402a667efeb8 [INFO] running `Command { std: "docker" "start" "-a" "019932b35619b24176d3483310015afa2e20f9ae4b014cc9f7a0402a667efeb8", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking bind_match v0.1.2 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking proc-macro-crate v1.3.1 [INFO] [stderr] Checking proc-macro-error v1.0.4 [INFO] [stderr] Checking syn-rsx v0.8.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking narui_macros v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kw_arg_macro.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 62 | let expected_args_stream; [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let given_args_stream; [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(KwArgCallParse { [INFO] [stdout] 65 | span: input.parse()?, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | brace_1: braced!(expected_args_stream in input), [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | function_args: expected_args_stream.parse_terminated(ExprAssignMaybe::parse)?, [INFO] [stdout] 71 | brace_2: parenthesized!(given_args_stream in input), [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsx_macro.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 28 | fn handle_rsx_node(x: Node) -> (TokenStream, TokenStream) { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let narui = narui_crate(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let args_listenable_ident = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | .insert("children".to_string(), quote! {children={#(#inplace)*.into()}}); [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | quote! {children={#narui::smallvec![#(#inplace,)*]}}, [INFO] [stdout] | ---------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | quote! {#(#beginning)*} [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let beginning = quote! { [INFO] [stdout] | _________________________- [INFO] [stdout] | |_________________________| [INFO] [stdout] | |_________________________| [INFO] [stdout] 91 | | let (#key_ident, #idx_ident) = { [INFO] [stdout] 92 | | let fragment_store = &mut context.fragment_store; [INFO] [stdout] 93 | | let key = context.key_map.key_with(context.widget_local.key, #key, || fragment_store.add_empty_fragment().into()); [INFO] [stdout] ... | [INFO] [stdout] 113 | | }; [INFO] [stdout] 114 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widget_macro.rs:356:14 [INFO] [stdout] | [INFO] [stdout] 355 | let pat_type = bind_match!(arg.clone(), FnArg::Typed(x) => x).unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | (arg_ident(arg).to_string(), pat_type.ty) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/kw_arg_macro.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | None(Token![@]), [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MaybeExpr` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 23 | None(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kw_arg_macro.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 62 | let expected_args_stream; [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let given_args_stream; [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(KwArgCallParse { [INFO] [stdout] 65 | span: input.parse()?, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 69 | brace_1: braced!(expected_args_stream in input), [INFO] [stdout] | -------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | function_args: expected_args_stream.parse_terminated(ExprAssignMaybe::parse)?, [INFO] [stdout] 71 | brace_2: parenthesized!(given_args_stream in input), [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `narui_macros` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rsx_macro.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 28 | fn handle_rsx_node(x: Node) -> (TokenStream, TokenStream) { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let narui = narui_crate(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let args_listenable_ident = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | .insert("children".to_string(), quote! {children={#(#inplace)*.into()}}); [INFO] [stdout] | --------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | quote! {children={#narui::smallvec![#(#inplace,)*]}}, [INFO] [stdout] | ---------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | quote! {#(#beginning)*} [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let beginning = quote! { [INFO] [stdout] | _________________________- [INFO] [stdout] | |_________________________| [INFO] [stdout] | |_________________________| [INFO] [stdout] 91 | | let (#key_ident, #idx_ident) = { [INFO] [stdout] 92 | | let fragment_store = &mut context.fragment_store; [INFO] [stdout] 93 | | let key = context.key_map.key_with(context.widget_local.key, #key, || fragment_store.add_empty_fragment().into()); [INFO] [stdout] ... | [INFO] [stdout] 113 | | }; [INFO] [stdout] 114 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widget_macro.rs:356:14 [INFO] [stdout] | [INFO] [stdout] 355 | let pat_type = bind_match!(arg.clone(), FnArg::Typed(x) => x).unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | (arg_ident(arg).to_string(), pat_type.ty) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/kw_arg_macro.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | None(Token![@]), [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MaybeExpr` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 23 | None(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `narui_macros` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "019932b35619b24176d3483310015afa2e20f9ae4b014cc9f7a0402a667efeb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "019932b35619b24176d3483310015afa2e20f9ae4b014cc9f7a0402a667efeb8", kill_on_drop: false }` [INFO] [stdout] 019932b35619b24176d3483310015afa2e20f9ae4b014cc9f7a0402a667efeb8