[INFO] fetching crate nadi_core 0.3.0... [INFO] checking nadi_core-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate nadi_core 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate nadi_core 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nadi_core 0.3.0 [INFO] finished tweaking crates.io crate nadi_core 0.3.0 [INFO] tweaked toml for crates.io crate nadi_core 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 141 packages to latest compatible versions [INFO] [stderr] Adding joinery v2.1.0 (available: v3.1.0) [INFO] [stderr] Adding libloading v0.7.4 (available: v0.8.5) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding titlecase v2.2.1 (available: v3.3.0) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0cebbd8b763ed9a2075743a4922e40376c527a6b4a789417e53b05091fad984c [INFO] running `Command { std: "docker" "start" "-a" "0cebbd8b763ed9a2075743a4922e40376c527a6b4a789417e53b05091fad984c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0cebbd8b763ed9a2075743a4922e40376c527a6b4a789417e53b05091fad984c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cebbd8b763ed9a2075743a4922e40376c527a6b4a789417e53b05091fad984c", kill_on_drop: false }` [INFO] [stdout] 0cebbd8b763ed9a2075743a4922e40376c527a6b4a789417e53b05091fad984c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0cee90f61d5bcad852f304b8f398b8400647a347c57292780aaf4cf285531688 [INFO] running `Command { std: "docker" "start" "-a" "0cee90f61d5bcad852f304b8f398b8400647a347c57292780aaf4cf285531688", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling core_extensions v1.5.3 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling tstr_proc_macros v0.2.2 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling core_extensions_proc_macros v1.5.3 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking joinery v2.1.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling abi_stable_shared v0.11.0 [INFO] [stderr] Compiling typed-arena v2.0.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tstr v0.2.4 [INFO] [stderr] Checking titlecase v2.2.1 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling rstest_macros v0.22.0 [INFO] [stderr] Checking repr_offset v0.2.2 [INFO] [stderr] Checking rust_lisp v0.18.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling cfg-expr v0.17.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking const_panic v0.2.9 [INFO] [stderr] Checking use v0.0.1-pre.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking string-template-plus v0.4.3 [INFO] [stderr] Compiling nadi_plugin v0.3.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling serde_spanned v0.6.8 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Compiling as_derive_utils v0.11.0 [INFO] [stderr] Compiling abi_stable_derive v0.11.3 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling system-deps v7.0.3 [INFO] [stderr] Compiling glib-macros v0.20.4 [INFO] [stderr] Compiling glib-sys v0.20.4 [INFO] [stderr] Compiling gobject-sys v0.20.4 [INFO] [stderr] Compiling gio-sys v0.20.4 [INFO] [stderr] Compiling cairo-sys-rs v0.20.0 [INFO] [stderr] Checking rstest v0.22.0 [INFO] [stderr] Checking glib v0.20.4 [INFO] [stderr] Checking abi_stable v0.11.3 [INFO] [stderr] Checking cairo-rs v0.20.1 [INFO] [stderr] Checking nadi_core v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/functions.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 | #[sabi_trait] [INFO] [stdout] | -^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `NodeFunction_Interface` is not local [INFO] [stdout] | `InterfaceType` is not local [INFO] [stdout] | move the `impl` block outside of this constant `__inside_generated_mod` [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `sabi_trait` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `sabi_trait` may come from an old version of the `abi_stable_derive` crate, try updating your dependency with `cargo update -p abi_stable_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `sabi_trait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/functions.rs:140:1 [INFO] [stdout] | [INFO] [stdout] 140 | #[sabi_trait] [INFO] [stdout] | -^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `NetworkFunction_Interface` is not local [INFO] [stdout] | `InterfaceType` is not local [INFO] [stdout] | move the `impl` block outside of this constant `__inside_generated_mod` [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `sabi_trait` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `sabi_trait` may come from an old version of the `abi_stable_derive` crate, try updating your dependency with `cargo update -p abi_stable_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the attribute macro `sabi_trait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `attrs::Attribute` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/attrs.rs:380:20 [INFO] [stdout] | [INFO] [stdout] 379 | fn attr_any_test(#[case] txt: &str, #[case] value: Attribute, #[case] reminder: &str) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | let (rest, n) = attr_any(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(abi_stable::std_types::RString, attrs::Attribute)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/attrs.rs:398:20 [INFO] [stdout] | [INFO] [stdout] 395 | #[case] value: (&str, Attribute), [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | let (rest, n) = attr_key_val(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec<(abi_stable::std_types::RString, attrs::Attribute)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/attrs.rs:415:20 [INFO] [stdout] | [INFO] [stdout] 412 | #[case] value: Vec<(&str, Attribute)>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 415 | let (rest, n) = attr_group(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `functions::FunctionArg` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/functions.rs:178:20 [INFO] [stdout] | [INFO] [stdout] 177 | fn parse_arg_test(#[case] txt: &str, #[case] value: FunctionArg, #[case] reminder: &str) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let (rest, n) = parse_arg(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `functions::FunctionCall` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/functions.rs:202:20 [INFO] [stdout] | [INFO] [stdout] 201 | fn parse_function_test(#[case] txt: &str, #[case] value: FunctionCall, #[case] reminder: &str) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let (rest, n) = parse_function(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/functions.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 230 | #[case] value: Vec, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let (rest, n) = parse_script(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `table::Column` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/table.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 125 | fn column_test(#[case] txt: &str, #[case] value: Column, #[case] reminder: &str) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let (rest, n) = column(txt).unwrap(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/functions.rs:132:1 [INFO] [stdout] | [INFO] [stdout] 132 | #[sabi_trait] [INFO] [stdout] | -^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `NodeFunction_Interface` is not local [INFO] [stdout] | `InterfaceType` is not local [INFO] [stdout] | move the `impl` block outside of this constant `__inside_generated_mod` [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `sabi_trait` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `sabi_trait` may come from an old version of the `abi_stable_derive` crate, try updating your dependency with `cargo update -p abi_stable_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `sabi_trait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/functions.rs:140:1 [INFO] [stdout] | [INFO] [stdout] 140 | #[sabi_trait] [INFO] [stdout] | -^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `NetworkFunction_Interface` is not local [INFO] [stdout] | `InterfaceType` is not local [INFO] [stdout] | move the `impl` block outside of this constant `__inside_generated_mod` [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `sabi_trait` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `sabi_trait` may come from an old version of the `abi_stable_derive` crate, try updating your dependency with `cargo update -p abi_stable_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the attribute macro `sabi_trait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nadi_core` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0cee90f61d5bcad852f304b8f398b8400647a347c57292780aaf4cf285531688", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cee90f61d5bcad852f304b8f398b8400647a347c57292780aaf4cf285531688", kill_on_drop: false }` [INFO] [stdout] 0cee90f61d5bcad852f304b8f398b8400647a347c57292780aaf4cf285531688