[INFO] fetching crate mtrack 0.1.3... [INFO] checking mtrack-0.1.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate mtrack 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mtrack 0.1.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mtrack 0.1.3 [INFO] finished tweaking crates.io crate mtrack 0.1.3 [INFO] tweaked toml for crates.io crate mtrack 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mtrack 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bdbf7c615b6b34b76a48948c28c6860daedccf416f0d90be9156cf4694107fc9 [INFO] running `Command { std: "docker" "start" "-a" "bdbf7c615b6b34b76a48948c28c6860daedccf416f0d90be9156cf4694107fc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bdbf7c615b6b34b76a48948c28c6860daedccf416f0d90be9156cf4694107fc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdbf7c615b6b34b76a48948c28c6860daedccf416f0d90be9156cf4694107fc9", kill_on_drop: false }` [INFO] [stdout] bdbf7c615b6b34b76a48948c28c6860daedccf416f0d90be9156cf4694107fc9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21adf068b509a6d847ca5ccb7a1af1cd82963abfd210cfbd33e770d8d9810020 [INFO] running `Command { std: "docker" "start" "-a" "21adf068b509a6d847ca5ccb7a1af1cd82963abfd210cfbd33e770d8d9810020", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking ringbuf v0.3.3 [INFO] [stderr] Checking shh v1.0.1 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking midir v0.9.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking midly v0.5.3 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking nodi v1.0.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking serde_yaml v0.9.21 [INFO] [stderr] Checking mtrack v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:374:36 [INFO] [stdout] | [INFO] [stdout] 373 | fn emit_midi_event(midi_device: Option>, song: Arc) { [INFO] [stdout] | ----------- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | if let Some(midi_device) = midi_device.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 123 | let position = self.position.read().expect("unable to get lock"); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Arc::clone( [INFO] [stdout] 125 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | .registry [INFO] [stdout] 127 | | .get(&self.songs[*position]) [INFO] [stdout] 128 | | .expect("unable to find song in the registry"), [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtrack` (bin "mtrack") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/player.rs:374:36 [INFO] [stdout] | [INFO] [stdout] 373 | fn emit_midi_event(midi_device: Option>, song: Arc) { [INFO] [stdout] | ----------- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | if let Some(midi_device) = midi_device.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 123 | let position = self.position.read().expect("unable to get lock"); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Arc::clone( [INFO] [stdout] 125 | &self [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | .registry [INFO] [stdout] 127 | | .get(&self.songs[*position]) [INFO] [stdout] 128 | | .expect("unable to find song in the registry"), [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mtrack` (bin "mtrack" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "21adf068b509a6d847ca5ccb7a1af1cd82963abfd210cfbd33e770d8d9810020", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21adf068b509a6d847ca5ccb7a1af1cd82963abfd210cfbd33e770d8d9810020", kill_on_drop: false }` [INFO] [stdout] 21adf068b509a6d847ca5ccb7a1af1cd82963abfd210cfbd33e770d8d9810020