[INFO] fetching crate monkey_test 0.7.3... [INFO] checking monkey_test-0.7.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate monkey_test 0.7.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate monkey_test 0.7.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate monkey_test 0.7.3 [INFO] finished tweaking crates.io crate monkey_test 0.7.3 [INFO] tweaked toml for crates.io crate monkey_test 0.7.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2c5b663200cec3774af0fcdfe4090b61b53e854417bd402866255ee5de47a2a [INFO] running `Command { std: "docker" "start" "-a" "b2c5b663200cec3774af0fcdfe4090b61b53e854417bd402866255ee5de47a2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2c5b663200cec3774af0fcdfe4090b61b53e854417bd402866255ee5de47a2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2c5b663200cec3774af0fcdfe4090b61b53e854417bd402866255ee5de47a2a", kill_on_drop: false }` [INFO] [stdout] b2c5b663200cec3774af0fcdfe4090b61b53e854417bd402866255ee5de47a2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bab2a1ab32f2a8776eaf2b2d475d69cf0c21ddd4218613fcbf9353371913a6d6 [INFO] running `Command { std: "docker" "start" "-a" "bab2a1ab32f2a8776eaf2b2d475d69cf0c21ddd4218613fcbf9353371913a6d6", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking panic-message v0.3.0 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking monkey_test v0.7.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `E` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 212 | fn panic_on_err(result: MonkeyResult) [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | minimum_failure, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/float.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn completely_random_range(bound: B) -> BoxGen [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / gen::from_fn(move |seed| { [INFO] [stdout] 149 | | //let distr = rand::distributions::Uniform::new_inclusive(min, max); [INFO] [stdout] 150 | | let mut x = rand_chacha::ChaCha8Rng::seed_from_u64(seed); [INFO] [stdout] ... | [INFO] [stdout] 157 | | |f| to_twos_complement_bits(f), [INFO] [stdout] 158 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/integer.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn completely_random(bounds: B) -> BoxGen [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / crate::gen::from_fn(move |seed| { [INFO] [stdout] 44 | | let distr = rand::distributions::Uniform::new_inclusive(min, max); [INFO] [stdout] 45 | | rand_chacha::ChaCha8Rng::seed_from_u64(seed).sample_iter(distr) [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shrink/filter.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 10 | crate::shrink::from_fn(move |original: E| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | original_shrink.clone().candidates(original.clone()).filter( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shrink/vec.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 137 | original: Vec, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | elem_shrinker: BoxShrink, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | / original [INFO] [stdout] 146 | | .clone() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 235 | gen2: BoxGen, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | gen::zip(gen::zip(self.clone_box(), gen1), gen2.zip_3(gen3, gen4)).map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 255 | gen3: BoxGen, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | gen::zip(self.zip_3(gen1, gen2), gen3.zip_3(gen4, gen5)).map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `exponent_normal_max` and `fraction_normal_max` are never used [INFO] [stdout] --> src/gen/float_parts.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait FloatParts: std::fmt::Debug { [INFO] [stdout] | ---------- associated functions in this trait [INFO] [stdout] 9 | /// Max exponent value still being a finite (normal) number. [INFO] [stdout] 10 | fn exponent_normal_max() -> u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 13 | fn fraction_normal_max() -> u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monkey_test` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `E` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 212 | fn panic_on_err(result: MonkeyResult) [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | minimum_failure, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/float.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn completely_random_range(bound: B) -> BoxGen [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / gen::from_fn(move |seed| { [INFO] [stdout] 149 | | //let distr = rand::distributions::Uniform::new_inclusive(min, max); [INFO] [stdout] 150 | | let mut x = rand_chacha::ChaCha8Rng::seed_from_u64(seed); [INFO] [stdout] ... | [INFO] [stdout] 157 | | |f| to_twos_complement_bits(f), [INFO] [stdout] 158 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gen/integer.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn completely_random(bounds: B) -> BoxGen [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / crate::gen::from_fn(move |seed| { [INFO] [stdout] 44 | | let distr = rand::distributions::Uniform::new_inclusive(min, max); [INFO] [stdout] 45 | | rand_chacha::ChaCha8Rng::seed_from_u64(seed).sample_iter(distr) [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shrink/filter.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 10 | crate::shrink::from_fn(move |original: E| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | original_shrink.clone().candidates(original.clone()).filter( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shrink/vec.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 137 | original: Vec, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | elem_shrinker: BoxShrink, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | / original [INFO] [stdout] 146 | | .clone() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 235 | gen2: BoxGen, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | gen::zip(gen::zip(self.clone_box(), gen1), gen2.zip_3(gen3, gen4)).map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 255 | gen3: BoxGen, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 266 | gen::zip(self.zip_3(gen1, gen2), gen3.zip_3(gen4, gen5)).map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `monkey_test` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "bab2a1ab32f2a8776eaf2b2d475d69cf0c21ddd4218613fcbf9353371913a6d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bab2a1ab32f2a8776eaf2b2d475d69cf0c21ddd4218613fcbf9353371913a6d6", kill_on_drop: false }` [INFO] [stdout] bab2a1ab32f2a8776eaf2b2d475d69cf0c21ddd4218613fcbf9353371913a6d6