[INFO] fetching crate minijinja 2.3.1... [INFO] checking minijinja-2.3.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate minijinja 2.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate minijinja 2.3.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minijinja 2.3.1 [INFO] finished tweaking crates.io crate minijinja 2.3.1 [INFO] tweaked toml for crates.io crate minijinja 2.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 53 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e0d2c0aea3665f48e9edba595618ff9c7afedd18717bac483cbe2bc6e5f8914 [INFO] running `Command { std: "docker" "start" "-a" "8e0d2c0aea3665f48e9edba595618ff9c7afedd18717bac483cbe2bc6e5f8914", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e0d2c0aea3665f48e9edba595618ff9c7afedd18717bac483cbe2bc6e5f8914", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e0d2c0aea3665f48e9edba595618ff9c7afedd18717bac483cbe2bc6e5f8914", kill_on_drop: false }` [INFO] [stdout] 8e0d2c0aea3665f48e9edba595618ff9c7afedd18717bac483cbe2bc6e5f8914 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76be31a15d8b44f06c611ca16a0ec34d17ec89948d1e27b00f69f49385f04604 [INFO] running `Command { std: "docker" "start" "-a" "76be31a15d8b44f06c611ca16a0ec34d17ec89948d1e27b00f69f49385f04604", kill_on_drop: false }` [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking minijinja v2.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking similar-asserts v1.6.0 [INFO] [stdout] error: this value of type `Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/parser.rs:678:32 [INFO] [stdout] | [INFO] [stdout] 678 | "set" => match ok!(self.parse_set()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/macros.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / match $expr { [INFO] [stdout] 8 | | Ok(val) => val, [INFO] [stdout] 9 | | Err(err) => return Err(err), [INFO] [stdout] 10 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/parser.rs:869:17 [INFO] [stdout] | [INFO] [stdout] 53 | match ok!($parser.stream.next()) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 860 | let (target, in_paren) = if skip_token!(self, Token::ParenOpen) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 869 | let filter = if skip_token!(self, Token::Pipe) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:442:13 [INFO] [stdout] | [INFO] [stdout] 440 | ctx: S, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 441 | ) -> Result { [INFO] [stdout] 442 | ok!(self.template_from_named_str(name, source)).render(ctx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/macros.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / match $expr { [INFO] [stdout] 8 | | Ok(val) => val, [INFO] [stdout] 9 | | Err(err) => return Err(err), [INFO] [stdout] 10 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 455 | pub fn render_str(&self, source: &str, ctx: S) -> Result { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | ok!(self.template_from_str(source)).render(ctx) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/macros.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / match $expr { [INFO] [stdout] 8 | | Ok(val) => val, [INFO] [stdout] 9 | | Err(err) => return Err(err), [INFO] [stdout] 10 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Instructions<'_>, std::collections::BTreeMap<&str, Instructions<'_>>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:680:17 [INFO] [stdout] | [INFO] [stdout] 677 | parse_expr(expr).map(|ast| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | gen.finish().0 [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(std::option::Option, state::State<'_, '_>), error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | Ok(ok!(Vm::new(self.env).eval( [INFO] [stdout] | ________________^ [INFO] [stdout] 113 | | self.instructions(), [INFO] [stdout] 114 | | root, [INFO] [stdout] 115 | | &BTreeMap::new(), [INFO] [stdout] 116 | | &mut Output::null(), [INFO] [stdout] 117 | | crate::AutoEscape::None, [INFO] [stdout] 118 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/macros.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / match $expr { [INFO] [stdout] 8 | | Ok(val) => val, [INFO] [stdout] 9 | | Err(err) => return Err(err), [INFO] [stdout] 10 | | } [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `state::State<'_, '_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/mod.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 112 | caller: Option, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | &mut State { [INFO] [stdout] | __________________^ [INFO] [stdout] 125 | | env: self.env, [INFO] [stdout] 126 | | ctx, [INFO] [stdout] 127 | | current_block: None, [INFO] [stdout] ... | [INFO] [stdout] 139 | | fuel_tracker: state.fuel_tracker.clone(), [INFO] [stdout] 140 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/mod.rs:910:41 [INFO] [stdout] | [INFO] [stdout] 907 | value: Value, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 910 | match (value.as_str(), value == Value::from(true)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec<(value::Value, value::Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filters.rs:425:17 [INFO] [stdout] | [INFO] [stdout] 423 | pub fn dictsort(v: Value, kwargs: Kwargs) -> Result { [INFO] [stdout] | - ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | if v.kind() == ValueKind::Map { [INFO] [stdout] 425 | let mut rv = Vec::with_capacity(v.len().unwrap_or(0)); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 353 | pub fn is_iterable(v: Value) -> bool { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | v.try_iter().is_ok() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/serialize.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn transform(value: T) -> Value { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | match value.serialize(ValueSerializer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minijinja` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "76be31a15d8b44f06c611ca16a0ec34d17ec89948d1e27b00f69f49385f04604", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76be31a15d8b44f06c611ca16a0ec34d17ec89948d1e27b00f69f49385f04604", kill_on_drop: false }` [INFO] [stdout] 76be31a15d8b44f06c611ca16a0ec34d17ec89948d1e27b00f69f49385f04604