[INFO] fetching crate minbft 1.0.3... [INFO] checking minbft-1.0.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate minbft 1.0.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate minbft 1.0.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate minbft 1.0.3 [INFO] finished tweaking crates.io crate minbft 1.0.3 [INFO] tweaked toml for crates.io crate minbft 1.0.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 139 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rstest v0.16.0 (available: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.16.0 (available: v0.22.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 366cd70eabaa8cd824b7e4c63cb3def1a85740309426a6289637b96246354da0 [INFO] running `Command { std: "docker" "start" "-a" "366cd70eabaa8cd824b7e4c63cb3def1a85740309426a6289637b96246354da0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "366cd70eabaa8cd824b7e4c63cb3def1a85740309426a6289637b96246354da0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "366cd70eabaa8cd824b7e4c63cb3def1a85740309426a6289637b96246354da0", kill_on_drop: false }` [INFO] [stdout] 366cd70eabaa8cd824b7e4c63cb3def1a85740309426a6289637b96246354da0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48f3f15afd9546731213783b30057519274f7563bd0584496a9a7aae56ab2df5 [INFO] running `Command { std: "docker" "start" "-a" "48f3f15afd9546731213783b30057519274f7563bd0584496a9a7aae56ab2df5", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking trait-alias-macro v0.10.0 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling rstest_macros v0.16.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking shared-ids v0.11.0 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking rstest v0.16.0 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking usig v0.11.0 [INFO] [stderr] Checking minbft v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option::Signature>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer_message_processor/usig_message_processor/checkpoint_processor.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn process_checkpoint(&mut self, checkpoint: Checkpoint) { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | if let Some(cert) = self [INFO] [stdout] | _____________________________^ [INFO] [stdout] 43 | | .collector_checkpoints [INFO] [stdout] 44 | | .retrieve_collected_checkpoints(&checkpoint, &self.config) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option::Signature>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer_message_processor/usig_message_processor/new_view_processor.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 73 | new_view: NewView, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let (last_cp, mut unique_preps) = Self::compute_new_view_state( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `KeyCommits` is never constructed [INFO] [stdout] --> src/peer_message_processor/collector/collector_commits.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct KeyCommits(Count); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minbft` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option::Signature>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer_message_processor/usig_message_processor/checkpoint_processor.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) fn process_checkpoint(&mut self, checkpoint: Checkpoint) { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | if let Some(cert) = self [INFO] [stdout] | _____________________________^ [INFO] [stdout] 43 | | .collector_checkpoints [INFO] [stdout] 44 | | .retrieve_collected_checkpoints(&checkpoint, &self.config) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option::Signature>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer_message_processor/usig_message_processor/new_view_processor.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 73 | new_view: NewView, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let (last_cp, mut unique_preps) = Self::compute_new_view_state( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `output::Output` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/multi.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 118 | let (mut minbfts, _timeout_handlers) = setup_set(n, t, checkpoint_period); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let output = minbfts [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `KeyCommits` is never constructed [INFO] [stdout] --> src/peer_message_processor/collector/collector_commits.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct KeyCommits(Count); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `minbft` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "48f3f15afd9546731213783b30057519274f7563bd0584496a9a7aae56ab2df5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48f3f15afd9546731213783b30057519274f7563bd0584496a9a7aae56ab2df5", kill_on_drop: false }` [INFO] [stdout] 48f3f15afd9546731213783b30057519274f7563bd0584496a9a7aae56ab2df5