[INFO] fetching crate midly 0.5.3... [INFO] checking midly-0.5.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate midly 0.5.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate midly 0.5.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate midly 0.5.3 [INFO] finished tweaking crates.io crate midly 0.5.3 [INFO] tweaked toml for crates.io crate midly 0.5.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9c8a273ec1487bbb61639754b2395edd127b72067777da63c41e76b12b4ecb2 [INFO] running `Command { std: "docker" "start" "-a" "a9c8a273ec1487bbb61639754b2395edd127b72067777da63c41e76b12b4ecb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9c8a273ec1487bbb61639754b2395edd127b72067777da63c41e76b12b4ecb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9c8a273ec1487bbb61639754b2395edd127b72067777da63c41e76b12b4ecb2", kill_on_drop: false }` [INFO] [stdout] a9c8a273ec1487bbb61639754b2395edd127b72067777da63c41e76b12b4ecb2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b30e1ced1b15ad6aee7b8202c571f8a8c0b0565d6da61ab91ec001c1eb0b13d [INFO] running `Command { std: "docker" "start" "-a" "1b30e1ced1b15ad6aee7b8202c571f8a8c0b0565d6da61ab91ec001c1eb0b13d", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking midly v0.5.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/smf.rs:402:30 [INFO] [stdout] | [INFO] [stdout] 400 | impl<'a> ChunkIter<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 401 | #[inline] [INFO] [stdout] 402 | fn new(raw: &'a [u8]) -> ChunkIter { [INFO] [stdout] | ^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/smf.rs:402:30 [INFO] [stdout] | [INFO] [stdout] 400 | impl<'a> ChunkIter<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 401 | #[inline] [INFO] [stdout] 402 | fn new(raw: &'a [u8]) -> ChunkIter { [INFO] [stdout] | ^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 46 | fn event(&mut self, status: u8, mut handle_ev: impl FnMut(LiveEvent)) { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | if let Ok(ev) = LiveEvent::read(status, self.data.as_slice()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `midly` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 46 | fn event(&mut self, status: u8, mut handle_ev: impl FnMut(LiveEvent)) { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | if let Ok(ev) = LiveEvent::read(status, self.data.as_slice()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `error::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn len(_raw: &[u8], track: MidlyResult) -> usize { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Err(err) => panic!("failed to parse track: {}", err), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `error::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:532:17 [INFO] [stdout] | [INFO] [stdout] 529 | let result = parse_collect::Smf::parse(&file); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | Err(err) => match err.kind() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `header` is never read [INFO] [stdout] --> src/test.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 139 | pub struct Smf<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 140 | pub header: crate::Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `midly` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1b30e1ced1b15ad6aee7b8202c571f8a8c0b0565d6da61ab91ec001c1eb0b13d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b30e1ced1b15ad6aee7b8202c571f8a8c0b0565d6da61ab91ec001c1eb0b13d", kill_on_drop: false }` [INFO] [stdout] 1b30e1ced1b15ad6aee7b8202c571f8a8c0b0565d6da61ab91ec001c1eb0b13d