[INFO] fetching crate middleman 0.3.1... [INFO] checking middleman-0.3.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate middleman 0.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate middleman 0.3.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate middleman 0.3.1 [INFO] finished tweaking crates.io crate middleman 0.3.1 [INFO] tweaked toml for crates.io crate middleman 0.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding mio v0.6.23 (available: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (available: v0.6.0) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b2baf403d8a661d7b8146ce8c036b1af5413487dcfa9bc74b14abe9a71eba31 [INFO] running `Command { std: "docker" "start" "-a" "6b2baf403d8a661d7b8146ce8c036b1af5413487dcfa9bc74b14abe9a71eba31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b2baf403d8a661d7b8146ce8c036b1af5413487dcfa9bc74b14abe9a71eba31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b2baf403d8a661d7b8146ce8c036b1af5413487dcfa9bc74b14abe9a71eba31", kill_on_drop: false }` [INFO] [stdout] 6b2baf403d8a661d7b8146ce8c036b1af5413487dcfa9bc74b14abe9a71eba31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 699db48529da7c538a72d18e02410be493353c4699bc8697e2af810efd75bf53 [INFO] running `Command { std: "docker" "start" "-a" "699db48529da7c538a72d18e02410be493353c4699bc8697e2af810efd75bf53", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking middleman v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/structs.rs:313:18 [INFO] [stdout] | [INFO] [stdout] 313 | let mut vec = self.buf.drain(0..buf_end) [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/structs.rs:313:18 [INFO] [stdout] | [INFO] [stdout] 313 | let mut vec = self.buf.drain(0..buf_end) [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, errors::RecvError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:158:51 [INFO] [stdout] | [INFO] [stdout] 134 | let poll = Poll::new().unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let mut client = Middleman::new(x); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | if let Ok(Some(Msg::Hello)) = client.recv::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::Drain<'_, Msg>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:257:20 [INFO] [stdout] | [INFO] [stdout] 236 | let (mut a, b) = connected_pair(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let poll = Poll::new().unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | for msg in storage.drain(..) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tests.rs:532:41 [INFO] [stdout] | [INFO] [stdout] 532 | ... let mut stream = streams.get_mut(&token).unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` in tuple element 1 that must be used [INFO] [stdout] --> src/tests.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | TOK_A => { a.recv_all_map(&mut work); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` in tuple element 1 that must be used [INFO] [stdout] --> src/tests.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 227 | TOK_B => { b.recv_all_map(&mut work); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` in tuple element 1 that must be used [INFO] [stdout] --> src/tests.rs:344:13 [INFO] [stdout] | [INFO] [stdout] 344 | / a.recv_all_map::<_, Complex>(|_mm, msg| { [INFO] [stdout] 345 | | assert_eq!(&msg, &struct_form); [INFO] [stdout] 346 | | to_go -= 1; [INFO] [stdout] 347 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `middleman` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "699db48529da7c538a72d18e02410be493353c4699bc8697e2af810efd75bf53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "699db48529da7c538a72d18e02410be493353c4699bc8697e2af810efd75bf53", kill_on_drop: false }` [INFO] [stdout] 699db48529da7c538a72d18e02410be493353c4699bc8697e2af810efd75bf53