[INFO] fetching crate metriqs 0.1.6... [INFO] checking metriqs-0.1.6 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate metriqs 0.1.6 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate metriqs 0.1.6 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metriqs 0.1.6 [INFO] finished tweaking crates.io crate metriqs 0.1.6 [INFO] tweaked toml for crates.io crate metriqs 0.1.6 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (available: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding memchr v1.0.2 (available: v2.7.4) [INFO] [stderr] Adding nom v3.2.1 (available: v7.1.3) [INFO] [stderr] Adding phf_generator v0.7.24 (available: v0.11.2) [INFO] [stderr] Adding phf_shared v0.7.24 (available: v0.11.2) [INFO] [stderr] Adding rand v0.6.5 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (available: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (available: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (available: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (available: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding siphasher v0.2.3 (available: v1.0.1) [INFO] [stderr] Adding string_cache v0.7.5 (available: v0.8.7) [INFO] [stderr] Adding string_cache_codegen v0.4.4 (available: v0.5.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5982d77107d4deec4ed00eee77d9e6bc28899a12e8bc4cde598fc4a59176528b [INFO] running `Command { std: "docker" "start" "-a" "5982d77107d4deec4ed00eee77d9e6bc28899a12e8bc4cde598fc4a59176528b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5982d77107d4deec4ed00eee77d9e6bc28899a12e8bc4cde598fc4a59176528b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5982d77107d4deec4ed00eee77d9e6bc28899a12e8bc4cde598fc4a59176528b", kill_on_drop: false }` [INFO] [stdout] 5982d77107d4deec4ed00eee77d9e6bc28899a12e8bc4cde598fc4a59176528b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f791e3ae97deb9ddd897e80509ced9552475913f5beaa531e3f4c5cda6050af7 [INFO] running `Command { std: "docker" "start" "-a" "f791e3ae97deb9ddd897e80509ced9552475913f5beaa531e3f4c5cda6050af7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling string_cache_shared v0.3.0 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling string_cache_codegen v0.4.4 [INFO] [stderr] Compiling string_cache v0.7.5 [INFO] [stderr] Checking metriqs v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/recv/push/statsd/parse.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | named!(metric_name<&str>, [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 94 | | map_res!( [INFO] [stdout] 95 | | take_while!(call!(|c| { [INFO] [stdout] 96 | | is_alphanumeric(c) || c == b'.' || c == b'_' [INFO] [stdout] ... | [INFO] [stdout] 99 | | ) [INFO] [stdout] 100 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/recv/push/statsd/parse.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | named!(metric_name<&str>, [INFO] [stdout] | - ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 94 | | map_res!( [INFO] [stdout] 95 | | take_while!(call!(|c| { [INFO] [stdout] 96 | | is_alphanumeric(c) || c == b'.' || c == b'_' [INFO] [stdout] ... | [INFO] [stdout] 99 | | ) [INFO] [stdout] 100 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/recv/push/statsd/tcp.rs:37:38 [INFO] [stdout] | [INFO] [stdout] 37 | match parse_metrics(line.trim_right().as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 37 | match parse_metrics(line.trim_end().as_bytes()) { [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/recv/push/statsd/udp.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 50 | match parse_metrics(line.trim_right().as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 50 | match parse_metrics(line.trim_end().as_bytes()) { [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/recv/push/statsd/tcp.rs:37:38 [INFO] [stdout] | [INFO] [stdout] 37 | match parse_metrics(line.trim_right().as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 37 | match parse_metrics(line.trim_end().as_bytes()) { [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right`: superseded by `trim_end` [INFO] [stdout] --> src/recv/push/statsd/udp.rs:50:38 [INFO] [stdout] | [INFO] [stdout] 50 | match parse_metrics(line.trim_right().as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 50 | match parse_metrics(line.trim_end().as_bytes()) { [INFO] [stdout] | ~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recv/push/statsd/tcp.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 50 | fn accept_on_listener(listener: TcpListener, send: Sender) { [INFO] [stdout] | -------- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | for stream in listener.incoming() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recv/push/statsd/tcp.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 50 | fn accept_on_listener(listener: TcpListener, send: Sender) { [INFO] [stdout] | -------- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | for stream in listener.incoming() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metriqs` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metriqs` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f791e3ae97deb9ddd897e80509ced9552475913f5beaa531e3f4c5cda6050af7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f791e3ae97deb9ddd897e80509ced9552475913f5beaa531e3f4c5cda6050af7", kill_on_drop: false }` [INFO] [stdout] f791e3ae97deb9ddd897e80509ced9552475913f5beaa531e3f4c5cda6050af7