[INFO] fetching crate message-io 0.18.2... [INFO] checking message-io-0.18.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate message-io 0.18.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate message-io 0.18.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate message-io 0.18.2 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate message-io 0.18.2 [INFO] tweaked toml for crates.io crate message-io 0.18.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate message-io 0.18.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] edeea2e8fcb61fff818cc88c8aeeaf93db8f7d3d785e26049b16e48aada80bf8 [INFO] running `Command { std: "docker" "start" "-a" "edeea2e8fcb61fff818cc88c8aeeaf93db8f7d3d785e26049b16e48aada80bf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "edeea2e8fcb61fff818cc88c8aeeaf93db8f7d3d785e26049b16e48aada80bf8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edeea2e8fcb61fff818cc88c8aeeaf93db8f7d3d785e26049b16e48aada80bf8", kill_on_drop: false }` [INFO] [stdout] edeea2e8fcb61fff818cc88c8aeeaf93db8f7d3d785e26049b16e48aada80bf8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d16482585a7ef4d5d00cfd87b9ca4b9e7e2a6641be07bec468397fdeba74e15d [INFO] running `Command { std: "docker" "start" "-a" "d16482585a7ef4d5d00cfd87b9ca4b9e7e2a6641be07bec468397fdeba74e15d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling test-case v1.2.3 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking fern v0.6.2 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking message-io v0.18.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `MutexGuard<'_, RemoteState>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/adapters/ws.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 116 | fn receive(&self, mut process_data: impl FnMut(&[u8])) -> ReadStatus { [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let mut state = self.state.lock().expect(OTHER_THREAD_ERR); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/poll.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn process_event(&mut self, timeout: Option, mut event_callback: C) [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | match self.mio_poll.poll(&mut self.events, timeout) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `crossbeam_channel::Receiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events.rs:108:26 [INFO] [stdout] | [INFO] [stdout] 94 | / select! { [INFO] [stdout] 95 | | recv(self.receiver) -> event => event.unwrap(), [INFO] [stdout] 96 | | recv(self.priority_receiver) -> event => event.unwrap(), [INFO] [stdout] 97 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / select! { [INFO] [stdout] 106 | | recv(self.receiver) -> event => event.unwrap(), [INFO] [stdout] 107 | | recv(self.priority_receiver) -> event => event.unwrap(), [INFO] [stdout] 108 | | recv(crossbeam_channel::at(next_instant)) -> _ => { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 109 | | self.timers.remove(&next_instant).unwrap() [INFO] [stdout] 110 | | } [INFO] [stdout] 111 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `crossbeam_channel::Receiver` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/events.rs:140:26 [INFO] [stdout] | [INFO] [stdout] 125 | / select! { [INFO] [stdout] 126 | | recv(self.receiver) -> event => Some(event.unwrap()), [INFO] [stdout] 127 | | recv(self.priority_receiver) -> event => Some(event.unwrap()), [INFO] [stdout] 128 | | default(timeout) => None [INFO] [stdout] 129 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / select! { [INFO] [stdout] 138 | | recv(self.receiver) -> event => Some(event.unwrap()), [INFO] [stdout] 139 | | recv(self.priority_receiver) -> event => Some(event.unwrap()), [INFO] [stdout] 140 | | recv(crossbeam_channel::at(next_instant)) -> _ => { [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 143 | | default(timeout) => None [INFO] [stdout] 144 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `message-io` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d16482585a7ef4d5d00cfd87b9ca4b9e7e2a6641be07bec468397fdeba74e15d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d16482585a7ef4d5d00cfd87b9ca4b9e7e2a6641be07bec468397fdeba74e15d", kill_on_drop: false }` [INFO] [stdout] d16482585a7ef4d5d00cfd87b9ca4b9e7e2a6641be07bec468397fdeba74e15d