[INFO] fetching crate macrograph 0.0.0... [INFO] checking macrograph-0.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate macrograph 0.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate macrograph 0.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate macrograph 0.0.0 [INFO] finished tweaking crates.io crate macrograph 0.0.0 [INFO] tweaked toml for crates.io crate macrograph 0.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ecfb829bb9600a45154d59cf2bd4409c1559fb184cbe334999ab54a13c94ccee [INFO] running `Command { std: "docker" "start" "-a" "ecfb829bb9600a45154d59cf2bd4409c1559fb184cbe334999ab54a13c94ccee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ecfb829bb9600a45154d59cf2bd4409c1559fb184cbe334999ab54a13c94ccee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecfb829bb9600a45154d59cf2bd4409c1559fb184cbe334999ab54a13c94ccee", kill_on_drop: false }` [INFO] [stdout] ecfb829bb9600a45154d59cf2bd4409c1559fb184cbe334999ab54a13c94ccee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce3fcf50fbbfb7d618a6027431f63535fca70adcd1177de027bbc9d9ca49c993 [INFO] running `Command { std: "docker" "start" "-a" "ce3fcf50fbbfb7d618a6027431f63535fca70adcd1177de027bbc9d9ca49c993", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking macrograph v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/core.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/core.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 91 | CreateNode { package, schema } => { [INFO] [stdout] | ------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 94 | / ConnectIO { [INFO] [stdout] 95 | | output_node, [INFO] [stdout] 96 | | output, [INFO] [stdout] 97 | | input_node, [INFO] [stdout] 98 | | input, [INFO] [stdout] 99 | | } => { [INFO] [stdout] | |_____________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 102 | Event(event) => { [INFO] [stdout] | ------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 105 | Stop => { [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 108 | _ => {} [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/core.rs:215:25 [INFO] [stdout] | [INFO] [stdout] 212 | NodeSchema::Exec(_) | NodeSchema::Event(_) => { [INFO] [stdout] | ------------------------------------------ matches all the relevant values [INFO] [stdout] ... [INFO] [stdout] 215 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/core.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/core.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 91 | CreateNode { package, schema } => { [INFO] [stdout] | ------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 94 | / ConnectIO { [INFO] [stdout] 95 | | output_node, [INFO] [stdout] 96 | | output, [INFO] [stdout] 97 | | input_node, [INFO] [stdout] 98 | | input, [INFO] [stdout] 99 | | } => { [INFO] [stdout] | |_____________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 102 | Event(event) => { [INFO] [stdout] | ------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 105 | Stop => { [INFO] [stdout] | ---- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 108 | _ => {} [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/core.rs:215:25 [INFO] [stdout] | [INFO] [stdout] 212 | NodeSchema::Exec(_) | NodeSchema::Event(_) => { [INFO] [stdout] | ------------------------------------------ matches all the relevant values [INFO] [stdout] ... [INFO] [stdout] 215 | _ => {} [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:29:6 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn set_value(&self, value: Arc) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | *self.value.lock().unwrap() = value.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/core.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | self.connect_io(output_node, &output, input_node, &input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = self.connect_io(output_node, &output, input_node, &input); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/engine.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / self.event_channel.send(Request { [INFO] [stdout] 34 | | id: -1, [INFO] [stdout] 35 | | data: RequestData::Event(Event { [INFO] [stdout] 36 | | package: self.package.clone(), [INFO] [stdout] ... | [INFO] [stdout] 39 | | }), [INFO] [stdout] 40 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = self.event_channel.send(Request { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:29:6 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn set_value(&self, value: Arc) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | *self.value.lock().unwrap() = value.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `macrograph` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/core.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | self.connect_io(output_node, &output, input_node, &input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 100 | let _ = self.connect_io(output_node, &output, input_node, &input); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/engine.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / self.event_channel.send(Request { [INFO] [stdout] 34 | | id: -1, [INFO] [stdout] 35 | | data: RequestData::Event(Event { [INFO] [stdout] 36 | | package: self.package.clone(), [INFO] [stdout] ... | [INFO] [stdout] 39 | | }), [INFO] [stdout] 40 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = self.event_channel.send(Request { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `macrograph` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ce3fcf50fbbfb7d618a6027431f63535fca70adcd1177de027bbc9d9ca49c993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce3fcf50fbbfb7d618a6027431f63535fca70adcd1177de027bbc9d9ca49c993", kill_on_drop: false }` [INFO] [stdout] ce3fcf50fbbfb7d618a6027431f63535fca70adcd1177de027bbc9d9ca49c993