[INFO] fetching crate lynxlang 0.1.1... [INFO] checking lynxlang-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate lynxlang 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate lynxlang 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate lynxlang 0.1.1 [INFO] finished tweaking crates.io crate lynxlang 0.1.1 [INFO] tweaked toml for crates.io crate lynxlang 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2d1f0082386ef0ac87151d23dc25f8bb427d5e7d9ff4fb824904f3c5e743d9c [INFO] running `Command { std: "docker" "start" "-a" "b2d1f0082386ef0ac87151d23dc25f8bb427d5e7d9ff4fb824904f3c5e743d9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2d1f0082386ef0ac87151d23dc25f8bb427d5e7d9ff4fb824904f3c5e743d9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2d1f0082386ef0ac87151d23dc25f8bb427d5e7d9ff4fb824904f3c5e743d9c", kill_on_drop: false }` [INFO] [stdout] b2d1f0082386ef0ac87151d23dc25f8bb427d5e7d9ff4fb824904f3c5e743d9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06e15ba8029648ca7b232fd5da6fa9a365359b7f5e555b79a57866dfbb100f3a [INFO] running `Command { std: "docker" "start" "-a" "06e15ba8029648ca7b232fd5da6fa9a365359b7f5e555b79a57866dfbb100f3a", kill_on_drop: false }` [INFO] [stderr] Checking lynxlang v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:584:15 [INFO] [stdout] | [INFO] [stdout] 579 | fn parse_infix_expression(&mut self, left: Expression, token: &TokenType) -> Option { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | match self.parse_expression(cur_precedence) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parser.rs:550:42 [INFO] [stdout] | [INFO] [stdout] 550 | hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Expression` does not implement `Deref`, so calling `deref` on `&ast::Expression` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 550 - hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] 550 + hash_tuple.push((hash_key.clone(), hash_value.deref().clone())); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Expression`, implement `Clone` for it [INFO] [stdout] --> src/ast.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub enum Expression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parser.rs:550:70 [INFO] [stdout] | [INFO] [stdout] 550 | hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Expression` does not implement `Deref`, so calling `deref` on `&ast::Expression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 550 - hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] 550 + hash_tuple.push((hash_key.deref().clone(), hash_value.clone())); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Expression`, implement `Clone` for it [INFO] [stdout] --> src/ast.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub enum Expression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lynxlang` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `HashMap` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluator.rs:406:26 [INFO] [stdout] | [INFO] [stdout] 393 | let hash_value = get_eval_val( [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | Object::Hash(hashes) => { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:584:15 [INFO] [stdout] | [INFO] [stdout] 579 | fn parse_infix_expression(&mut self, left: Expression, token: &TokenType) -> Option { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | match self.parse_expression(cur_precedence) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parser.rs:550:42 [INFO] [stdout] | [INFO] [stdout] 550 | hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Expression` does not implement `Deref`, so calling `deref` on `&ast::Expression` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 550 - hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] 550 + hash_tuple.push((hash_key.clone(), hash_value.deref().clone())); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Expression`, implement `Clone` for it [INFO] [stdout] --> src/ast.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub enum Expression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/parser.rs:550:70 [INFO] [stdout] | [INFO] [stdout] 550 | hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ast::Expression` does not implement `Deref`, so calling `deref` on `&ast::Expression` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 550 - hash_tuple.push((hash_key.deref().clone(), hash_value.deref().clone())); [INFO] [stdout] 550 + hash_tuple.push((hash_key.deref().clone(), hash_value.clone())); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ast::Expression`, implement `Clone` for it [INFO] [stdout] --> src/ast.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 + #[derive(Clone)] [INFO] [stdout] 30 | pub enum Expression { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lynxlang` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "06e15ba8029648ca7b232fd5da6fa9a365359b7f5e555b79a57866dfbb100f3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06e15ba8029648ca7b232fd5da6fa9a365359b7f5e555b79a57866dfbb100f3a", kill_on_drop: false }` [INFO] [stdout] 06e15ba8029648ca7b232fd5da6fa9a365359b7f5e555b79a57866dfbb100f3a