[INFO] fetching crate lunar_rust 1.0.1... [INFO] checking lunar_rust-1.0.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate lunar_rust 1.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lunar_rust 1.0.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lunar_rust 1.0.1 [INFO] finished tweaking crates.io crate lunar_rust 1.0.1 [INFO] tweaked toml for crates.io crate lunar_rust 1.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding chrono-tz v0.8.6 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.2.1 (available: v0.4.0) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be65a0084d0d80b4149b4c377e030ab8f1bf932c8aa15b64251f399eb91b1bbf [INFO] running `Command { std: "docker" "start" "-a" "be65a0084d0d80b4149b4c377e030ab8f1bf932c8aa15b64251f399eb91b1bbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be65a0084d0d80b4149b4c377e030ab8f1bf932c8aa15b64251f399eb91b1bbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be65a0084d0d80b4149b4c377e030ab8f1bf932c8aa15b64251f399eb91b1bbf", kill_on_drop: false }` [INFO] [stdout] be65a0084d0d80b4149b4c377e030ab8f1bf932c8aa15b64251f399eb91b1bbf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff449bd7facdc413ddfb6724678813848c5f78a1570cc63ea327face428868ff [INFO] running `Command { std: "docker" "start" "-a" "ff449bd7facdc413ddfb6724678813848c5f78a1570cc63ea327face428868ff", kill_on_drop: false }` [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling chrono-tz-build v0.2.1 [INFO] [stderr] Compiling chrono-tz v0.8.6 [INFO] [stderr] Checking lunar_rust v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar/__lunar_ref_helper_defs.rs:126:46 [INFO] [stdout] | [INFO] [stdout] 67 | let mut filters = HashSet::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Some(JieQi::new(&name.unwrap().clone(), &near.unwrap().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, LunarYear>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar_year.rs:329:19 [INFO] [stdout] | [INFO] [stdout] 324 | fn get_position_fu(self, sect: Option) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | position_fu()[self.lock().unwrap().__gan_index as usize + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, LunarYear>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar_year.rs:341:20 [INFO] [stdout] | [INFO] [stdout] 340 | fn get_position_cai(self) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | POSITION_CAI()[self.lock().unwrap().__gan_index as usize + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, LunarYear>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar_year.rs:353:29 [INFO] [stdout] | [INFO] [stdout] 352 | fn get_position_tai_sui(self) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | POSITION_TAI_SUI_YEAR()[self.lock().unwrap().__zhi_index as usize] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/solar/helper_traits.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 68 | fn get_week_in_chinese(self) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | solar_util::get().WEEK()[self.get_week() as usize].to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/solar/helper_traits.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 359 | fn subtract(&self, solar: Self) -> i64 { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | solar_util::get().get_days_between( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, HashMap>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/solar_season.rs:133:7 [INFO] [stdout] | [INFO] [stdout] 110 | let found = { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Self::__CACHE().lock().unwrap().get(&key).unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar/__lunar_ref_helper_defs.rs:126:46 [INFO] [stdout] | [INFO] [stdout] 67 | let mut filters = HashSet::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Some(JieQi::new(&name.unwrap().clone(), &near.unwrap().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lunar_rust` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `MutexGuard<'_, LunarYear>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar_year.rs:329:19 [INFO] [stdout] | [INFO] [stdout] 324 | fn get_position_fu(self, sect: Option) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | position_fu()[self.lock().unwrap().__gan_index as usize + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, LunarYear>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar_year.rs:341:20 [INFO] [stdout] | [INFO] [stdout] 340 | fn get_position_cai(self) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | POSITION_CAI()[self.lock().unwrap().__gan_index as usize + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, LunarYear>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/lunar_year.rs:353:29 [INFO] [stdout] | [INFO] [stdout] 352 | fn get_position_tai_sui(self) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 353 | POSITION_TAI_SUI_YEAR()[self.lock().unwrap().__zhi_index as usize] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/solar/helper_traits.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 68 | fn get_week_in_chinese(self) -> String { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | solar_util::get().WEEK()[self.get_week() as usize].to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/solar/helper_traits.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 359 | fn subtract(&self, solar: Self) -> i64 { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 360 | solar_util::get().get_days_between( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, HashMap>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/solar_season.rs:133:7 [INFO] [stdout] | [INFO] [stdout] 110 | let found = { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Self::__CACHE().lock().unwrap().get(&key).unwrap().clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/../tests/lunar_test.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 156 | let solar = solar::from_ymdhms(2020, 1, 10, 12, 0, 0); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let lunar = solar.get_lunar(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | for i in -1..1 { [INFO] [stdout] 159 | assert_eq!(solar.next(i, None).get_lunar().to_full_string(), lunar.next(i).to_full_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lunar_rust` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "ff449bd7facdc413ddfb6724678813848c5f78a1570cc63ea327face428868ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff449bd7facdc413ddfb6724678813848c5f78a1570cc63ea327face428868ff", kill_on_drop: false }` [INFO] [stdout] ff449bd7facdc413ddfb6724678813848c5f78a1570cc63ea327face428868ff