[INFO] fetching crate lumberjack 0.3.1... [INFO] checking lumberjack-0.3.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate lumberjack 0.3.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate lumberjack 0.3.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lumberjack 0.3.1 [INFO] finished tweaking crates.io crate lumberjack 0.3.1 [INFO] tweaked toml for crates.io crate lumberjack 0.3.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding conllx v0.11.2 (available: v0.12.1) [INFO] [stderr] Adding fixedbitset v0.1.9 (available: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding itertools v0.7.11 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.8.2 (available: v0.13.0) [INFO] [stderr] Adding lazy-init v0.3.0 (available: v0.5.1) [INFO] [stderr] Adding ordermap v0.3.5 (available: v0.5.3) [INFO] [stderr] Adding petgraph v0.4.13 (available: v0.6.5) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1efaed9c008cd3769abc62c43c822d5be47241d24b4b6226c4222977dfd58354 [INFO] running `Command { std: "docker" "start" "-a" "1efaed9c008cd3769abc62c43c822d5be47241d24b4b6226c4222977dfd58354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1efaed9c008cd3769abc62c43c822d5be47241d24b4b6226c4222977dfd58354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1efaed9c008cd3769abc62c43c822d5be47241d24b4b6226c4222977dfd58354", kill_on_drop: false }` [INFO] [stdout] 1efaed9c008cd3769abc62c43c822d5be47241d24b4b6226c4222977dfd58354 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43d615dd98f53463537f05d8cd2a93ddced1512ec1808bb211af64a04bc3ed62 [INFO] running `Command { std: "docker" "start" "-a" "43d615dd98f53463537f05d8cd2a93ddced1512ec1808bb211af64a04bc3ed62", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking lazy-init v0.3.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking conllx v0.11.2 [INFO] [stderr] Compiling pest v2.7.13 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Checking lumberjack v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/io/ptb.rs:321:48 [INFO] [stdout] | [INFO] [stdout] 321 | buffer.push_str(line.as_str());; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/io/ptb.rs:321:48 [INFO] [stdout] | [INFO] [stdout] 321 | buffer.push_str(line.as_str());; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/tree.rs:352:14 [INFO] [stdout] | [INFO] [stdout] 352 | ) -> Box + 'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 352 | ) -> Box + 'a> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/tree.rs:352:14 [INFO] [stdout] | [INFO] [stdout] 352 | ) -> Box + 'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 352 | ) -> Box + 'a> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `NegraReader>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/mod.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 45 | let mut ptb_reader = BufReader::new(ptb_input).lines(); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | for tree in negra_reader { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lumberjack` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "43d615dd98f53463537f05d8cd2a93ddced1512ec1808bb211af64a04bc3ed62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43d615dd98f53463537f05d8cd2a93ddced1512ec1808bb211af64a04bc3ed62", kill_on_drop: false }` [INFO] [stdout] 43d615dd98f53463537f05d8cd2a93ddced1512ec1808bb211af64a04bc3ed62