[INFO] fetching crate lsm-tree 2.0.0... [INFO] checking lsm-tree-2.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate lsm-tree 2.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate lsm-tree 2.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lsm-tree 2.0.0 [INFO] finished tweaking crates.io crate lsm-tree 2.0.0 [INFO] tweaked toml for crates.io crate lsm-tree 2.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 134 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e494b29162148ac1b4c463ee7130ac7f8d94825317345c434463c7392f0b6b2d [INFO] running `Command { std: "docker" "start" "-a" "e494b29162148ac1b4c463ee7130ac7f8d94825317345c434463c7392f0b6b2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e494b29162148ac1b4c463ee7130ac7f8d94825317345c434463c7392f0b6b2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e494b29162148ac1b4c463ee7130ac7f8d94825317345c434463c7392f0b6b2d", kill_on_drop: false }` [INFO] [stdout] e494b29162148ac1b4c463ee7130ac7f8d94825317345c434463c7392f0b6b2d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4c05aa84a66e4db9d529b0ac93d0430360d2314e0dea22fe3c6d3ef8b8c4388 [INFO] running `Command { std: "docker" "start" "-a" "a4c05aa84a66e4db9d529b0ac93d0430360d2314e0dea22fe3c6d3ef8b8c4388", kill_on_drop: false }` [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking min-max-heap v1.3.0 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking varint-rs v2.2.0 [INFO] [stderr] Checking double-ended-peekable v0.1.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking guardian v1.2.0 [INFO] [stderr] Checking quick_cache v0.6.9 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking value-log v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking lsm-tree v2.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/memtable/mod.rs:67:59 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) fn range<'a, R: RangeBounds + 'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 67 | ) -> impl DoubleEndedIterator + '_ { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] error: this value of type `Slice` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/blob_tree/mod.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 30 | fn resolve_value_handle(vlog: &ValueLog, item: RangeItem) -> RangeItem { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | match item { [INFO] [stdout] 32 | Ok((key, value)) => { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking nanoid v0.4.0 [INFO] [stdout] error: this value of type `MvccStream, InternalKey, Slice>, {closure@src/memtable/mod.rs:102:25: 102:32}>, {closure@src/memtable/mod.rs:106:25: 106:37}>, fn(InternalValue) -> std::result::Result {std::result::Result::::Ok}>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memtable/mod.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get>(&self, key: K, seqno: Option) -> Option { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | MvccStream::new(iter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/reader.rs:178:26 [INFO] [stdout] | [INFO] [stdout] 178 | match fail_iter!(self.load_data_block(next_block_offset)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / match $e { [INFO] [stdout] 109 | | Ok(v) => v, [INFO] [stdout] 110 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 111 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/reader.rs:239:30 [INFO] [stdout] | [INFO] [stdout] 239 | match fail_iter!(self.load_data_block(prev_block_offset)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | / match $e { [INFO] [stdout] 109 | | Ok(v) => v, [INFO] [stdout] 110 | | Err(e) => return Some(Err(e)), [INFO] [stdout] 111 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MvccStream>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment/mod.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 242 | key: K, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | let Some(first_block_handle) = self [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | MvccStream::new(iter).next().transpose() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsm-tree` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a4c05aa84a66e4db9d529b0ac93d0430360d2314e0dea22fe3c6d3ef8b8c4388", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4c05aa84a66e4db9d529b0ac93d0430360d2314e0dea22fe3c6d3ef8b8c4388", kill_on_drop: false }` [INFO] [stdout] a4c05aa84a66e4db9d529b0ac93d0430360d2314e0dea22fe3c6d3ef8b8c4388