[INFO] fetching crate lox-lang 0.0.3... [INFO] checking lox-lang-0.0.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate lox-lang 0.0.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate lox-lang 0.0.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lox-lang 0.0.3 [INFO] finished tweaking crates.io crate lox-lang 0.0.3 [INFO] tweaked toml for crates.io crate lox-lang 0.0.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate lox-lang 0.0.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 592aa93f403c887898f692fb5479d94670fe003c618fa5365fd675ea440800f7 [INFO] running `Command { std: "docker" "start" "-a" "592aa93f403c887898f692fb5479d94670fe003c618fa5365fd675ea440800f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "592aa93f403c887898f692fb5479d94670fe003c618fa5365fd675ea440800f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "592aa93f403c887898f692fb5479d94670fe003c618fa5365fd675ea440800f7", kill_on_drop: false }` [INFO] [stdout] 592aa93f403c887898f692fb5479d94670fe003c618fa5365fd675ea440800f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ca245f26acda5d9de00e54bb07f0f33cc498465078297256160d194ae6e974dc [INFO] running `Command { std: "docker" "start" "-a" "ca245f26acda5d9de00e54bb07f0f33cc498465078297256160d194ae6e974dc", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling syn v1.0.19 [INFO] [stderr] Compiling cc v1.0.52 [INFO] [stderr] Compiling fs_extra v1.1.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking os_str_bytes v2.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Compiling jemalloc-sys v0.3.2 [INFO] [stderr] Compiling quote v1.0.4 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking term v0.6.1 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking simplelog v0.7.6 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.1 [INFO] [stderr] Checking clap v3.0.0-beta.1 [INFO] [stderr] Checking jemallocator v0.3.2 [INFO] [stderr] Checking lox-lang v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/mod.rs:453:38 [INFO] [stdout] | [INFO] [stdout] 395 | let fun_name = match self.parser.previous { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | if let Some(enclosing_fun) = self.fun.enclosing.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler/mod.rs:453:38 [INFO] [stdout] | [INFO] [stdout] 395 | let fun_name = match self.parser.previous { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | if let Some(enclosing_fun) = self.fun.enclosing.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/run.rs:485:15 [INFO] [stdout] | [INFO] [stdout] 483 | let value = self.stack.pop().ok_or(RuntimeError::StackEmpty)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | [INFO] [stdout] 485 | match self.stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/compiler/wrapper.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 100 | pub(super) struct ClassWrapper { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 101 | pub(super) enclosing: Option>, [INFO] [stdout] 102 | pub(super) name: Box, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ClassWrapper` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `CallStackOverflow` and `ValueStackOverflow` are never constructed [INFO] [stdout] --> src/vm/errors.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum RuntimeError { [INFO] [stdout] | ------------ variants in this enum [INFO] [stdout] ... [INFO] [stdout] 11 | CallStackOverflow, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | ValueStackOverflow, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RuntimeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/compiler/mod.rs:893:22 [INFO] [stdout] | [INFO] [stdout] 893 | (&**text).clone() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lox_core/obj.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | Box::from_raw(self.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 64 | let _ = Box::from_raw(self.0); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm/run.rs:485:15 [INFO] [stdout] | [INFO] [stdout] 483 | let value = self.stack.pop().ok_or(RuntimeError::StackEmpty)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 484 | [INFO] [stdout] 485 | match self.stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/compiler/wrapper.rs:102:16 [INFO] [stdout] | [INFO] [stdout] 100 | pub(super) struct ClassWrapper { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 101 | pub(super) enclosing: Option>, [INFO] [stdout] 102 | pub(super) name: Box, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ClassWrapper` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox-lang` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] [stdout] warning: variants `CallStackOverflow` and `ValueStackOverflow` are never constructed [INFO] [stdout] --> src/vm/errors.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum RuntimeError { [INFO] [stdout] | ------------ variants in this enum [INFO] [stdout] ... [INFO] [stdout] 11 | CallStackOverflow, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | ValueStackOverflow, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RuntimeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/compiler/mod.rs:893:22 [INFO] [stdout] | [INFO] [stdout] 893 | (&**text).clone() [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lox_core/obj.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | Box::from_raw(self.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 64 | let _ = Box::from_raw(self.0); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox-lang` (lib) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ca245f26acda5d9de00e54bb07f0f33cc498465078297256160d194ae6e974dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca245f26acda5d9de00e54bb07f0f33cc498465078297256160d194ae6e974dc", kill_on_drop: false }` [INFO] [stdout] ca245f26acda5d9de00e54bb07f0f33cc498465078297256160d194ae6e974dc