[INFO] fetching crate liquid-ml 0.1.0... [INFO] checking liquid-ml-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate liquid-ml 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate liquid-ml 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate liquid-ml 0.1.0 [INFO] finished tweaking crates.io crate liquid-ml 0.1.0 [INFO] tweaked toml for crates.io crate liquid-ml 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate liquid-ml 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6397bfba125015aa6c8de0b1ec549f079ef0332c938e7763ffdd7a29ce5ac53a [INFO] running `Command { std: "docker" "start" "-a" "6397bfba125015aa6c8de0b1ec549f079ef0332c938e7763ffdd7a29ce5ac53a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6397bfba125015aa6c8de0b1ec549f079ef0332c938e7763ffdd7a29ce5ac53a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6397bfba125015aa6c8de0b1ec549f079ef0332c938e7763ffdd7a29ce5ac53a", kill_on_drop: false }` [INFO] [stdout] 6397bfba125015aa6c8de0b1ec549f079ef0332c938e7763ffdd7a29ce5ac53a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14e05bbd769d41c2c5561216d4b83ebea72a8e5a6bd125186bbfc7ee32f71440 [INFO] running `Command { std: "docker" "start" "-a" "14e05bbd769d41c2c5561216d4b83ebea72a8e5a6bd125186bbfc7ee32f71440", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling hashbrown v0.6.3 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking lexical-core v0.7.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling sysinfo v0.12.0 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Compiling const-random-macro v0.1.13 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking bytecount v0.6.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking const-random v0.1.13 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking radium v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ahash v0.2.19 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking easy_reader v0.5.2 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking lru v0.4.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking simple_logger v1.16.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling deepsize_derive v0.1.2 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Checking deepsize v0.1.2 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking futures-util v0.3.21 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking sorer v0.1.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking bitvec v0.17.4 [INFO] [stderr] Checking liquid-ml v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking csv v1.1.6 [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataframe/distributed_dataframe.rs:157:14 [INFO] [stdout] | [INFO] [stdout] 148 | iter: Option>>, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | kv: Arc>, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let (blob_sender, blob_receiver) = mpsc::channel(2); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::MutexGuard<'_, LruCache>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv/kv_store.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 439 | value: Arc, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let mut unlocked = self.cache.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FramedWrite, MessageCodec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:245:17 [INFO] [stdout] | [INFO] [stdout] 207 | parent: Arc>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let mut sink = [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataframe/distributed_dataframe.rs:517:13 [INFO] [stdout] | [INFO] [stdout] 513 | mut rower: T, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | let _kill_notifier = Arc::new(Notify::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataframe/distributed_dataframe.rs:157:14 [INFO] [stdout] | [INFO] [stdout] 148 | iter: Option>>, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | kv: Arc>, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let (blob_sender, blob_receiver) = mpsc::channel(2); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::MutexGuard<'_, LruCache>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kv/kv_store.rs:446:17 [INFO] [stdout] | [INFO] [stdout] 439 | value: Arc, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | let mut unlocked = self.cache.lock().await; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FramedWrite, MessageCodec>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:245:17 [INFO] [stdout] | [INFO] [stdout] 207 | parent: Arc>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let mut sink = [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `liquid-ml` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dataframe/distributed_dataframe.rs:517:13 [INFO] [stdout] | [INFO] [stdout] 513 | mut rower: T, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | let _kill_notifier = Arc::new(Notify::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `start_idx` is never read [INFO] [stdout] --> src/dataframe/row.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 147 | struct TestFielder { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 153 | pub start_idx: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `liquid-ml` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "14e05bbd769d41c2c5561216d4b83ebea72a8e5a6bd125186bbfc7ee32f71440", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14e05bbd769d41c2c5561216d4b83ebea72a8e5a6bd125186bbfc7ee32f71440", kill_on_drop: false }` [INFO] [stdout] 14e05bbd769d41c2c5561216d4b83ebea72a8e5a6bd125186bbfc7ee32f71440