[INFO] fetching crate libdoh 0.9.11... [INFO] checking libdoh-0.9.11 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate libdoh 0.9.11 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate libdoh 0.9.11 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libdoh 0.9.11 [INFO] finished tweaking crates.io crate libdoh 0.9.11 [INFO] tweaked toml for crates.io crate libdoh 0.9.11 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding h2 v0.3.26 (available: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding hpke v0.11.0 (available: v0.12.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding rustls v0.21.12 (available: v0.23.13) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (available: v0.102.8) [INFO] [stderr] Adding tokio-rustls v0.24.1 (available: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6842ea60b73e5c26d46b60d07ee97e1c564927edf142f450eb4f0a6f9596bbd3 [INFO] running `Command { std: "docker" "start" "-a" "6842ea60b73e5c26d46b60d07ee97e1c564927edf142f450eb4f0a6f9596bbd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6842ea60b73e5c26d46b60d07ee97e1c564927edf142f450eb4f0a6f9596bbd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6842ea60b73e5c26d46b60d07ee97e1c564927edf142f450eb4f0a6f9596bbd3", kill_on_drop: false }` [INFO] [stdout] 6842ea60b73e5c26d46b60d07ee97e1c564927edf142f450eb4f0a6f9596bbd3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72f50d6adbe23456f349d7c4546e4ea69f09ce67b741d89bcba7413d12a6af79 [INFO] running `Command { std: "docker" "start" "-a" "72f50d6adbe23456f349d7c4546e4ea69f09ce67b741d89bcba7413d12a6af79", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking hpke v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking odoh-rs v1.0.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking libdoh v0.9.11 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | let (tls_acceptor_sender, tls_acceptor_receiver) = mpsc::channel(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | join!(https_service, cert_service).0 [INFO] [stdout] | ---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | let (tls_acceptor_sender, tls_acceptor_receiver) = mpsc::channel(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | join!(https_service, cert_service).0 [INFO] [stdout] | ---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 53 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let odoh_query = ObliviousDoHMessage::deserialize(&mut bytes::Bytes::from(encrypted_query)) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok((query.into_msg().to_vec(), context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Guard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 129 | let key = Arc::clone(&self.key); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Arc::clone(&key.load()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 53 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let odoh_query = ObliviousDoHMessage::deserialize(&mut bytes::Bytes::from(encrypted_query)) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok((query.into_msg().to_vec(), context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Guard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 129 | let key = Arc::clone(&self.key); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Arc::clone(&key.load()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libdoh` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libdoh` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "72f50d6adbe23456f349d7c4546e4ea69f09ce67b741d89bcba7413d12a6af79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72f50d6adbe23456f349d7c4546e4ea69f09ce67b741d89bcba7413d12a6af79", kill_on_drop: false }` [INFO] [stdout] 72f50d6adbe23456f349d7c4546e4ea69f09ce67b741d89bcba7413d12a6af79