[INFO] fetching crate libcnb 0.23.0... [INFO] checking libcnb-0.23.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate libcnb 0.23.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate libcnb 0.23.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libcnb 0.23.0 [INFO] finished tweaking crates.io crate libcnb 0.23.0 [INFO] tweaked toml for crates.io crate libcnb 0.23.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 126 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding fluent-uri v0.1.4 (available: v0.2.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding opentelemetry v0.21.0 (available: v0.25.0) [INFO] [stderr] Adding opentelemetry-stdout v0.2.0 (available: v0.25.0) [INFO] [stderr] Adding opentelemetry_sdk v0.21.2 (available: v0.25.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8f4ec5759e9a36c6db75f873cfe6e2375f1bccc4825d331e93e659bde480afd [INFO] running `Command { std: "docker" "start" "-a" "c8f4ec5759e9a36c6db75f873cfe6e2375f1bccc4825d331e93e659bde480afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8f4ec5759e9a36c6db75f873cfe6e2375f1bccc4825d331e93e659bde480afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8f4ec5759e9a36c6db75f873cfe6e2375f1bccc4825d331e93e659bde480afd", kill_on_drop: false }` [INFO] [stdout] c8f4ec5759e9a36c6db75f873cfe6e2375f1bccc4825d331e93e659bde480afd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c99eca9023a36fda437386041fde35b9304c58d45acbe2be3346ad3ad2e3565c [INFO] running `Command { std: "docker" "start" "-a" "c99eca9023a36fda437386041fde35b9304c58d45acbe2be3346ad3ad2e3565c", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking winnow v0.6.20 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking uriparse v0.6.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.22.22 [INFO] [stderr] Compiling cargo-platform v0.1.8 [INFO] [stderr] Compiling cargo_metadata v0.18.1 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking libcnb-common v0.23.0 [INFO] [stderr] Compiling libcnb-proc-macros v0.23.0 [INFO] [stderr] Checking libcnb-data v0.23.0 [INFO] [stderr] Checking libcnb v0.23.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `LayerContentMetadata` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:138:10 [INFO] [stdout] | [INFO] [stdout] 129 | layers_dir: P, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | &LayerContentMetadata { [INFO] [stdout] | __________^ [INFO] [stdout] 139 | | types: content_metadata.types, [INFO] [stdout] 140 | | metadata, [INFO] [stdout] 141 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result::Metadata>>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/trait_api/handling.rs:28:11 [INFO] [stdout] | [INFO] [stdout] 26 | mut layer: L, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result, LayerErrorOrBuildpackError> { [INFO] [stdout] 28 | match read_layer(&context.layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/runtime.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | let mut trace_error = |_: &dyn std::error::Error| {}; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/runtime.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | let mut trace_error = |_: &dyn std::error::Error| {}; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libcnb` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `LayerContentMetadata` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:138:10 [INFO] [stdout] | [INFO] [stdout] 129 | layers_dir: P, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | &LayerContentMetadata { [INFO] [stdout] | __________^ [INFO] [stdout] 139 | | types: content_metadata.types, [INFO] [stdout] 140 | | metadata, [INFO] [stdout] 141 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>>>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:364:15 [INFO] [stdout] | [INFO] [stdout] 348 | let temp_dir = tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | match super::read_layer::(layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:400:15 [INFO] [stdout] | [INFO] [stdout] 381 | let temp_dir = tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | match super::read_layer::(layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>>>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:417:15 [INFO] [stdout] | [INFO] [stdout] 411 | let temp_dir = tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | match super::read_layer::(layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>>>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:439:15 [INFO] [stdout] | [INFO] [stdout] 434 | let temp_dir = tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 439 | match super::read_layer::(layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>>>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/shared.rs:451:15 [INFO] [stdout] | [INFO] [stdout] 448 | let temp_dir = tempdir().unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | match super::read_layer::(layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result::Metadata>>, ReadLayerError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/layer/trait_api/handling.rs:28:11 [INFO] [stdout] | [INFO] [stdout] 26 | mut layer: L, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Result, LayerErrorOrBuildpackError> { [INFO] [stdout] 28 | match read_layer(&context.layers_dir, &layer_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/runtime.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | let mut trace_error = |_: &dyn std::error::Error| {}; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/runtime.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | let mut trace_error = |_: &dyn std::error::Error| {}; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libcnb` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c99eca9023a36fda437386041fde35b9304c58d45acbe2be3346ad3ad2e3565c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c99eca9023a36fda437386041fde35b9304c58d45acbe2be3346ad3ad2e3565c", kill_on_drop: false }` [INFO] [stdout] c99eca9023a36fda437386041fde35b9304c58d45acbe2be3346ad3ad2e3565c