[INFO] fetching crate libblobd-kv 0.7.2... [INFO] checking libblobd-kv-0.7.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate libblobd-kv 0.7.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate libblobd-kv 0.7.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libblobd-kv 0.7.2 [INFO] finished tweaking crates.io crate libblobd-kv 0.7.2 [INFO] tweaked toml for crates.io crate libblobd-kv 0.7.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 139 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding strum v0.24.1 (available: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (available: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b6f2e19c1b5468bf1f67927911daedc2cc876f8d9af1fefd22b465d4929a4b1 [INFO] running `Command { std: "docker" "start" "-a" "4b6f2e19c1b5468bf1f67927911daedc2cc876f8d9af1fefd22b465d4929a4b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b6f2e19c1b5468bf1f67927911daedc2cc876f8d9af1fefd22b465d4929a4b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b6f2e19c1b5468bf1f67927911daedc2cc876f8d9af1fefd22b465d4929a4b1", kill_on_drop: false }` [INFO] [stdout] 4b6f2e19c1b5468bf1f67927911daedc2cc876f8d9af1fefd22b465d4929a4b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b0b4b07022a7cbbf4c448a7e24f26c0050a9b2d834a24d42db8aeba671b6043 [INFO] running `Command { std: "docker" "start" "-a" "0b0b4b07022a7cbbf4c448a7e24f26c0050a9b2d834a24d42db8aeba671b6043", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling io-uring v0.6.4 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling struct-name v0.0.1 [INFO] [stderr] Compiling struct-name-macro v0.0.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking roaring v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking signal-future v0.1.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking bufpool v0.2.4 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking stochastic-queue v0.2.0 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Checking off64 v0.6.0 [INFO] [stderr] Checking tinybuf v0.3.0 [INFO] [stderr] Checking libblobd-kv v0.7.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::sync::Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 178 | pub async fn load_and_start(self) -> Blobd { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let heap_allocator = Arc::new(Mutex::new(Allocator::new( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 195 | let (_, log_buffer) = join! { [INFO] [stdout] | ___________________________- [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] 196 | | load_tuples_from_device( [INFO] [stdout] 197 | | &self.dev, [INFO] [stdout] 198 | | &self.pages, [INFO] [stdout] ... | [INFO] [stdout] 221 | | ), [INFO] [stdout] 222 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_buffer.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 160 | dev: Arc, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | bundles_dev: BoundedStore, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | data_dev: BoundedStore, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | state_dev: BoundedStore, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | heap_allocator: Arc>, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | pages: Pages, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | metrics: BlobdMetrics, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let currently_committing = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 178 | pub async fn load_and_start(self) -> Blobd { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let heap_allocator = Arc::new(Mutex::new(Allocator::new( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 195 | let (_, log_buffer) = join! { [INFO] [stdout] | ___________________________- [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] | |___________________________| [INFO] [stdout] 196 | | load_tuples_from_device( [INFO] [stdout] 197 | | &self.dev, [INFO] [stdout] 198 | | &self.pages, [INFO] [stdout] ... | [INFO] [stdout] 221 | | ), [INFO] [stdout] 222 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_buffer.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 160 | dev: Arc, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | bundles_dev: BoundedStore, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | data_dev: BoundedStore, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | state_dev: BoundedStore, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | heap_allocator: Arc>, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | pages: Pages, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | metrics: BlobdMetrics, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let currently_committing = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Buf` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_buffer.rs:657:17 [INFO] [stdout] | [INFO] [stdout] 596 | let mut pending_log_flush = Vec::new(); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 657 | let mut buf_padded = [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Buf` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_buffer.rs:657:17 [INFO] [stdout] | [INFO] [stdout] 596 | let mut pending_log_flush = Vec::new(); [INFO] [stdout] | --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 657 | let mut buf_padded = [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `uring::Request` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/uring.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 202 | let mut completion = unsafe { ring.completion_shared() }; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let (req, started) = pending.remove(&id).unwrap().1; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libblobd-kv` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `uring::Request` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/uring.rs:212:16 [INFO] [stdout] | [INFO] [stdout] 202 | let mut completion = unsafe { ring.completion_shared() }; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let (req, started) = pending.remove(&id).unwrap().1; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libblobd-kv` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "0b0b4b07022a7cbbf4c448a7e24f26c0050a9b2d834a24d42db8aeba671b6043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b0b4b07022a7cbbf4c448a7e24f26c0050a9b2d834a24d42db8aeba671b6043", kill_on_drop: false }` [INFO] [stdout] 0b0b4b07022a7cbbf4c448a7e24f26c0050a9b2d834a24d42db8aeba671b6043