[INFO] fetching crate letmeinfwd 5.0.0... [INFO] checking letmeinfwd-5.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate letmeinfwd 5.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate letmeinfwd 5.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate letmeinfwd 5.0.0 [INFO] finished tweaking crates.io crate letmeinfwd 5.0.0 [INFO] tweaked toml for crates.io crate letmeinfwd 5.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate letmeinfwd 5.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e72f22b295713a12811326f5eb84df8aec8d2809b72067ab8b96566cf893636 [INFO] running `Command { std: "docker" "start" "-a" "4e72f22b295713a12811326f5eb84df8aec8d2809b72067ab8b96566cf893636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e72f22b295713a12811326f5eb84df8aec8d2809b72067ab8b96566cf893636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e72f22b295713a12811326f5eb84df8aec8d2809b72067ab8b96566cf893636", kill_on_drop: false }` [INFO] [stdout] 4e72f22b295713a12811326f5eb84df8aec8d2809b72067ab8b96566cf893636 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52b3036d9256eb3cd09e50a90a7b6bc7393215382ddb3b78fb07b28dab7e1af1 [INFO] running `Command { std: "docker" "start" "-a" "52b3036d9256eb3cd09e50a90a7b6bc7393215382ddb3b78fb07b28dab7e1af1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking sd-notify v0.4.2 [INFO] [stderr] Checking user_lookup v0.3.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking letmein-systemd v5.0.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking letmein-proto v5.0.0 [INFO] [stderr] Checking letmein-fwproto v5.0.0 [INFO] [stderr] Checking letmein-conf v5.0.0 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking nftables v0.4.1 [INFO] [stderr] Checking letmeinfwd v5.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 163 | async fn async_main(opts: Arc) -> ah::Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let conf = Arc::new(RwLock::new(conf)); [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | / tokio::select! { [INFO] [stdout] 234 | | _ = sigterm.recv() => { [INFO] [stdout] 235 | | eprintln!("SIGTERM: Terminating."); [INFO] [stdout] 236 | | exitcode = Ok(()); [INFO] [stdout] ... | [INFO] [stdout] 262 | | } [INFO] [stdout] 263 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 163 | async fn async_main(opts: Arc) -> ah::Result<()> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let conf = Arc::new(RwLock::new(conf)); [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | / tokio::select! { [INFO] [stdout] 234 | | _ = sigterm.recv() => { [INFO] [stdout] 235 | | eprintln!("SIGTERM: Terminating."); [INFO] [stdout] 236 | | exitcode = Ok(()); [INFO] [stdout] ... | [INFO] [stdout] 262 | | } [INFO] [stdout] 263 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:201:45 [INFO] [stdout] | [INFO] [stdout] 200 | ... let conf = conf.read().await; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | ... if let Err(e) = conn.handle_message(&conf, fw).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:201:45 [INFO] [stdout] | [INFO] [stdout] 200 | ... let conf = conf.read().await; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | ... if let Err(e) = conn.handle_message(&conf, fw).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::runtime::Runtime` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 283 | let opts = Arc::new(Opts::parse()); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | / runtime::Builder::new_current_thread() [INFO] [stdout] 285 | | .thread_keep_alive(Duration::from_millis(0)) [INFO] [stdout] 286 | | .max_blocking_threads(1) [INFO] [stdout] 287 | | .enable_all() [INFO] [stdout] 288 | | .build() [INFO] [stdout] 289 | | .context("Tokio runtime builder")? [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `letmeinfwd` (bin "letmeinfwd" test) due to 4 previous errors [INFO] [stdout] error: this value of type `tokio::runtime::Runtime` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 283 | let opts = Arc::new(Opts::parse()); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | / runtime::Builder::new_current_thread() [INFO] [stdout] 285 | | .thread_keep_alive(Duration::from_millis(0)) [INFO] [stdout] 286 | | .max_blocking_threads(1) [INFO] [stdout] 287 | | .enable_all() [INFO] [stdout] 288 | | .build() [INFO] [stdout] 289 | | .context("Tokio runtime builder")? [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `letmeinfwd` (bin "letmeinfwd") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "52b3036d9256eb3cd09e50a90a7b6bc7393215382ddb3b78fb07b28dab7e1af1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52b3036d9256eb3cd09e50a90a7b6bc7393215382ddb3b78fb07b28dab7e1af1", kill_on_drop: false }` [INFO] [stdout] 52b3036d9256eb3cd09e50a90a7b6bc7393215382ddb3b78fb07b28dab7e1af1