[INFO] fetching crate ledcat 0.2.0... [INFO] checking ledcat-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ledcat 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ledcat 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ledcat 0.2.0 [INFO] finished tweaking crates.io crate ledcat 0.2.0 [INFO] tweaked toml for crates.io crate ledcat 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ledcat 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7281064bf40b85bb06a840ec4714ab73f7e7ceec7516bd9fd22a88ab70310c4c [INFO] running `Command { std: "docker" "start" "-a" "7281064bf40b85bb06a840ec4714ab73f7e7ceec7516bd9fd22a88ab70310c4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7281064bf40b85bb06a840ec4714ab73f7e7ceec7516bd9fd22a88ab70310c4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7281064bf40b85bb06a840ec4714ab73f7e7ceec7516bd9fd22a88ab70310c4c", kill_on_drop: false }` [INFO] [stdout] 7281064bf40b85bb06a840ec4714ab73f7e7ceec7516bd9fd22a88ab70310c4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c827d45d64e515e9a0ecaea16c3daa81f33b0a64954c1ff4e15317726350ba34 [INFO] running `Command { std: "docker" "start" "-a" "c827d45d64e515e9a0ecaea16c3daa81f33b0a64954c1ff4e15317726350ba34", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Checking environment v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.4.1 [INFO] [stderr] Checking gpio v0.4.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking assert_cli v0.6.3 [INFO] [stderr] Checking ledcat v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/driver/mod.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 24 | fn read_link_recursive(path: impl AsRef) -> io::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | match fs::read_link(path.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/geometry.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 22 | let d1 = Regex::new(r"^[1-9]\d*$").unwrap(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let d2 = Regex::new(r"^([1-9]\d*)x([1-9]\d*)$").unwrap(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | if let Some(cap) = d1.captures(s) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RecvError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:362:11 [INFO] [stdout] | [INFO] [stdout] 286 | let (err_tx, err_rx) = mpsc::channel(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | match err_rx.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `written_frame_size` is never used [INFO] [stdout] --> src/device/mod.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 61 | pub trait Device: Send { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 72 | fn written_frame_size(&self, num_pixels: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/driver/mod.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 36 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/driver/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | Nix(nix::Error), [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 37 | Nix(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `clock_phase` is never read [INFO] [stdout] --> src/driver/spidev.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Config { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 20 | pub clock_polarity: u8, [INFO] [stdout] 21 | pub clock_phase: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ledcat` (bin "ledcat") due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/driver/mod.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 24 | fn read_link_recursive(path: impl AsRef) -> io::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | match fs::read_link(path.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/geometry.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 22 | let d1 = Regex::new(r"^[1-9]\d*$").unwrap(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let d2 = Regex::new(r"^([1-9]\d*)x([1-9]\d*)$").unwrap(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | if let Some(cap) = d1.captures(s) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RecvError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:362:11 [INFO] [stdout] | [INFO] [stdout] 286 | let (err_tx, err_rx) = mpsc::channel(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | match err_rx.recv() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `written_frame_size` is never used [INFO] [stdout] --> src/device/mod.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 61 | pub trait Device: Send { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 72 | fn written_frame_size(&self, num_pixels: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/driver/mod.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | Io(io::Error), [INFO] [stdout] | -- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 36 | Io(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/driver/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | Nix(nix::Error), [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 37 | Nix(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `clock_phase` is never read [INFO] [stdout] --> src/driver/spidev.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Config { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 20 | pub clock_polarity: u8, [INFO] [stdout] 21 | pub clock_phase: u8, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Config` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ledcat` (bin "ledcat" test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c827d45d64e515e9a0ecaea16c3daa81f33b0a64954c1ff4e15317726350ba34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c827d45d64e515e9a0ecaea16c3daa81f33b0a64954c1ff4e15317726350ba34", kill_on_drop: false }` [INFO] [stdout] c827d45d64e515e9a0ecaea16c3daa81f33b0a64954c1ff4e15317726350ba34