[INFO] fetching crate lance-core 0.18.0... [INFO] checking lance-core-0.18.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate lance-core 0.18.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate lance-core 0.18.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lance-core 0.18.0 [INFO] finished tweaking crates.io crate lance-core 0.18.0 [INFO] tweaked toml for crates.io crate lance-core 0.18.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 257 packages to latest compatible versions [INFO] [stderr] Adding arrow v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-arith v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-array v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-buffer v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-cast v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-csv v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-data v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-ipc v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-json v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-ord v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-row v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-schema v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-select v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding arrow-string v52.2.0 (available: v53.0.0) [INFO] [stderr] Adding async-io v1.13.0 (available: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (available: v3.4.0) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.14.2 (available: v0.18.1) [INFO] [stderr] Adding chrono-tz v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding datafusion-common v40.0.0 (available: v42.0.0) [INFO] [stderr] Adding datafusion-expr v40.0.0 (available: v42.0.0) [INFO] [stderr] Adding datafusion-sql v40.0.0 (available: v42.0.0) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (available: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (available: v2.3.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding io-lifetimes v1.0.11 (available: v2.0.3) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding lexical-core v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-parse-integer v0.8.6 (available: v1.0.2) [INFO] [stderr] Adding lexical-util v0.8.5 (available: v1.0.3) [INFO] [stderr] Adding lexical-write-float v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding lexical-write-integer v0.8.5 (available: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (available: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding mock_instant v0.3.2 (available: v0.5.1) [INFO] [stderr] Adding moka v0.11.3 (available: v0.12.8) [INFO] [stderr] Adding object_store v0.10.2 (available: v0.11.0) [INFO] [stderr] Adding polling v2.8.0 (available: v3.7.3) [INFO] [stderr] Adding prost v0.12.6 (available: v0.13.3) [INFO] [stderr] Adding prost-derive v0.12.6 (available: v0.13.3) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (available: v0.12.1) [INFO] [stderr] Adding quanta v0.11.1 (available: v0.12.3) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding raw-cpuid v10.7.0 (available: v11.1.0) [INFO] [stderr] Adding rustix v0.37.27 (available: v0.38.37) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding snafu v0.7.5 (available: v0.8.5) [INFO] [stderr] Adding snafu-derive v0.7.5 (available: v0.8.5) [INFO] [stderr] Adding socket2 v0.4.10 (available: v0.5.7) [INFO] [stderr] Adding sqlparser v0.47.0 (available: v0.51.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e101004bdbca3dedcc6b0187009e506e7447129cd7075d014a40aaa72f16d21 [INFO] running `Command { std: "docker" "start" "-a" "3e101004bdbca3dedcc6b0187009e506e7447129cd7075d014a40aaa72f16d21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e101004bdbca3dedcc6b0187009e506e7447129cd7075d014a40aaa72f16d21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e101004bdbca3dedcc6b0187009e506e7447129cd7075d014a40aaa72f16d21", kill_on_drop: false }` [INFO] [stdout] 3e101004bdbca3dedcc6b0187009e506e7447129cd7075d014a40aaa72f16d21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b16d861ed3286fa979221b12e7ed3967f4400b58494e753fa981020eb444bc95 [INFO] running `Command { std: "docker" "start" "-a" "b16d861ed3286fa979221b12e7ed3967f4400b58494e753fa981020eb444bc95", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Compiling moka v0.11.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking quanta v0.11.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking roaring v0.10.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking mock_instant v0.3.2 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling prost-derive v0.12.6 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking prost v0.12.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling deepsize_derive v0.1.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking deepsize v0.2.0 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking lance-arrow v0.18.0 [INFO] [stderr] Checking lance-testing v0.18.0 [INFO] [stderr] Checking lance-core v0.18.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/field.rs:266:34 [INFO] [stdout] | [INFO] [stdout] 264 | let data_type = self.data_type(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | match data_type { [INFO] [stdout] 266 | DataType::Dictionary(key_type, _) => match key_type.as_ref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/datatypes/field.rs:266:34 [INFO] [stdout] | [INFO] [stdout] 264 | let data_type = self.data_type(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | match data_type { [INFO] [stdout] 266 | DataType::Dictionary(key_type, _) => match key_type.as_ref() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lance-core` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `error::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:385:15 [INFO] [stdout] | [INFO] [stdout] 378 | let f: Box Result<()>> = Box::new(|| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | match f().unwrap_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll<::Output>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/futures.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 223 | let noop_waker = futures::task::noop_waker(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let mut context = std::task::Context::from_waker(&noop_waker); [INFO] [stdout] 225 | fut.poll_unpin(&mut context).is_pending() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lance-core` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "b16d861ed3286fa979221b12e7ed3967f4400b58494e753fa981020eb444bc95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b16d861ed3286fa979221b12e7ed3967f4400b58494e753fa981020eb444bc95", kill_on_drop: false }` [INFO] [stdout] b16d861ed3286fa979221b12e7ed3967f4400b58494e753fa981020eb444bc95