[INFO] fetching crate kvsd 0.1.3... [INFO] checking kvsd-0.1.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate kvsd 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate kvsd 0.1.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate kvsd 0.1.3 [INFO] finished tweaking crates.io crate kvsd 0.1.3 [INFO] tweaked toml for crates.io crate kvsd 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate kvsd 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 390c5a8a41d2aa46c37325f4953f15eafe2e3a95b93d6a54241c2651507eaddd [INFO] running `Command { std: "docker" "start" "-a" "390c5a8a41d2aa46c37325f4953f15eafe2e3a95b93d6a54241c2651507eaddd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "390c5a8a41d2aa46c37325f4953f15eafe2e3a95b93d6a54241c2651507eaddd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "390c5a8a41d2aa46c37325f4953f15eafe2e3a95b93d6a54241c2651507eaddd", kill_on_drop: false }` [INFO] [stdout] 390c5a8a41d2aa46c37325f4953f15eafe2e3a95b93d6a54241c2651507eaddd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e23dafb898f7cc1c2b7bdd21aacad835a3d42d918384148fd39817d184500843 [INFO] running `Command { std: "docker" "start" "-a" "e23dafb898f7cc1c2b7bdd21aacad835a3d42d918384148fd39817d184500843", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking rustls-pki-types v1.3.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling rustls v0.22.2 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rustls-pemfile v2.1.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking atoi v0.3.3 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking tokio-test v0.4.3 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking kvsd v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/tcp.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | let maybe_message = tokio::select! { [INFO] [stdout] | _________________^^^^^^^^^^^^^___- [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] | |_________________________________| [INFO] [stdout] | | [INFO] [stdout] 399 | | msg = connection.read_message() => msg?, [INFO] [stdout] 400 | | _ = self.shutdown.recv() => { [INFO] [stdout] 401 | | return Ok(()) [INFO] [stdout] 402 | | } [INFO] [stdout] 403 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: this value of type `Work>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/table/table.rs:88:29 [INFO] [stdout] | [INFO] [stdout] 64 | async fn handle_uow(&mut self, uow: UnitOfWork) -> Result<()> { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | UnitOfWork::Get(get) => { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/core/principal/mod.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | User(User), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Principal` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 7 | User(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvsd` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e23dafb898f7cc1c2b7bdd21aacad835a3d42d918384148fd39817d184500843", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e23dafb898f7cc1c2b7bdd21aacad835a3d42d918384148fd39817d184500843", kill_on_drop: false }` [INFO] [stdout] e23dafb898f7cc1c2b7bdd21aacad835a3d42d918384148fd39817d184500843