[INFO] fetching crate knightrs 0.8.12... [INFO] checking knightrs-0.8.12 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate knightrs 0.8.12 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate knightrs 0.8.12 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate knightrs 0.8.12 [INFO] finished tweaking crates.io crate knightrs 0.8.12 [INFO] tweaked toml for crates.io crate knightrs 0.8.12 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate knightrs 0.8.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e16d049c824df1ca538598f6406d34af2cb2e5d6a973b49cf54c43370a651146 [INFO] running `Command { std: "docker" "start" "-a" "e16d049c824df1ca538598f6406d34af2cb2e5d6a973b49cf54c43370a651146", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e16d049c824df1ca538598f6406d34af2cb2e5d6a973b49cf54c43370a651146", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e16d049c824df1ca538598f6406d34af2cb2e5d6a973b49cf54c43370a651146", kill_on_drop: false }` [INFO] [stdout] e16d049c824df1ca538598f6406d34af2cb2e5d6a973b49cf54c43370a651146 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b8e028b0cd4cfc84aef97abb08e19e5a98a61e90af49725390d41c6bb38dab0 [INFO] running `Command { std: "docker" "start" "-a" "2b8e028b0cd4cfc84aef97abb08e19e5a98a61e90af49725390d41c6bb38dab0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.91 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking knightrs v0.8.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `Feature` [INFO] [stdout] --> src/function.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | #[cfg(Feature="variable-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] help: there is a config with a similar name and value (notice the capitalization difference) [INFO] [stdout] | [INFO] [stdout] 151 | #[cfg(feature="variable-lookup")] [INFO] [stdout] | ~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `Feature` [INFO] [stdout] --> src/function.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | #[cfg(Feature="variable-lookup")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] help: there is a config with a similar name and value (notice the capitalization difference) [INFO] [stdout] | [INFO] [stdout] 151 | #[cfg(feature="variable-lookup")] [INFO] [stdout] | ~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Text` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function.rs:195:15 [INFO] [stdout] | [INFO] [stdout] 193 | let ran = args[0].run(env)?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | [INFO] [stdout] 195 | env.run_str(&ran.to_text()?) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Text` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function.rs:195:15 [INFO] [stdout] | [INFO] [stdout] 193 | let ran = args[0].run(env)?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | [INFO] [stdout] 195 | env.run_str(&ran.to_text()?) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Variable` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function.rs:202:2 [INFO] [stdout] | [INFO] [stdout] 200 | let ran = args[0].run(env)?.to_text()?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | env.get(&ran).run() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Variable` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/function.rs:202:2 [INFO] [stdout] | [INFO] [stdout] 200 | let ran = args[0].run(env)?.to_text()?; [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | env.get(&ran).run() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/text.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe { &EMPTY }.get_or_init(|| unsafe { Self::new_unchecked("") }).clone() [INFO] [stdout] | ^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 51 | unsafe { &raw const EMPTY }.get_or_init(|| unsafe { Self::new_unchecked("") }).clone() [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:108:30 [INFO] [stdout] | [INFO] [stdout] 108 | Value::Null => Ok(unsafe {&NULL}.get_or_init(|| unsafe { Self::new_unchecked("null") }).clone()), [INFO] [stdout] | ^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 108 | Value::Null => Ok(unsafe {&raw const NULL}.get_or_init(|| unsafe { Self::new_unchecked("null") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:109:39 [INFO] [stdout] | [INFO] [stdout] 109 | Value::Boolean(true) => Ok(unsafe {&TRUE}.get_or_init(|| unsafe { Self::new_unchecked("true") }).clone()), [INFO] [stdout] | ^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 109 | Value::Boolean(true) => Ok(unsafe {&raw const TRUE}.get_or_init(|| unsafe { Self::new_unchecked("true") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:110:40 [INFO] [stdout] | [INFO] [stdout] 110 | Value::Boolean(false) => Ok(unsafe {&FALSE}.get_or_init(|| unsafe { Self::new_unchecked("false") }).clone()), [INFO] [stdout] | ^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 110 | Value::Boolean(false) => Ok(unsafe {&raw const FALSE}.get_or_init(|| unsafe { Self::new_unchecked("false") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:111:35 [INFO] [stdout] | [INFO] [stdout] 111 | Value::Number(0) => Ok(unsafe {&ZERO}.get_or_init(|| unsafe { Self::new_unchecked("0") }).clone()), [INFO] [stdout] | ^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 111 | Value::Number(0) => Ok(unsafe {&raw const ZERO}.get_or_init(|| unsafe { Self::new_unchecked("0") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:112:35 [INFO] [stdout] | [INFO] [stdout] 112 | Value::Number(1) => Ok(unsafe {&ONE}.get_or_init(|| unsafe { Self::new_unchecked("1") }).clone()), [INFO] [stdout] | ^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 112 | Value::Number(1) => Ok(unsafe {&raw const ONE}.get_or_init(|| unsafe { Self::new_unchecked("1") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `knightrs` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/text.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe { &EMPTY }.get_or_init(|| unsafe { Self::new_unchecked("") }).clone() [INFO] [stdout] | ^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 51 | unsafe { &raw const EMPTY }.get_or_init(|| unsafe { Self::new_unchecked("") }).clone() [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:108:30 [INFO] [stdout] | [INFO] [stdout] 108 | Value::Null => Ok(unsafe {&NULL}.get_or_init(|| unsafe { Self::new_unchecked("null") }).clone()), [INFO] [stdout] | ^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 108 | Value::Null => Ok(unsafe {&raw const NULL}.get_or_init(|| unsafe { Self::new_unchecked("null") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:109:39 [INFO] [stdout] | [INFO] [stdout] 109 | Value::Boolean(true) => Ok(unsafe {&TRUE}.get_or_init(|| unsafe { Self::new_unchecked("true") }).clone()), [INFO] [stdout] | ^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 109 | Value::Boolean(true) => Ok(unsafe {&raw const TRUE}.get_or_init(|| unsafe { Self::new_unchecked("true") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:110:40 [INFO] [stdout] | [INFO] [stdout] 110 | Value::Boolean(false) => Ok(unsafe {&FALSE}.get_or_init(|| unsafe { Self::new_unchecked("false") }).clone()), [INFO] [stdout] | ^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 110 | Value::Boolean(false) => Ok(unsafe {&raw const FALSE}.get_or_init(|| unsafe { Self::new_unchecked("false") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:111:35 [INFO] [stdout] | [INFO] [stdout] 111 | Value::Number(0) => Ok(unsafe {&ZERO}.get_or_init(|| unsafe { Self::new_unchecked("0") }).clone()), [INFO] [stdout] | ^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 111 | Value::Number(0) => Ok(unsafe {&raw const ZERO}.get_or_init(|| unsafe { Self::new_unchecked("0") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/value.rs:112:35 [INFO] [stdout] | [INFO] [stdout] 112 | Value::Number(1) => Ok(unsafe {&ONE}.get_or_init(|| unsafe { Self::new_unchecked("1") }).clone()), [INFO] [stdout] | ^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 112 | Value::Number(1) => Ok(unsafe {&raw const ONE}.get_or_init(|| unsafe { Self::new_unchecked("1") }).clone()), [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `knightrs` (lib) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2b8e028b0cd4cfc84aef97abb08e19e5a98a61e90af49725390d41c6bb38dab0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b8e028b0cd4cfc84aef97abb08e19e5a98a61e90af49725390d41c6bb38dab0", kill_on_drop: false }` [INFO] [stdout] 2b8e028b0cd4cfc84aef97abb08e19e5a98a61e90af49725390d41c6bb38dab0