[INFO] fetching crate kernel-sidecar 0.1.0... [INFO] checking kernel-sidecar-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate kernel-sidecar 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate kernel-sidecar 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kernel-sidecar 0.1.0 [INFO] finished tweaking crates.io crate kernel-sidecar 0.1.0 [INFO] tweaked toml for crates.io crate kernel-sidecar 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate kernel-sidecar 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec20e433bcd4d18af539842c13d7a96733576dc34ab2a62f3908e47b64052db0 [INFO] running `Command { std: "docker" "start" "-a" "ec20e433bcd4d18af539842c13d7a96733576dc34ab2a62f3908e47b64052db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec20e433bcd4d18af539842c13d7a96733576dc34ab2a62f3908e47b64052db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec20e433bcd4d18af539842c13d7a96733576dc34ab2a62f3908e47b64052db0", kill_on_drop: false }` [INFO] [stdout] ec20e433bcd4d18af539842c13d7a96733576dc34ab2a62f3908e47b64052db0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ebb06370addc4af02d516eacd97ba9d17c3d3a9800887cf617796c689f8dd9d [INFO] running `Command { std: "docker" "start" "-a" "2ebb06370addc4af02d516eacd97ba9d17c3d3a9800887cf617796c689f8dd9d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.12.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking asynchronous-codec v0.7.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking zeromq v0.3.4 [INFO] [stderr] Checking kernel-sidecar v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `SubSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 225 | msg_tx: mpsc::Sender, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | shutdown_signal: Arc, [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | ) { [INFO] [stdout] 228 | let mut socket = SubSocket::new(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | / tokio::select! { [INFO] [stdout] 234 | | Ok(msg) = socket.recv() => { [INFO] [stdout] 235 | | msg_tx.send(msg).await.unwrap(); [INFO] [stdout] 236 | | }, [INFO] [stdout] ... | [INFO] [stdout] 239 | | } [INFO] [stdout] 240 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SubSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 225 | msg_tx: mpsc::Sender, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | shutdown_signal: Arc, [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | ) { [INFO] [stdout] 228 | let mut socket = SubSocket::new(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | / tokio::select! { [INFO] [stdout] 234 | | Ok(msg) = socket.recv() => { [INFO] [stdout] 235 | | msg_tx.send(msg).await.unwrap(); [INFO] [stdout] 236 | | }, [INFO] [stdout] ... | [INFO] [stdout] 239 | | } [INFO] [stdout] 240 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DealerSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 249 | mut msg_rx: mpsc::Receiver, // Client wants to send Jupyter message over ZMQ [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | msg_tx: mpsc::Sender, // Kernel sent a reply over ZMQ, needs to get processed [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | shutdown_signal: Arc, [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | ) { [INFO] [stdout] 253 | let mut socket = DealerSocket::new(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 257 | / tokio::select! { [INFO] [stdout] 258 | | Some(client_to_kernel_msg) = msg_rx.recv() => { [INFO] [stdout] 259 | | socket.send(client_to_kernel_msg).await.unwrap(); [INFO] [stdout] 260 | | } [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DealerSocket` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 249 | mut msg_rx: mpsc::Receiver, // Client wants to send Jupyter message over ZMQ [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | msg_tx: mpsc::Sender, // Kernel sent a reply over ZMQ, needs to get processed [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | shutdown_signal: Arc, [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | ) { [INFO] [stdout] 253 | let mut socket = DealerSocket::new(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 257 | / tokio::select! { [INFO] [stdout] 258 | | Some(client_to_kernel_msg) = msg_rx.recv() => { [INFO] [stdout] 259 | | socket.send(client_to_kernel_msg).await.unwrap(); [INFO] [stdout] 260 | | } [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jupyter/header.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 34 | fn from(bytes: Bytes) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | match serde_json::from_slice::
(&bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/jupyter/header.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 34 | fn from(bytes: Bytes) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | match serde_json::from_slice::
(&bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kernel-sidecar` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kernel-sidecar` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "2ebb06370addc4af02d516eacd97ba9d17c3d3a9800887cf617796c689f8dd9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ebb06370addc4af02d516eacd97ba9d17c3d3a9800887cf617796c689f8dd9d", kill_on_drop: false }` [INFO] [stdout] 2ebb06370addc4af02d516eacd97ba9d17c3d3a9800887cf617796c689f8dd9d