[INFO] fetching crate jxl_dynlink 0.1.0... [INFO] checking jxl_dynlink-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate jxl_dynlink 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate jxl_dynlink 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jxl_dynlink 0.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate jxl_dynlink 0.1.0 [INFO] tweaked toml for crates.io crate jxl_dynlink 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (available: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 725bfbbc2a5da1dd403b5ca04c5c06c6ae6829369b1d0bc41ec293cc83e6bca2 [INFO] running `Command { std: "docker" "start" "-a" "725bfbbc2a5da1dd403b5ca04c5c06c6ae6829369b1d0bc41ec293cc83e6bca2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "725bfbbc2a5da1dd403b5ca04c5c06c6ae6829369b1d0bc41ec293cc83e6bca2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "725bfbbc2a5da1dd403b5ca04c5c06c6ae6829369b1d0bc41ec293cc83e6bca2", kill_on_drop: false }` [INFO] [stdout] 725bfbbc2a5da1dd403b5ca04c5c06c6ae6829369b1d0bc41ec293cc83e6bca2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cda9b195bef128d4773c930027b6a8718d5825cf893438cd2b49b288f2c5cea [INFO] running `Command { std: "docker" "start" "-a" "2cda9b195bef128d4773c930027b6a8718d5825cf893438cd2b49b288f2c5cea", kill_on_drop: false }` [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking fdeflate v0.3.5 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking jxl_dynlink v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `img` [INFO] [stdout] --> tests/encorder_test.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | let img = image::open(input_path).expect("Failed to load image"); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_img` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> tests/decorder_test.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 216 | return (); [INFO] [stdout] | --------- any code following this expression is unreachable [INFO] [stdout] 217 | [INFO] [stdout] 218 | let mut buffer = vec![0u8; 1024]; // Dummy buffer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> tests/decorder_test.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 240 | return (); [INFO] [stdout] | --------- any code following this expression is unreachable [INFO] [stdout] 241 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> tests/decorder_test.rs:289:5 [INFO] [stdout] | [INFO] [stdout] 288 | return (); [INFO] [stdout] | --------- any code following this expression is unreachable [INFO] [stdout] 289 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `decoder` [INFO] [stdout] --> tests/decorder_test.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_decoder` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/decorder_test.rs:140:11 [INFO] [stdout] | [INFO] [stdout] 127 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | match decoder.get_color_as_encoded_profile(JxlColorProfileTarget::Data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/decorder_test.rs:155:11 [INFO] [stdout] | [INFO] [stdout] 148 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | match decoder.get_extra_channel_name(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, jxl_dynlink::JxlError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/decorder_test.rs:170:11 [INFO] [stdout] | [INFO] [stdout] 163 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | match decoder.get_color_as_icc(JxlColorProfileTarget::Data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `decoder` [INFO] [stdout] --> tests/decorder_test.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 314 | let decoder = JxlDecoder::new(DLL_PATH).expect("Failed to create decoder"); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_decoder` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> tests/decorder_test.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | let mut buffer = read_jxl_file("test_imgs/test.jxl").expect("Failed to read test.jxl"); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/decorder_test.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | let mut buffer = read_jxl_file("test_imgs/test.jxl").expect("Failed to read test.jxl"); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `frame_header` is never read [INFO] [stdout] --> tests/decorder_test.rs:376:13 [INFO] [stdout] | [INFO] [stdout] 376 | let mut frame_header = None; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `buffer_size` is never read [INFO] [stdout] --> tests/decorder_test.rs:515:13 [INFO] [stdout] | [INFO] [stdout] 515 | let mut buffer_size = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jxl_dynlink` (test "decorder_test") due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2cda9b195bef128d4773c930027b6a8718d5825cf893438cd2b49b288f2c5cea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cda9b195bef128d4773c930027b6a8718d5825cf893438cd2b49b288f2c5cea", kill_on_drop: false }` [INFO] [stdout] 2cda9b195bef128d4773c930027b6a8718d5825cf893438cd2b49b288f2c5cea