[INFO] fetching crate jtd-infer 0.2.1... [INFO] checking jtd-infer-0.2.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate jtd-infer 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate jtd-infer 0.2.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jtd-infer 0.2.1 [INFO] finished tweaking crates.io crate jtd-infer 0.2.1 [INFO] tweaked toml for crates.io crate jtd-infer 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate jtd-infer 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe0dfecefb58aea08696fbabc02a6328da0bc24d33bf6d8139f4782e13c4d97b [INFO] running `Command { std: "docker" "start" "-a" "fe0dfecefb58aea08696fbabc02a6328da0bc24d33bf6d8139f4782e13c4d97b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe0dfecefb58aea08696fbabc02a6328da0bc24d33bf6d8139f4782e13c4d97b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe0dfecefb58aea08696fbabc02a6328da0bc24d33bf6d8139f4782e13c4d97b", kill_on_drop: false }` [INFO] [stdout] fe0dfecefb58aea08696fbabc02a6328da0bc24d33bf6d8139f4782e13c4d97b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] feafb9372f1767a17f575a36e74dc2e158a12b4869a4f2a3f205d211df46e03d [INFO] running `Command { std: "docker" "start" "-a" "feafb9372f1767a17f575a36e74dc2e158a12b4869a4f2a3f205d211df46e03d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling thiserror-impl v1.0.23 [INFO] [stderr] Checking thiserror v1.0.23 [INFO] [stderr] Checking serde_json v1.0.51 [INFO] [stderr] Checking jtd v0.3.1 [INFO] [stderr] Checking jtd-infer v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inferred_schema.rs:318:38 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn into_schema(self, hints: &Hints) -> Schema { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | InferredSchema::Nullable(sub_infer) => match sub_infer.into_schema(hints) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/inferred_schema.rs:169:52 [INFO] [stdout] | [INFO] [stdout] 169 | .filter(|k| !map.contains_key(k.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jtd-infer` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inferred_schema.rs:318:38 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn into_schema(self, hints: &Hints) -> Schema { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | InferredSchema::Nullable(sub_infer) => match sub_infer.into_schema(hints) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&std::string::String` instead of cloning the inner type [INFO] [stdout] --> src/inferred_schema.rs:169:52 [INFO] [stdout] | [INFO] [stdout] 169 | .filter(|k| !map.contains_key(k.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jtd-infer` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "feafb9372f1767a17f575a36e74dc2e158a12b4869a4f2a3f205d211df46e03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feafb9372f1767a17f575a36e74dc2e158a12b4869a4f2a3f205d211df46e03d", kill_on_drop: false }` [INFO] [stdout] feafb9372f1767a17f575a36e74dc2e158a12b4869a4f2a3f205d211df46e03d