[INFO] fetching crate jsonapi 0.7.0... [INFO] checking jsonapi-0.7.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate jsonapi 0.7.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate jsonapi 0.7.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate jsonapi 0.7.0 [INFO] finished tweaking crates.io crate jsonapi 0.7.0 [INFO] tweaked toml for crates.io crate jsonapi 0.7.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (available: v1.1.3) [INFO] [stderr] Adding env_logger v0.7.1 (available: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (available: v2.1.0) [INFO] [stderr] Adding idna v0.1.5 (available: v1.0.2) [INFO] [stderr] Adding percent-encoding v1.0.1 (available: v2.3.1) [INFO] [stderr] Adding queryst v2.1.0 (available: v3.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding regex v0.2.11 (available: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (available: v0.8.4) [INFO] [stderr] Adding thread_local v0.3.6 (available: v1.1.8) [INFO] [stderr] Adding ucd-util v0.1.10 (available: v0.2.1) [INFO] [stderr] Adding url v1.7.2 (available: v2.5.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a8115587d093df26d1880c67c4a6b3d0c54179f5e7d96cc52985794aebdbc71a [INFO] running `Command { std: "docker" "start" "-a" "a8115587d093df26d1880c67c4a6b3d0c54179f5e7d96cc52985794aebdbc71a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a8115587d093df26d1880c67c4a6b3d0c54179f5e7d96cc52985794aebdbc71a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8115587d093df26d1880c67c4a6b3d0c54179f5e7d96cc52985794aebdbc71a", kill_on_drop: false }` [INFO] [stdout] a8115587d093df26d1880c67c4a6b3d0c54179f5e7d96cc52985794aebdbc71a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 38fe137cb56f0d27179b64bacf76052da8dc20e1e6eebc34d7660b5f4fbd5a69 [INFO] running `Command { std: "docker" "start" "-a" "38fe137cb56f0d27179b64bacf76052da8dc20e1e6eebc34d7660b5f4fbd5a69", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Checking queryst v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking jsonapi v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/model.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 82 - panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] 82 + panic!("{} is not a Value::Object", self.jsonapi_type()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/model.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 82 - panic!(format!("{} is not a Value::Object", self.jsonapi_type())) [INFO] [stdout] 82 + panic!("{} is not a Value::Object", self.jsonapi_type()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> tests/helper.rs:11:68 [INFO] [stdout] | [INFO] [stdout] 11 | Err(why) => panic!("couldn't open {}: {}", display, Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> tests/helper.rs:18:56 [INFO] [stdout] | [INFO] [stdout] 18 | panic!("couldn't read {}: {}", display, Error::description(&why)); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> tests/helper.rs:11:68 [INFO] [stdout] | [INFO] [stdout] 11 | Err(why) => panic!("couldn't open {}: {}", display, Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> tests/helper.rs:18:56 [INFO] [stdout] | [INFO] [stdout] 18 | panic!("couldn't read {}: {}", display, Error::description(&why)); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> tests/helper.rs:11:68 [INFO] [stdout] | [INFO] [stdout] 11 | Err(why) => panic!("couldn't open {}: {}", display, Error::description(&why)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> tests/helper.rs:18:56 [INFO] [stdout] | [INFO] [stdout] 18 | panic!("couldn't read {}: {}", display, Error::description(&why)); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `jsonapi::api::JsonApiDocument` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/api_test.rs:205:12 [INFO] [stdout] | [INFO] [stdout] 202 | let data: Result = serde_json::from_str(&s); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | Ok(res) => { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `jsonapi::api::JsonApiDocument` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/api_test.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 241 | let data: Result = serde_json::from_str(&s); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | Ok(x) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jsonapi` (test "api_test") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "38fe137cb56f0d27179b64bacf76052da8dc20e1e6eebc34d7660b5f4fbd5a69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38fe137cb56f0d27179b64bacf76052da8dc20e1e6eebc34d7660b5f4fbd5a69", kill_on_drop: false }` [INFO] [stdout] 38fe137cb56f0d27179b64bacf76052da8dc20e1e6eebc34d7660b5f4fbd5a69